Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] [perf/core: Update sample_flags for raw_data in
 perf_output_sample
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <Y1Fd57P5I+aSNT/V@hirez.programming.kicks-ass.net>
Date:   Wed, 2 Nov 2022 13:49:34 +0530
Cc:     Ian Rogers <irogers@google.com>,
        Madhavan Srinivasan <maddy@linux.ibm.com>,
        Nageswara Sastry <rnsastry@linux.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-perf-users@vger.kernel.org,
        James Clark <james.clark@arm.com>,
        Jiri Olsa <jolsa@kernel.org>, Kajol Jain <kjain@linux.ibm.com>,
        Namhyung Kim <namhyung@kernel.org>, disgoel@linux.ibm.com,
        linuxppc-dev@lists.ozlabs.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <164ED8DD-C9A0-40C2-AA12-EB8FA9D4C4C1@linux.vnet.ibm.com>
References: <20221020070657.21571-1-atrajeev@linux.vnet.ibm.com>
 <Y1Fd57P5I+aSNT/V@hirez.programming.kicks-ass.net>
To:     Peter Zijlstra <peterz@infradead.org>
Precedence: bulk


> On 20-Oct-2022, at 8:10 PM, Peter Zijlstra <peterz@infradead.org> =
wrote:
>=20
> On Thu, Oct 20, 2022 at 12:36:56PM +0530, Athira Rajeev wrote:
>> commit 838d9bb62d13 ("perf: Use sample_flags for raw_data")
>> added check for PERF_SAMPLE_RAW in sample_flags in
>> perf_prepare_sample(). But while copying the sample in memory,
>> the check for sample_flags is not added in perf_output_sample().
>> Fix adds the same in perf_output_sample as well.
>>=20
>> Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
>> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
>> ---
>> kernel/events/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index 4ec3717003d5..daf387c75d33 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -7099,7 +7099,7 @@ void perf_output_sample(struct =
perf_output_handle *handle,
>> 	if (sample_type & PERF_SAMPLE_RAW) {
>> 		struct perf_raw_record *raw =3D data->raw;
>>=20
>> -		if (raw) {
>> +		if (raw && (data->sample_flags & PERF_SAMPLE_RAW)) {
>> 			struct perf_raw_frag *frag =3D &raw->frag;
>>=20
>> 			perf_output_put(handle, raw->size);
>=20
> Urgh.. something smells here. We already did a PERF_SAMPLE_RAW test.
>=20
> And perf_prepare_sample() explicitly makes data->raw be NULL when not
> set earlier.
>=20
> So what's going wrong?

Hi Peter,

Sorry for late response. I was out on vacation couple of days.

I didn't hit any specific issue or fail with current code. But patch =
intention was
to keep the perf_prepare_sample and perf_output_sample to be in sync =
with the checks that we
are doing.

Thanks
Athira