Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3754315rwi; Wed, 2 Nov 2022 02:43:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Wrru5ORAEZMOYtUk5fD0oOfbinGOIZAR6rq+rC8OgL5+wzcUhF3jgz6LcY3qR943cWRQd X-Received: by 2002:a63:4d0c:0:b0:46f:932:450a with SMTP id a12-20020a634d0c000000b0046f0932450amr20694337pgb.204.1667382209779; Wed, 02 Nov 2022 02:43:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667382209; cv=none; d=google.com; s=arc-20160816; b=T5VXOovLqkqU0ZInMBSUFMzVPzx15MIjVFWCeMixLM0kdGVZ5fCmCveKkWuq8TkI4E A004qj78lWS0Rh0CTtowSGTIx2izpCoKuQVewu5qSIS/J6Hcg3xzmexnc1NryTJqXiUX vwssxr6jS2CDnaOECHapGg2Xh4slwHBqhMeykNMteH7J6tpS4tCTEpqX7Z7cgahZ1hEb C6NGVRWU4/4EcdQNEHVrOTX4LSWbhbID6vntPzBdN77TmVynOO080P5z39TZqNyYdWxL rFdpJfvUn+ntBv1xPkqIb2vC46GAi35ByQP0dh9HxSSffH5mfvShrUsA73Od/HZF6GBU ybGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A0v1SSP7U6jTvUstX50tbbFbb8CtyALOrKeuLWDyfEk=; b=yj22MmBMLha9Pxn1z0NwvQhdhhDxYISlzunaRI8z/Q8QD12h5dbO947cc3C7KNDlVl FDVbcedMXy5wycEh/VjctOfyR+8PJ5vYWVk0dcHwZSxcslwctiJdyHpFz+UoVGJbbr/i Xdd+M3zNVMeos6YD9o8xcFb0BNrgfQRaWIC9HEpLbAO54MkQwLmUS0GpsbTxGD3vaPBa fDi8EBKdgbhz46bULENyuPwcYhsLyqJRhh2aq+PcKwR6wTAJk+46p8v7Wn1dDC4vBZ8R bguK+BGDtVbeMQwnC7+RTkmFlg8mYH0h1C/gSVmWo29xN58i2ZoG3fAVJSniAYVRV8gc 9kCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=OgAQ+L5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a5-20020a63d205000000b0046fad9b36c6si12833411pgg.155.2022.11.02.02.43.17; Wed, 02 Nov 2022 02:43:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=OgAQ+L5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbiKBJ1w (ORCPT + 97 others); Wed, 2 Nov 2022 05:27:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiKBJ1b (ORCPT ); Wed, 2 Nov 2022 05:27:31 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3272AD for ; Wed, 2 Nov 2022 02:26:44 -0700 (PDT) Received: from zn.tnic (p200300ea9733e741329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e741:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 80EAB1EC0430; Wed, 2 Nov 2022 10:26:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667381202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=A0v1SSP7U6jTvUstX50tbbFbb8CtyALOrKeuLWDyfEk=; b=OgAQ+L5YcVvR26mLMQSB4Vcad5uowOGgWp/UNQ0HImLvIre2uKl0eXFxvSvywZ2W1caklz LO9POthkj+T57/rFr46sZZxJjuOxwCFVgAxpGqIeGee5nEHhD1qcL4NgCUrXqCgku+lOcj GfpqEzWHSBq7wX6xJQwNuxRX+X1K0V8= Date: Wed, 2 Nov 2022 10:26:37 +0100 From: Borislav Petkov To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support Message-ID: References: <20221031193604.28779-1-eric.devolder@oracle.com> <20221031193604.28779-8-eric.devolder@oracle.com> <1c11a429-b5a9-fb55-fbef-b49e760e2d1e@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1c11a429-b5a9-fb55-fbef-b49e760e2d1e@oracle.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote: > As I'm re-reading that message, I suspect now the preference is to just to > strike this ifdiffery line in this file and have the code always present? > > If the preference is actually for CRASH_HOTPLUG, then let me know. Well, it is this part: "But on a plain simple laptop or workstation which has CPU hotplug, would it make sense for the crash ranges to get updated too when CPUs are offlined? If so, I think you want this code present there too, without a Kconfig item." IOW, if this thing doesn't make sense to have on the majority of machines out there - and memory hotplug machines are not the majority - then it should be behind a Kconfig item which is default off and gets enabled only when the user selects crash and memory hotplug... I'd say. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette