Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] locking/refcount: Use REFCOUNT_WARN() to simplify code
To:     Will Deacon <will@kernel.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220316125114.1177-1-thunder.leizhen@huawei.com>
 <20220404093103.GA22875@willie-the-truck>
From:   "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Message-ID: <649a91cf-5a43-e9b6-7071-03fc3fd3039a@huawei.com>
Date:   Wed, 2 Nov 2022 17:41:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20220404093103.GA22875@willie-the-truck>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/4/4 17:31, Will Deacon wrote:
> On Wed, Mar 16, 2022 at 08:51:14PM +0800, Zhen Lei wrote:
>> To avoid the check "new > val" appears twice, and make the style
>> consistent with that in refcount_warn_saturate().
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  lib/refcount.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/refcount.c b/lib/refcount.c
>> index a207a8f22b3ca35..d36aa3fa728f53b 100644
>> --- a/lib/refcount.c
>> +++ b/lib/refcount.c
>> @@ -84,7 +84,7 @@ bool refcount_dec_not_one(refcount_t *r)
>>  
>>  		new = val - 1;
>>  		if (new > val) {
>> -			WARN_ONCE(new > val, "refcount_t: underflow; use-after-free.\n");
>> +			REFCOUNT_WARN("underflow; use-after-free");
>>  			return true;
>>  		}
> 
> Acked-by: Will Deacon <will@kernel.org>

Can anyone pick up this patch? It seems to have been forgotten.

> 
> Will
> .
> 

-- 
Regards,
  Zhen Lei