Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <044540cc-1d8b-45da-ac8b-ecc133b45dc1@amd.com>
Date:   Wed, 2 Nov 2022 11:46:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] drm/msm: Remove exclusive-fence hack
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Rob Clark <robdclark@chromium.org>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DMA BUFFER SHARING FRAMEWORK" 
        <linux-media@vger.kernel.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>
References: <20221101214051.159988-1-robdclark@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221101214051.159988-1-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU8wQmJ0NjZuS0YwSHhDNHkyTTRocXNrdjFxSG1iSmhkWW1HM3h3WHR4Rm9R?=
 =?utf-8?B?T0hjWjlJakh2Y0pSZXE2Kzd5elVDMExFZm0wazdaOTJ3Q084UExwWWFXc3V5?=
 =?utf-8?B?ek5VOEhiOHZjOXVaK1NJL3YyWm00alExOFAySks1Vkx0bkd1WUtmNU41czNN?=
 =?utf-8?B?dFByUG9qdHdyVkpHbUpQTTg4ZWJadHhYa3k5Z1ZCM25wTy9zdDRPblA5WW0w?=
 =?utf-8?B?MGlIbGxrdHhGbWVIYzJwcXlRY2llV0RqU1VYZmtRYlQ0RjA3WWpRbVFCU2E4?=
 =?utf-8?B?WjNFVG51QWROSUdzTnJ0by9oVTVwQ1BZem5kTHo3SW1HeGtvbWsyVUxYMXJx?=
 =?utf-8?B?bnFxUDVaaHJjYXpoc1lRN0drRmJRQUxNRGpGK0VXd3kxbHF2aHVrV29naUpG?=
 =?utf-8?B?cUtZbHhDbGJVN282ckFpTS9ZSGlrdWwyZ2k3MjNBcFUwVW02RnJwa1hFL2Uw?=
 =?utf-8?B?Z3J0Yk5WZEFOeFZQTnJOdkZpblAwNm4vUnR0MW5xblI0Rmd3VmlaL2tjR0hY?=
 =?utf-8?B?YmpkREFBeHZyL2JjWWFvQUZzT0tTQzdkaE9NaFBHLzhuc1JzK2llcHlIUU1G?=
 =?utf-8?B?TkNjTFFqYmNjU2ZyZGY4WEtuQitPWlpVRFVzNmpLUkFpVDFPZkZGZTBDdXYz?=
 =?utf-8?B?T1JSbVN6Q1BhVzJpT0tZeFlRemRjdHJlQ1lVTUJBVmFSTG5zSGtUbVZNeUNl?=
 =?utf-8?B?WmFYZytxb0VxTldWNnY2K005alZxS2drVGkvRTFHSlB5cW1DRzRnOUU4VXJy?=
 =?utf-8?B?NmJHa2tPcVJ3SjhkVlg4OEVxUDdjWkFQblVLZWhOSExIeUhMV2dNMy8rY0Vj?=
 =?utf-8?B?WU1rMnlCQXVSWTVIY0RUNTJLN2NrVzgvUHpSZmVvQjFhdGVjR1RXR3g0RXZG?=
 =?utf-8?B?eXpaWExrbVRBZkU1TWladXNzbFVWcU9XcFNSTWVPT0xlQlYvREZrckVzdU5s?=
 =?utf-8?B?czNNWWdYZ3R1VWJOeDNVMDRveEFZQkpzdkRLb1B6MVVlSlMyVXNmUFNoR3ZQ?=
 =?utf-8?B?b2luRkMzZHhwQWRWbERHOFhSQzY0OHZ3NTBicGxnb3hxVGtoQlBnZFUxUkFG?=
 =?utf-8?B?QmI0UzVJU3VIMnk2ajVrREZ2V1l2YldPZVJ5UmdLaXkzRXJYWFRYVG9UR21N?=
 =?utf-8?B?NXdwVCs2c05yRTl1aHNJNHF5VzdaZDB1dU5KYjRBU0tUN250OEVBLzdZUUc5?=
 =?utf-8?B?NHpGTk14VUhCQnVLRjcrQ0VyYXFUeUY2c0k5dDFzME1KRGhTbHVUdlBnUkl5?=
 =?utf-8?B?TUladWUzUUNwR1lwSnV3UDhEQTZEakZma0JWMDMwMTVhTGdudzQ5a1RxT1JM?=
 =?utf-8?B?aTlyUTg5YkJLdlZKT2JOMVNGalhLVUxjYnZ0dkdvQ2pQNVpYWGxiL0JkQlBB?=
 =?utf-8?B?c1J1a3B2dFdacGtOVFFIWkpDcFN3TFFwNXlLbXRONjRUYjd6VDFsR0R6TDZM?=
 =?utf-8?B?eERFYnZXc2RBMjVNZXpBbUdTZlppYjNvbGNtbFdzMzIrUUdEQi9GRlVFRzRZ?=
 =?utf-8?B?ODNneUdXTGd0ZmtFWlhEaXJXMXVSK0FsR3ozY0dxN0g4RHNaai9MMHpud3gx?=
 =?utf-8?B?ZC9acUNJaUtZVm5LSHpPTUd0YnRybzRwZkVPTmJ1anlOelR1UkVUSityOGIz?=
 =?utf-8?B?M3BIMFlDNkJXZE8wOGpVYVpsVzVHcmtKUEUxNWpvQ09sdFM0QmdJa0x0cTFF?=
 =?utf-8?B?bTljRHc1MkRRTHlsYVNNNHh3TUVodnErUWthVFM3Qk1UTGxtVyttL05OS3VT?=
 =?utf-8?B?WUlVOGQrUXBUZGRBQTIxQTlsZXhROTA5dDFtckdMcVd1c1I1VWZreU9leVp5?=
 =?utf-8?B?RzkwUVQ4OTdUOUcyMzNISmlFbUFwaHp4ZmNkWGtrYVBRc0x5ZjhTbEtGYk1B?=
 =?utf-8?B?YjJQWHpzR0lRUS95SFB2TE1lV0RXVGo1L1p1MWVaaWtvY0RQWVpFVEZmQVl2?=
 =?utf-8?B?WnlOUDdISTJiOG9oeWg3UjJuckx4R2xIdWRNYkJNU2xxbm8rVTVJdi9iT2lG?=
 =?utf-8?B?cWM2amZaZ24yd3JrZndNK1ZvOXFnZmFQUERFSkJscDkxTjZPa3ViTFhac09D?=
 =?utf-8?B?WmczTnltZ0tiYUJXb2h6RzdRWDVSQWl4cmtLTzRLV2ZCWmlrWXpGS3ZzbHla?=
 =?utf-8?B?NklPT0ptTnJKRWlJTVhHSnpSZFV1K2x0Snc4dDJ3c01icVBvck9Bckd2Qkx6?=
 =?utf-8?Q?bwz2hLaP+6gyZeDCZ16/pk1kal9gIkPayroElts0thc0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d49319c1-5b36-436b-ff55-08dabcbf890a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 10:46:45.2821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wos84bUjMosLAVG7sRUFJouZPYjyyF0cYSbLZBVSz+iowfnOxYXVDWt4DwwKgKTF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6330
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 01.11.22 um 22:40 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> The workaround was initially necessary due to dma_resv having only a
> single exclusive fence slot, yet whe don't necessarily know what order
> the gpu scheduler will schedule jobs.  Unfortunately this workaround
> also has the result of forcing implicit sync, even when userspace does
> not want it.
>
> However, since commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove
> dma_resv workaround") the workaround is no longer needed.  So remove
> it.  This effectively reverts commit f1b3f696a084 ("drm/msm: Don't
> break exclusive fence ordering")
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Oh, yes please. I had that on my todo list for after the initial patch 
had landed, but couldn't find the time to look into it once more.

There was another case with one of the other ARM drivers which could be 
cleaned up now, but I can't find it any more of hand.

Anyway this patch here is Acked-by: Christian König 
<christian.koenig@amd.com>.

Regards,
Christian.

> ---
>   drivers/gpu/drm/msm/msm_gem_submit.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
> index 5599d93ec0d2..cc48f73adadf 100644
> --- a/drivers/gpu/drm/msm/msm_gem_submit.c
> +++ b/drivers/gpu/drm/msm/msm_gem_submit.c
> @@ -334,8 +334,7 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit)
>   		if (ret)
>   			return ret;
>   
> -		/* exclusive fences must be ordered */
> -		if (no_implicit && !write)
> +		if (no_implicit)
>   			continue;
>   
>   		ret = drm_sched_job_add_implicit_dependencies(&submit->base,