Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3980680rwi; Wed, 2 Nov 2022 05:34:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7NKi2U/IuJXWxJgK804S7tBL7zHJK2vgcf5yWWhCcidRbPOMBWDRVvywpRFI2NYZH5kTdF X-Received: by 2002:a17:907:868c:b0:78d:f741:7fa7 with SMTP id qa12-20020a170907868c00b0078df7417fa7mr23876722ejc.648.1667392499157; Wed, 02 Nov 2022 05:34:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667392499; cv=none; d=google.com; s=arc-20160816; b=bLe3mno+kWcKnqSPxz5fy0tcMv/KUEPKx5ZzYEy+NE/kOHm87Ony4w+csbYuprBiyH 9DApmMll2pawKP6nqb3LAC93iDqh79sMyvcyO8xAfbysmWat9ZOPj5SayhgT1WNVxmx2 gCd2KyyQEtI977qlNoV9OxGsLFy1ZUGV2fImhxmec1vfbp81LDDqQwZ7O/7nsMwWbNKc ucC6T5YdF4p383EMpis22Ve7yiY85tDBnbiYnAl7prpXBGL9QVLE46HF7ypcVeswCZv/ x2rLeshzdX/xDVT2VoJOcK0KeLA2luCYEgKYMMlACDMF+VWDy/jHHun8HKJ7l8wuQyna FWLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=mhoRnGWblIJoUjOZOMP2K1bnpT6Df1eLBG65ig720ns=; b=z/XSJjBM79SqKc4gdPABdQZtJSj3bdtz2k80BrZ7ZvggTKFve3EohbwG/vN8SkUR8c 6Q0Jt1Hf/d9YTexltl0SfOM4L2uejqPL+pVpvxml0VUtCKwOxnCkCb9dxsqdHikwbKXq SyoZcBdYmQepsddAP9KfZJSRd1P9IWUzgte33kxduq7LOH9GLHO+NMCrFJp1RUWoHZ7k YvKUe0vW35k+hR1aIdbZA4+dcuCVi36Se7q5JWjTG6F8Dma0wi1zupwg5nfyXpAeYkz8 fiPOIhW6aVzmggiBwVIzeCiV+ob1N+3u3MtRkCGAERLOrjufr58qfYr94XFBY/S6MBWr Hc5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TFEcV7yY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr9-20020a1709073f8900b007ad88f87f07si18845893ejc.599.2022.11.02.05.34.36; Wed, 02 Nov 2022 05:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TFEcV7yY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbiKBMV5 (ORCPT + 98 others); Wed, 2 Nov 2022 08:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbiKBMV4 (ORCPT ); Wed, 2 Nov 2022 08:21:56 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077C129CB3; Wed, 2 Nov 2022 05:21:55 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9CD616602946; Wed, 2 Nov 2022 12:21:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667391714; bh=GWrRwN7bo6fjXnGPMvnQdgStYumrjcHBQAPPOaH9oHo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TFEcV7yYRYT7iW5wv1LhRrmo+Xj1fG3UlLNU1htU2Ve/t57kVotd9+jk1QcLJGJYv 21LoV00Gq5lKqyIfGkihnXbvJeetV2KzpagoJZy+0j2xVYVswmw4ZP11SVNSezlslk LO0tMXIilWpkTiDtfVRLaKghaC2ISJubVKOrE1v2CyEOd1ZrfsdNyZ8qgOvGRy2o6Y kOlRvh4rQk2CBpaudqPMhevdpq3GS5JOmr5+hF+mJlQqDQzSycp3sDqjOBhO8ta4ZU zNJOU0bRGMS1SpTirb6ZqP24Zvj7HNkvUhLwGtC9Tq5qTYoQ8E38m3lGhX/ONOlL8U kyZNE0W558Dnw== Message-ID: <4841b48c-c35c-a375-8e78-154bc5217930@collabora.com> Date: Wed, 2 Nov 2022 13:21:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] mtd: spi-nor: Fix the number of bytes for the dummy cycles Content-Language: en-US To: Allen-KH Cheng , Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Matthias Brugger , linux-mtd@lists.infradead.org Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Bayi Cheng References: <20221031124633.13189-1-allen-kh.cheng@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221031124633.13189-1-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 31/10/22 13:46, Allen-KH Cheng ha scritto: > The number of bytes used by spi_nor_spimem_check_readop() may be > incorrect for the dummy cycles. Since nor->read_dummy is not initialized > before spi_nor_spimem_adjust_hwcaps(). > > We use both mode and wait state clock cycles instead of nor->read_dummy. > > Fixes: 0e30f47232ab ("mtd: spi-nor: add support for DTR protocol") > Co-developed-by: Bayi Cheng > Signed-off-by: Bayi Cheng > Signed-off-by: Allen-KH Cheng > Tested-by: Dhruva Gole On MT8195 Tomato Chromebook: Tested-by: AngeloGioacchino Del Regno