Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Nov 2022 13:14:54 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado 
        <nfraprado@collabora.com>
Cc:     Rob Herring <robh@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, kernel@collabora.com,
        Masahiro Yamada <masahiroy@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] kbuild: Add DTB_FILES variable for dtbs_check
Message-ID: <20221102121454.tp4d5uhkxytibsya@mercury.elektranox.org>
References: <20221101220304.65715-1-nfraprado@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h3gksq3u5hwje4j3"
Content-Disposition: inline
In-Reply-To: <20221101220304.65715-1-nfraprado@collabora.com>
Precedence: bulk


--h3gksq3u5hwje4j3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi N=EDcolas,

On Tue, Nov 01, 2022 at 06:03:03PM -0400, N=EDcolas F. R. A. Prado wrote:
> Currently running dtbs_check compiles and runs the DT checker on all
> enabled devicetrees against all dt-bindings. This can take a long time,
> and is an unnecessary burden when just validating a new devicetree or
> changes in an existing one, with the dt-bindings unchanged.
>=20
> Similarly to DT_SCHEMA_FILES for dt_binding_check, add a DTB_FILES
> variable that can be passed to the dtbs_check make command to restrict
> which devicetrees are validated.
>=20
> Signed-off-by: N=EDcolas F. R. A. Prado <nfraprado@collabora.com>
>=20
> ---
> Usage example:
> make dtbs_check DTB_FILES=3D'arch/arm64/boot/dts/mediatek/mt8192-asurada-=
spherion-r0.dtb arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb'

Please add the usage example to the 'Running checks' section in
Documentation/devicetree/bindings/writing-schema.rst

-- Sebastian

>  scripts/Makefile.lib | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index ec391c6a2641..f3ac6d3632a2 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,16 @@ DT_CHECKER_FLAGS ?=3D $(if $(DT_SCHEMA_FILES),-l $(D=
T_SCHEMA_FILES),-m)
>  DT_BINDING_DIR :=3D Documentation/devicetree/bindings
>  DT_TMP_SCHEMA :=3D $(objtree)/$(DT_BINDING_DIR)/processed-schema.json
> =20
> +ifeq ($(DTB_FILES),)
>  quiet_cmd_dtb =3D	DTC_CHK $@
>        cmd_dtb =3D	$(cmd_dtc) ; $(DT_CHECKER) $(DT_CHECKER_FLAGS) -u $(sr=
ctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ || true
>  else
> +SHOULD_CHECK_DTB =3D $(filter $@,$(DTB_FILES))
> +
> +quiet_cmd_dtb =3D	$(if $(SHOULD_CHECK_DTB),DTC_CHK,DTC) $@
> +      cmd_dtb =3D	$(if $(SHOULD_CHECK_DTB), $(cmd_dtc) ; $(DT_CHECKER) $=
(DT_CHECKER_FLAGS) -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ |=
| true , $(cmd_dtc))
> +endif
> +else
>  quiet_cmd_dtb =3D $(quiet_cmd_dtc)
>        cmd_dtb =3D $(cmd_dtc)
>  endif
> --=20
> 2.38.1
>=20
>=20
> --=20
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.

--h3gksq3u5hwje4j3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmNiXzMACgkQ2O7X88g7
+povlA/1HlNx4+VVtcWgux/1wR8lONh+KWSe/IiEQNHWsJsv43ufnRHGxul4s+yB
UMxLElgqkz/xqhrSazbIyqq+CnFqjKFBcZ5eU8dg4Z3xXPNQlsWfoHdQVPo7Mm5u
kxWHyBZu5tqGnxWni2JLKahITdeWRSv8jV3N0dGpU1IPTUDiqjgK/f6tBzIstCrv
V+XIbr6YrP8GJWL+sfpIqZzsSb4S8ItlcjMZD739HsVXH0dvkVojVozxCfHNunSb
2GteZtZnwuPJeVzNpNrEH7yCkFVjjve0QAkTto2yZJG8KcRdd12rJ2ICRZeOe2eb
ardvm6sj4uxc+BJWVt7sC7lu6buQFiL/GXwYQo6ibCNnl8zzSQe5CwD04wUVgFDl
9RXl0P1wbmXq6MmNO2DtbZuCLHIIOCyGhdEC4k+L2/mGoMaqbcKPB8nwJkP71LoT
Ov73w8TWQPrfu/8RiBV/3BvYfAnel5+y39j3eoqSSaEE10XwqmzLxLw8EcQHHA7R
zACXJHzqfyeRScvqxCT34+NYAdQcQ9aiZLxdpYM2Y6C2rgXiU9QV7a+QihxfW5Sr
98zxNcj32y51hI4vf67AwAhiKn1Bp/2Mdqce2IuZ72/xW8fVTMdv9RMBgKnRG140
UQZI6+5SQHnzxxUt17+sIrvIp5KTCgyZqrF7nUJn7730PVLQMQ==
=/hNc
-----END PGP SIGNATURE-----

--h3gksq3u5hwje4j3--