Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Fail (protection.outlook.com: domain of arri.de does not
 designate 217.111.95.7 as permitted sender) receiver=protection.outlook.com;
 client-ip=217.111.95.7; helo=mta.arri.de;
From:   Christian Eggers <ceggers@arri.de>
To:     <olteanv@gmail.com>, <Arun.Ramadoss@microchip.com>
CC:     <andrew@lunn.ch>, <linux-kernel@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>, <vivien.didelot@gmail.com>,
        <linux@armlinux.org.uk>, <Tristram.Ha@microchip.com>,
        <f.fainelli@gmail.com>, <kuba@kernel.org>, <edumazet@google.com>,
        <pabeni@redhat.com>, <richardcochran@gmail.com>,
        <netdev@vger.kernel.org>, <Woojung.Huh@microchip.com>,
        <davem@davemloft.net>, <b.hutchman@gmail.com>
Subject: Re: [RFC Patch net-next 0/6] net: dsa: microchip: add gPTP support for LAN937x switch
Date:   Wed, 2 Nov 2022 14:12:25 +0100
Message-ID: <21674031.EfDdHjke4D@n95hx1g2>
Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
In-Reply-To: <cd9bed118823c23bb0080f904fab9371e4eb9a25.camel@microchip.com>
References: <d8459511785de2f6d503341ce5f87c6e6064d7b5.camel@microchip.com> <20221026214455.3n5f7eqp3duuie22@skbuf> <cd9bed118823c23bb0080f904fab9371e4eb9a25.camel@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 13:12:32.2876
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d7b0fd2-eea9-46f6-cea8-08dabcd3e6d9
X-MS-Exchange-CrossTenant-Id: e6a73a5a-614d-4c51-b3e3-53b660a9433a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e6a73a5a-614d-4c51-b3e3-53b660a9433a;Ip=[217.111.95.7];Helo=[mta.arri.de]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR02FT063.eop-EUR02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR07MB7198
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arun,

On Thursday, 27 October 2022, 17:51:54 CEST, Arun.Ramadoss@microchip.com wrote:
> I tried to bring up the KSZ9563 setup following are my observation
> - With this patch series, I am getting the Null pointer exception.
> - After applying the patch provided by you, switch probe is successful.
> 
> Usually I test the gPTP using the following command
> # ptp4l -f ~/ptp4l/gPTP.cfg -i lan1
> 
> How did you test this PTP in your setup, so that I can also get the
> same result as below.

as the KSZ9563 supports no 2-step time stamping, I use 1-step with E2E.
The problem with E2E is, that the "master/slave" filter
on the KSZ9563 filters out some message types.  In order to circumvent
this, I use the KSZ as slave_only for the first tests.  Later I would like
to use P2P, but this requires additional implementation in the driver. 

> > > Maybe this could be mentioned somewhere (e.g. extra line in file
> > > header of
> > > ksz_ptp.c). 
> 
> Sure, I will add it in the File Header in the next version.
thanks.

> 
> I thought 1PPS and periodic output are same, So I sent the 1PPS patch.
> I need to look into periodic output.
I fell the same when I first started with PTP... But maybe you can use
same code for periodic output from my original patches.

regards,
Christian