Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp4172513rwi; Wed, 2 Nov 2022 07:40:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM58qHP4WySVrTMZC3L5fBzECycEl54XUj/zioWuFakGFuDL1ckpHzk9Oe+0H4RW13Ri0vSb X-Received: by 2002:a17:90b:4b0e:b0:214:1328:e33a with SMTP id lx14-20020a17090b4b0e00b002141328e33amr8548166pjb.207.1667400016541; Wed, 02 Nov 2022 07:40:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667400016; cv=none; d=google.com; s=arc-20160816; b=pa26S6gKmvLePXwyBi61o48JytggmoEDyXi4q4CDz+OwoM5OUHYnsKc/dOXGHZTRE+ gCQz/m4J2KFEDJqSxFr3lbAmCuRF2m8txSSUDZy34zSi9YL9vQ/r/WeQn3vsnb0j3VuH ZhnYd6NdYeM1SKTs7GgvhS9QYcWk6MOfXIKjqnNHTeltmADqKiDCtKTXvaowRHY8N0J7 As0vZQ+233edVfinbG/zlavvI7wNdk4U9C2EVHNDuYNJayo47MnjxU3SyfKHoieTR9P6 8/QL4/HTSn+aiw0sTK6pWikhlLhP3Lklh6fEvgfmIB0T30DgV9e7WluC1vQR7y5LSNLK ZQQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WasSzIP/12UR+rs15S0DECR0JVdHDG91GJ276nwZGH4=; b=UN84MucLHB4z38CLBqePF6jCru/wHtFTMHXvqXXX0iu4XHKX747NmHgxC3kT/fucjm lX6xf2dP/U8nQ90cKW6JDqq9M3tC/SyizEwFXqItF4n3423K9qo/UJnyIhfyN++TheYj 6Lvlu/7IRZTu+THM1ik8cDvhEVFQp/RsF1ZnckF1fiIOIk+4H7vdHZhOhaxhgvzYBZeX TIyeVcn9X4LB5xLRZwHBLdIst0gs2dvVh355/8+m5Nbp+VZUh6f5ZWBk3WmOxD7+124M Y1sSjiZDiu/bT32TLWhUgkFANk8slG4Bc+Co3Nrwuksu+uLuuQ3iFPNC3x8G9e7PoU4v WMfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t11-20020a056a0021cb00b0056bc9b188c6si17217252pfj.245.2022.11.02.07.40.03; Wed, 02 Nov 2022 07:40:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbiKBOUa (ORCPT + 99 others); Wed, 2 Nov 2022 10:20:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbiKBOTy (ORCPT ); Wed, 2 Nov 2022 10:19:54 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB2C21F630; Wed, 2 Nov 2022 07:19:52 -0700 (PDT) Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A2DYXQq004588; Wed, 2 Nov 2022 10:19:51 -0400 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kka3dd94u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 10:19:50 -0400 Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 2A2EJn9B003554 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Nov 2022 10:19:49 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 2 Nov 2022 10:19:48 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 2 Nov 2022 10:19:48 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 2 Nov 2022 10:19:48 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A2EJWOr005631; Wed, 2 Nov 2022 10:19:42 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH 5/8] iio: imu: adis16400: Fix deadlock in probe Date: Wed, 2 Nov 2022 16:18:40 +0200 Message-ID: <20221102141843.122182-6-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221102141843.122182-1-ramona.bolboaca@analog.com> References: <20221102141843.122182-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: 0R3hhO91_kF4DArVTu_5AnNupHXBW1BA X-Proofpoint-ORIG-GUID: 0R3hhO91_kF4DArVTu_5AnNupHXBW1BA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_10,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020091 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use __adis_initial_startup instead of adis_initial_startup to avoid deadlock. When using adis_initial_startup mutex_lock is called twice, without releasing it (once inside adis_initial_startup and once inside adis_enable_irq). Fixes: 100bfa38c8cb ("iio: imu: adis[16480]: group RW into a single lock in adis_enable_irq()") Signed-off-by: Ramona Bolboaca --- drivers/iio/imu/adis16400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c index 17bb0c40a149..c02fc35dceb4 100644 --- a/drivers/iio/imu/adis16400.c +++ b/drivers/iio/imu/adis16400.c @@ -445,7 +445,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev) st->adis.spi->mode = SPI_MODE_3; spi_setup(st->adis.spi); - ret = adis_initial_startup(&st->adis); + ret = __adis_initial_startup(&st->adis); if (ret) return ret; -- 2.25.1