Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <630269a9-29a3-6b75-0a67-449ec36e7e5e@kernel.dk>
Date:   Wed, 2 Nov 2022 08:19:19 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v2] io_uring: fix two assignments in if conditions
Content-Language: en-US
To:     korantwork@gmail.com, asml.silence@gmail.com
Cc:     linux-kernel@vger.kernel.org, io-uring@vger.kernel.org,
        Xinghui Li <korantli@tencent.com>,
        kernel test robot <lkp@intel.com>
References: <20221102082503.32236-1-korantwork@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20221102082503.32236-1-korantwork@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/2/22 2:25 AM, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
> 
> Fixs two error:
> 
> "ERROR: do not use assignment in if condition
> 130: FILE: io_uring/net.c:130:
> +       if (!(issue_flags & IO_URING_F_UNLOCKED) &&
> 
> ERROR: do not use assignment in if condition
> 599: FILE: io_uring/poll.c:599:
> +       } else if (!(issue_flags & IO_URING_F_UNLOCKED) &&"
> reported by checkpatch.pl in net.c and poll.c .

I'm not super excited about this patch as the previous one
wasn't even compiled? Did you test this one, compile and runtime?

-- 
Jens Axboe