Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp4209260rwi; Wed, 2 Nov 2022 08:04:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7MdaS7rzo1SR7xnXJrkVPVQwSl1Y8HEi/vSMCDHJRyApZ4yQqaIedO1+MYgY5OL/+J0EF5 X-Received: by 2002:a17:90b:1b01:b0:213:ccc6:87ea with SMTP id nu1-20020a17090b1b0100b00213ccc687eamr20486055pjb.135.1667401479543; Wed, 02 Nov 2022 08:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667401479; cv=none; d=google.com; s=arc-20160816; b=E1lkD0ZxgdXzXTY5P2QmeNfuDM41DaqKzUYyLEXoDswWwlxbBBf+hp9/rEmE081zvL eHPH0QFK3CHzUebkpG7tCA/AYbbspEW1afseOqcli1fWA+g2k7MocNm2ufR+aepNQgYU zLOu+2f3ntLj6mblknumhADbB5WV1pgMpvkRmIqqsxV5LBjrmC7guP8ZEx3iNKrAYvyk 90LsCWT6xcy1cuGmgpG71Pl3D3OdL8E3A084/KJSd7sLUgjbolZ739H7+R2ue8hQhTGl +CjdFkgbTOBLkxxCJQLpYYFEQ01RTgX8vMtgrilWGiw/MBFI1bYMga50yMgWzfm6+dKK 4ymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7BADtk8IWu4Wqm/4xNMvjhcL38zUicWAjWyg3G9l0FQ=; b=jqNljUsqNGMLrwdl9fx3I5+zQ6YS8Ghg4JQWcKdojXAGTFW72bgvUw20A7t6JAypV1 yLHxOnrk7inyl5g0+jb1eFUMlGmCIpoMK5LICNI7raUfawfoDrTZT4H97fwA9CjrxZGv iSSiS+moc20IHwdI7eNzfuTDdEn91n9D8xjUAEdH6Hexz33v8bmHbN9lXULRj0XUEVsJ tNaMWQOvZbPko7sdau5AoCWCQFbznc9GpgCdXAao2oQP9zsbpgCw5lQPJm8A2s0Natmq j4lEiyiyjfOwAk1qumD3btAUbSPlDbgVMJaQH208Ic8pn7dz4KfeWonSowFqbXRU44tL YB+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d8-20020a634f08000000b0046b2ea05986si4252496pgb.63.2022.11.02.08.04.12; Wed, 02 Nov 2022 08:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231663AbiKBOUe (ORCPT + 98 others); Wed, 2 Nov 2022 10:20:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbiKBOTz (ORCPT ); Wed, 2 Nov 2022 10:19:55 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9F321F617; Wed, 2 Nov 2022 07:19:53 -0700 (PDT) Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A2DpfnA007869; Wed, 2 Nov 2022 10:19:52 -0400 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kjn9tuspg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 10:19:52 -0400 Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 2A2EJoSE003558 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Nov 2022 10:19:50 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 2 Nov 2022 10:19:49 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 2 Nov 2022 10:19:49 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 2 Nov 2022 10:19:48 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A2EJWOt005631; Wed, 2 Nov 2022 10:19:45 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH 7/8] staging: iio: accel: adis16240: Fix deadlock in probe Date: Wed, 2 Nov 2022 16:18:42 +0200 Message-ID: <20221102141843.122182-8-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221102141843.122182-1-ramona.bolboaca@analog.com> References: <20221102141843.122182-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: OS8EeTGf_yWkPz6UugKmpXVZ90SOxuSo X-Proofpoint-ORIG-GUID: OS8EeTGf_yWkPz6UugKmpXVZ90SOxuSo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_10,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020091 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use __adis_initial_startup instead of adis_initial_startup to avoid deadlock. When using adis_initial_startup mutex_lock is called twice, without releasing it (once inside adis_initial_startup and once inside adis_enable_irq). Fixes: 100bfa38c8cb ("iio: imu: adis[16480]: group RW into a single lock in adis_enable_irq()") Signed-off-by: Ramona Bolboaca --- drivers/staging/iio/accel/adis16240.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index bca857eef92e..337492785f04 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -414,7 +414,7 @@ static int adis16240_probe(struct spi_device *spi) return ret; /* Get the device into a sane initial state */ - ret = adis_initial_startup(st); + ret = __adis_initial_startup(st); if (ret) return ret; -- 2.25.1