Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06ef6e4b-1f42-d50f-1328-4f82fb34dd4d@oracle.com>
Date:   Wed, 2 Nov 2022 09:55:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20221031193604.28779-1-eric.devolder@oracle.com>
 <20221031193604.28779-8-eric.devolder@oracle.com> <Y2A4TqyOaPYBu4Hk@zn.tnic>
 <1c11a429-b5a9-fb55-fbef-b49e760e2d1e@oracle.com> <Y2I3zQ9ZU+C9Kgf7@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y2I3zQ9ZU+C9Kgf7@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dncrQm9sc2pLVXNuMHIwMjI5NjJ6NUZRdVBwMVhVSEVwVmtHam1mVDF5cE9q?=
 =?utf-8?B?dHl4N21RVzU2V1MvVWtJd3lvQzdZOUpjV3Y0WTZKcU43QXdlQzZZMmxSMVEv?=
 =?utf-8?B?cWVsOFpIK3ZCNUJ2M1NqZXVKRUh0em5MNTZGR3YvMXcwRDBHTzhyYUQ2TXcz?=
 =?utf-8?B?SWVwL2R5Nll0bHJob3FmaVBPTG5UbnVraVgrM3ZYQ2pGemQ4VFFEU0ZOOHFr?=
 =?utf-8?B?Y25RQ3J0enl0enoxeUtPZDJqTitkTjFPdk5SRlVCTnlBNkJrcytqaVZDYXlm?=
 =?utf-8?B?SnNmZnBmMXFLUTFucytpZ1dzY3lWOGZSWlAvTlFuZ00waGZIWCtpK1p6SWp5?=
 =?utf-8?B?bDdveExrRVhSSUduUGRIYitWaHFaeVR4MXdzcUNZWU1BL3Y5ZEJBOVo1RU5j?=
 =?utf-8?B?WXYrY0cvNE9wWk5xNEJLSFB5LzVuWENkQVlzVEtWTnJhMnFXMlIxWm5lQjJD?=
 =?utf-8?B?a0VRcmw5c01oTDVWSXNLUEFlM3djejZDdmpjOWZCWGZnUTFEbXFITWtBOU5m?=
 =?utf-8?B?bE41ZWE1OVk4SHhJRWN6dks0WWZiTS83S1V2eHRTYWNZUUJaRGcrbGxzTXVC?=
 =?utf-8?B?a0trMWhUdzZSbDJjZnRRVmsxcVR2eG1uVko4VXNvRXNJSGh5ZkgrL3IrNEZK?=
 =?utf-8?B?dVRXaFBCUm11N08wWjNRK3ZsdFpXS1lsWjE3ZTlyL3lDTm03L0JwYUlRVXIw?=
 =?utf-8?B?VzhkMy9qMDBRRGV2MHgvaHQzc1RYbXBUOE9WVU9KbHg4Z3ZHK0VJcVliKzNG?=
 =?utf-8?B?cXJ3QnZnTk52NHRWRjJTRTZRQ0xaWnNzdVpSbk5ITjVRKzJGODM2amRoeGI3?=
 =?utf-8?B?YWErTSt1WUtTQVliSFpZSXN1L1M3RSsxd0cyN0d2aWN2RUFGK1EzU2xxNHdt?=
 =?utf-8?B?eTZvZ05YMFpGdi9wWlJQMVArS0hpbmR3ZHNjREIrVlZFNWRybXJnRGYzNkF1?=
 =?utf-8?B?cm5NSFB2RkpBSTVtdDJLQnNZeWJMU0k3Z253SWtTeTk1SGZBRHNCcGl2WE1m?=
 =?utf-8?B?QnBMeG9mMWwzUFBoTW42dlBqd1BnM1lucDVtQ3FGalNsV0JiNVRTYnEwWDlk?=
 =?utf-8?B?M3hRdUxoazg2ZEc2QithTDBJb3dWT0k3b3FpRTBpZ2JHR0djUnIzY21hQ2h0?=
 =?utf-8?B?cDh6K0xLQTdzSEhDaWtFc1dpaCt6RFE0eHpUTW92S0ZuY002STZtZ0doQkpF?=
 =?utf-8?B?ZWpiY0k1S2p6U3VVblNBTS9KSFFTYTFZWkJzd0VoSDVjNFJUSnhWeU5FQjN0?=
 =?utf-8?B?SnJ2a3d2M0UweXBjMGtZeXpaZDdqRU9vZ2kwRkVYQ2UrclpldWozUFVkQldo?=
 =?utf-8?B?ZXI2RWtSNnZEV2ppcUJpcGdnK2VtaDlHek4yemI3empnMEZGaUdFc2tLTlND?=
 =?utf-8?B?N05zWXJLT2E1eTBHMTlwYzg4dDBxZXFZRmVMeEJjWXh0dVhjVXZVRmd5SktM?=
 =?utf-8?B?Q2xxUFdXVHdOWDFZVlRnUHhGYVBvSkhCYTZYM2xXVXpLb0V2Z2JSZ3hrWXJw?=
 =?utf-8?B?OXdKTnRyQ1ZJRjQwMFQ5WmNkVUQwNVRBSnNjMGJ4ckx6d2h4VWhBbytkWUJ0?=
 =?utf-8?B?bElXeUhXZ0J5OHY4Q0UrRzRCT20wOWxKLzIrUXdvWEdjM2k5M1FUVlNXaFRK?=
 =?utf-8?B?WW1SaVdNNnFvVHFRUWk3YTlJWWJ2ZC9LVVR4ZU0xK0twK1ZxMlJlb3JUYkE4?=
 =?utf-8?B?ZGpxdldjQWpXMjBUK1cwMmhURUFNTUcxSkVsNUxJMnBmUjl3MUpKYTVUWDg5?=
 =?utf-8?B?R0w3bkRadXZuM01ZZjRsMytKOFdXbkxydlJRUmtveXFML0pwWWZEWVpzN2ZH?=
 =?utf-8?B?U2FUczhXMkdMUnpOK1EwYmhCL3NTaTB4VytsQlZhTkZXU0dNaGx3Ym5JMVdu?=
 =?utf-8?B?YktkbEdPWVFuYkI2UmNZVENpZ1h3SzRSM0xnZ1E3eFV6dHgwNjlHSmVWczg5?=
 =?utf-8?B?SmtDZzh6dTV1MlR1T3RWcmJPUjhFTjJvejJuc3ZTc0VER1oxeFpVd2NyOE10?=
 =?utf-8?B?QVc1V0dzOS8yc3dkcmJJS3NSaytOTnloU2kyZGkzNGlwUngvYzgrOXRHU1Vw?=
 =?utf-8?B?aXdud28wcGdpZ0RCNWlZckJreS9PL0NZcGJWdUwwZForL0NXdkE2d0xyODk3?=
 =?utf-8?B?cGIvSzJFVzU2SFFycDZXZExOenVnYkpKSXVJODdJRDdZZHFrUXZucGNDMHEv?=
 =?utf-8?Q?lrE2kunzWEGRwe+qbGICvEE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac3e3679-4bb7-41f4-f86d-08dabce23eca
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 14:55:13.1435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EdRk5aYgvL7srGeLArulfUOBcKJ3K+qSgCSzZaGHJXD7VHyCxAJlvFoQwkm56Fvxcfv/gf3dWAn6NmpvDROAhUE2I7FX/95GY1cR5laCZyM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5674
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-02_11,2022-11-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=998
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211020096
X-Proofpoint-GUID: N7HoZRW77eQ20m9XQhfmInE46SpFu0Y1
X-Proofpoint-ORIG-GUID: N7HoZRW77eQ20m9XQhfmInE46SpFu0Y1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/2/22 04:26, Borislav Petkov wrote:
> On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote:
>> As I'm re-reading that message, I suspect now the preference is to just to
>> strike this ifdiffery line in this file and have the code always present?
>>
>> If the preference is actually for CRASH_HOTPLUG, then let me know.
> 
> Well, it is this part:
> 
> "But on a plain simple laptop or workstation which has CPU hotplug,
> would it make sense for the crash ranges to get updated too when CPUs
> are offlined?

Yes, it does.

> 
> If so, I think you want this code present there too, without a Kconfig
> item."

Ah, ok.

> 
> IOW, if this thing doesn't make sense to have on the majority of
> machines out there - and memory hotplug machines are not the majority -
> then it should be behind a Kconfig item which is default off and gets
> enabled only when the user selects crash and memory hotplug...
> 
> I'd say.
> 

Ok, I'll will remove the ifdef line/pair.

Thanks!
eric