Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp4232331rwi; Wed, 2 Nov 2022 08:17:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ajzyvLGF0Gfl/5LDgDdvW5OHrZ31NoYQK0g7S2owJ+8aBlHJtid8obdgPjfmMKDllqWDP X-Received: by 2002:a17:902:ce08:b0:179:ed2b:8cd8 with SMTP id k8-20020a170902ce0800b00179ed2b8cd8mr25302355plg.23.1667402238096; Wed, 02 Nov 2022 08:17:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667402238; cv=none; d=google.com; s=arc-20160816; b=ojJiQCfiZFEilE15mlF2OrxHWUulOxWFw/e9Pw7qg1pWi2ncryoq1lOy6brpOurdXf dMteEfk2KpJVTV5wHPzToNJRdksc2K8Ei0jOv4k7GYlrUeyXSs9YCMB9tOPhjwowd48v xFi/DFKh+h1Ge3NOygKYNGY8XnILDNIypgor0z1z9Oyxxgle2zUKg8O9Tqmw/D0BAEVi ExBj2ZeMCHFJtZix+8lN+veHOobmyxBGJioqNtMGbWXoAIxVPq8yCczEIit/bDwA467A 3JaOnNXvj3ub2DiYO9A5JGBQWwu0jPTVLflcWWNXVFS5vBHjQfqEbNJNb03dTptHVu5n iCQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UoSVI7WsgdjlEM9CwiDG8T1QzhhbRONUQMkF8wH4bss=; b=cX8JpT/wRY/Qn+6DAilWCcVh+e0QHricUo/KjbctfMIJRJrZhwyiaaWQD7Jrbny3aO bjoeZsyOfS4avK2PmmdBXWwUKYnZa8CIMm7Y9F3eCNRk1j2KPTaNZjqpA0PMeTKd9/6/ VQ74Nct1rrPkazfUQsWpU0GYonFwhBbNL3DzZDhk8uT84+rggKdIIhMmDG9di3L8Q3q5 XZFd6avJ3/q8g9Dnq0B3SxUBQw90OdrdmBccXhBc7cnCRfZmR884r9uI46keOP1JU33X ef7Px2wPjbVF+gZVFMrHQzbc32bB11F/DtMDqLfHbmSuFAAfJ8FyFmwnzjTCrLPOSd3x 4Krg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a635201000000b0046ace26186esi15099789pgb.117.2022.11.02.08.17.05; Wed, 02 Nov 2022 08:17:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbiKBOUO (ORCPT + 98 others); Wed, 2 Nov 2022 10:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231553AbiKBOTw (ORCPT ); Wed, 2 Nov 2022 10:19:52 -0400 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD05E2019F; Wed, 2 Nov 2022 07:19:48 -0700 (PDT) Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A2DgGQe004512; Wed, 2 Nov 2022 10:19:47 -0400 Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3kka3dd940-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 10:19:46 -0400 Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 2A2EJjdN017354 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Nov 2022 10:19:45 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 2 Nov 2022 10:19:44 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Wed, 2 Nov 2022 10:19:44 -0400 Received: from rbolboac.ad.analog.com ([10.48.65.139]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 2A2EJWOq005631; Wed, 2 Nov 2022 10:19:41 -0400 From: Ramona Bolboaca To: , , CC: Ramona Bolboaca Subject: [PATCH 4/8] iio: gyro: adis16260: Fix deadlock in probe Date: Wed, 2 Nov 2022 16:18:39 +0200 Message-ID: <20221102141843.122182-5-ramona.bolboaca@analog.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221102141843.122182-1-ramona.bolboaca@analog.com> References: <20221102141843.122182-1-ramona.bolboaca@analog.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: wyVo7GSA9yEM1H-d9294kZB9yAa2KiT- X-Proofpoint-ORIG-GUID: wyVo7GSA9yEM1H-d9294kZB9yAa2KiT- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_10,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020091 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use __adis_initial_startup instead of adis_initial_startup to avoid deadlock. When using adis_initial_startup mutex_lock is called twice, without releasing it (once inside adis_initial_startup and once inside adis_enable_irq). Fixes: 100bfa38c8cb ("iio: imu: adis[16480]: group RW into a single lock in adis_enable_irq()") Signed-off-by: Ramona Bolboaca --- drivers/iio/gyro/adis16260.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/adis16260.c b/drivers/iio/gyro/adis16260.c index eaf57bd339ed..112d635b7dfd 100644 --- a/drivers/iio/gyro/adis16260.c +++ b/drivers/iio/gyro/adis16260.c @@ -395,7 +395,7 @@ static int adis16260_probe(struct spi_device *spi) return ret; /* Get the device into a sane initial state */ - ret = adis_initial_startup(&adis16260->adis); + ret = __adis_initial_startup(&adis16260->adis); if (ret) return ret; -- 2.25.1