Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp4252875rwi; Wed, 2 Nov 2022 08:30:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5D6aZJHJadmz4UCaG5fnNLfFTG0l1lUEI7YCnbrNyL9Bn0w0cTB9bPI32zsxfGjRLKFyyz X-Received: by 2002:a62:1d52:0:b0:56c:2c:8124 with SMTP id d79-20020a621d52000000b0056c002c8124mr25231552pfd.24.1667403010369; Wed, 02 Nov 2022 08:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667403010; cv=none; d=google.com; s=arc-20160816; b=yYxiJjTAWSbvtDzCP23ZsrEQKDciJrBYwfU8hiHiyEAQsXoSdMrQGcu+Y8SfUk4L5M VHXZstw/ZoZKFyjCdjwSh6RJhi8o8VnjN21OlKb9CrjkPJE3JtO/1G0yhvHEcb82Iiyk cX75SmqVBseMpME96RJrVK9yqJDFfmqhsAlncJShqcFqqSZWViPwIUMZyK7YZRlf1bsT rEdy9OBIQb8DsYNC9FD1uSeAoYvLVMGuDCIAUkOX5nlCsYYjPtOCnWweHpLu+gA+DSTj q8zxpJL8k3vi+P0c7loFQ8LxC+sNGDtyMfYeOyez/m6a95Qs57rcPeMHkzz9xJ56iWgx D5Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=pn4Onsc7GZIXH8zAj7BbT2KcypGggk8396m6IL8/CLY=; b=xCp9FFCN3j3sN1WL5RbnI6JmjfRiBB3kPRXZ7NsM2/jSE+njdJ/J0+1+68ahot7cY3 a00RJfdg/xKnei9mEmPkcc/IAVa8L63Mh3S0XFIjkCFjsSa8wNOxMwTZZ24D0kEV4lGv LYjrBM+Zweup4/XqUPrbnPnrNF+qjeaHnS7lV9eM7i08jYpgNGox7dpEargJLtcd2fxc F4M+DcHelKM/3ba1RlKmX421sUX+MZbfH43jIn4IGUd7c1eDjdKslmxzgmhbsMHnbhNa S2OfVEKZ2j+fPaeZNVKVnjj5lfojRkfZ6wyzTAGW9XQTkPqYp4KRdNr4PKhPOXskp42Y 7pJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l9vTpgH+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l15-20020a056a00140f00b00565eb80af7fsi17694771pfu.343.2022.11.02.08.29.56; Wed, 02 Nov 2022 08:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l9vTpgH+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231511AbiKBOcK (ORCPT + 98 others); Wed, 2 Nov 2022 10:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231683AbiKBObw (ORCPT ); Wed, 2 Nov 2022 10:31:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CCAE2A709; Wed, 2 Nov 2022 07:31:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6AF8619C5; Wed, 2 Nov 2022 14:31:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2773CC433D7; Wed, 2 Nov 2022 14:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667399510; bh=pn4Onsc7GZIXH8zAj7BbT2KcypGggk8396m6IL8/CLY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=l9vTpgH+Bm5HpFsamvgWpvMdEi6LuNCfd/+08VDvSnxjbQ8mGuQfh13mWTwmbsltM ukUPe15dcsVQ2rUPoq4lMPgGAqHzhKcA48HgJix0GFXCwwRExW3yCkCXJ/yn8dXOWc R8794EQozOzZKnh244x7s8JxuvIHQX2eVrkzH1sJqx9w7BiG939oDcefd2JlRGL5g7 FbZX47wisMNzYtrZ1S8uRMsKS9oVWTJfLCxkYZPIjDR4MRGpS60BtU9Cux3Hpr2TYF Ys4NMtt0yYZGCSEljh4NZKZF5S79FkZokITLBH7FvbvauCdu0ggcwQuzfSJJZCLXXN 9XWN6QO/W4iBQ== Received: by mail-lf1-f46.google.com with SMTP id b3so3390674lfv.2; Wed, 02 Nov 2022 07:31:50 -0700 (PDT) X-Gm-Message-State: ACrzQf0CyqGMOWiQg0xglSvu9aB/ru9v2dcg+lAcqy9cgA2axKFo1fwW r2vT7Lmr4VQ6TIPCb3tOM5uOHDT8sp3CYFLYkA== X-Received: by 2002:ac2:4c03:0:b0:4a2:2273:89c6 with SMTP id t3-20020ac24c03000000b004a2227389c6mr8745771lfq.245.1667399508109; Wed, 02 Nov 2022 07:31:48 -0700 (PDT) MIME-Version: 1.0 References: <20221031091918.531607-1-pierre.gondois@arm.com> <3c54db0a-44fe-ee24-1833-7637e249ec79@arm.com> In-Reply-To: From: Rob Herring Date: Wed, 2 Nov 2022 09:31:39 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/20] arm64: dts: Update cache properties for amlogic To: Martin Blumenstingl Cc: Pierre Gondois , neil.armstrong@linaro.org, linux-kernel@vger.kernel.org, Rob.Herring@arm.com, Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 31, 2022 at 5:19 PM Rob Herring wrote: > > On Mon, Oct 31, 2022 at 4:09 PM Martin Blumenstingl > wrote: > > > > Hi Pierre, > > > > On Mon, Oct 31, 2022 at 2:33 PM Pierre Gondois wrote: > > [...] > > > To avoid cc-ing people to DTs they are not related, the get_maintainers.pl > > > script was run on each patch individually. The cover-letter is at: > > > https://lore.kernel.org/all/20221031091848.530938-1-pierre.gondois@arm.com/ > > I think Neil's question is the same as mine: is there a dt-bindings > > (yaml schema) change for this as well? The idea is to alert people (or > > let bots alert people) in future when adding a cache to a .dts{,i} > > where the cache-level property is missing. > > There's not one, but it's something to look at adding. I'm not sure > how we'd check for missing 'unified-cache' which is a common problem. > The challenge here is a lot of what needs to be checked is based on > the overall structure. This probably is better checked in dtc which is > better suited to do cross node checks. Now there is an improved binding: https://github.com/robherring/dt-schema/tree/cache-rework With that schema and this series applied, I get the following errors: arch/arm64/boot/dts/socionext/uniphier-ld11-global.dtb: l2-cache: 'cache-level' is a required property arch/arm64/boot/dts/mediatek/mt8186-evb.dtb: l2-cache0: 'cache-level' is a required property arch/arm64/boot/dts/mediatek/mt8186-evb.dtb: l2-cache1: 'cache-level' is a required property arch/arm64/boot/dts/mediatek/mt8186-evb.dtb: l3-cache: 'cache-level' is a required property arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: l2-cache0: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld11-ref.dtb: l2-cache: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dtb: l2-cache0: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dtb: l2-cache1: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-global.dtb: l2-cache0: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-global.dtb: l2-cache1: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dtb: l2-cache0: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dtb: l2-cache1: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget0.dtb: l2-cache: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dtb: l2-cache: 'cache-level' is a required property arch/arm64/boot/dts/socionext/uniphier-pxs3-ref-gadget1.dtb: l2-cache: 'cache-level' is a required property Cases missing 'cache-unified': arch/arm64/boot/dts/amazon/alpine-v3-evp.dtb arch/arm64/boot/dts/arm/corstone1000-fvp.dtb arch/arm64/boot/dts/arm/corstone1000-mps3.dtb arch/arm64/boot/dts/arm/juno.dtb arch/arm64/boot/dts/arm/juno-r1.dtb arch/arm64/boot/dts/arm/juno-r1-scmi.dtb arch/arm64/boot/dts/arm/juno-r2.dtb arch/arm64/boot/dts/arm/juno-r2-scmi.dtb arch/arm64/boot/dts/arm/juno-scmi.dtb arch/arm64/boot/dts/broadcom/bcm2711-rpi-400.dtb arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb arch/arm64/boot/dts/broadcom/bcm2711-rpi-cm4-io.dtb arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-a-plus.dtb arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb arch/arm64/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dtb arch/arm64/boot/dts/broadcom/bcm2837-rpi-zero-2-w.dtb arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb arch/arm64/boot/dts/exynos/exynos5433-tm2e.dtb arch/arm64/boot/dts/exynos/exynos7-espresso.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3-rev-a.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dtb arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dtb arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dtb arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2.dtb arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dtb arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dtb arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mn-evk.dtb arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb arch/arm64/boot/dts/freescale/imx8qm-mek.dtb arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtb arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb arch/arm64/boot/dts/marvell/armada-7040-db.dtb arch/arm64/boot/dts/marvell/armada-7040-mochabin.dtb arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dtb arch/arm64/boot/dts/marvell/armada-8040-db.dtb arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dtb arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dtb arch/arm64/boot/dts/marvell/cn9130-crb-A.dtb arch/arm64/boot/dts/marvell/cn9130-crb-B.dtb arch/arm64/boot/dts/marvell/cn9130-db-B.dtb arch/arm64/boot/dts/marvell/cn9130-db.dtb arch/arm64/boot/dts/marvell/cn9131-db-B.dtb arch/arm64/boot/dts/marvell/cn9131-db.dtb arch/arm64/boot/dts/marvell/cn9132-db-B.dtb arch/arm64/boot/dts/marvell/cn9132-db.dtb arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dtb arch/arm64/boot/dts/nvidia/tegra194-p3509-0000+p3668-0000.dtb arch/arm64/boot/dts/nvidia/tegra194-p3509-0000+p3668-0001.dtb arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dtb arch/arm64/boot/dts/tesla/fsd-evb.dtb arch/arm64/boot/dts/ti/k3-am625-sk.dtb arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb arch/arm64/boot/dts/ti/k3-am642-sk.dtb arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb arch/arm64/boot/dts/ti/k3-am654-base-board.dtb arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-sk.dtb arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb Rob