Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Nov 2022 11:19:17 -0500
From:   Han Xu <han.xu@nxp.com>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Haibo Chen <haibo.chen@nxp.com>,
        Yogesh Gaur <yogeshgaur.83@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static
Message-ID: <20221102161857.7t7dqipgfsh2cgtf@umbrella>
References: <20221102152904.143423-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221102152904.143423-1-colin.i.king@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?20KI3I+O4DWF73d4U3ktJICW+2vunuTzQT44bJJiblrJ2azaiD/tmwXuPcuI?=
 =?us-ascii?Q?7tFNkNZbu9zmNKHeEGj2q5LNnZaD47BrtmcMfYQImZfiBT+JicDLXNq2DkZv?=
 =?us-ascii?Q?ycbvI7EOiLBDs1b/MtQj48zQkl1jxYIr9lr61Dxb+noFdWK7TNGLpb9Li8xe?=
 =?us-ascii?Q?U5fBhP5SmPmof5nJZILrL06eYkExdWoRjHem3QV+ZaSWj23Ml3pIGlvx3okx?=
 =?us-ascii?Q?mGR+v4rQ4tyS8OfHClsSlfGCKBNK9oNmUZK67+qoI9pRzvHUj6XagpziCGBZ?=
 =?us-ascii?Q?h8bowl8b8QPyU2g09l/i1C4BxeI76CB6hc5BhXbL4V+Btjz7p/fGEuDZQSp0?=
 =?us-ascii?Q?3Qtid0FFT3rpePyRNQJ1KRW6pM8sIPbipBXluYlZwJd2aty8ADyOqNfY3/Oz?=
 =?us-ascii?Q?Mgz/2DpqUlzj2TCKNfYKXZ/z82B3tV5kBVIfS9YRQ3ZSvapQDTyYtBFVLS0s?=
 =?us-ascii?Q?pYL8Q1S2yzGjoy2VVQWHtNthiZpBm+x0gltw6Q75vFioKqzyT2Q+6v/aR2yh?=
 =?us-ascii?Q?sNpT26RwjWgGr5rG69uBEDxMB/TkdEY452pf6t2GIkD2xHiHmoDwVirxdrXR?=
 =?us-ascii?Q?+Tje3x8BniBP/EU/JGHXUYTrs6Zg+EwZKhOY2RQeuspX1Wl4z3S/WekuE/3U?=
 =?us-ascii?Q?m3onVJz5osQ+W5RR7fH6KBECeUWJlsTH324qWomRe4TlqBbwf2Rw3VLmbcS/?=
 =?us-ascii?Q?2I2SmgaVTs6JbNHsuKXg5C4HvXcS1sfplZcKCblP20xvljjsEagd8Vb0R2o+?=
 =?us-ascii?Q?eSfLM83koN94ZDftFdyJw9cIbDNCFCnHfi9xI7rZhyEHqvJM+hg7NvcE/DI/?=
 =?us-ascii?Q?0wUEx5kDUmPr6O7barCV6bZq6vpdMejtTBVi/10ivETIhxhUBRJd81uA6aF3?=
 =?us-ascii?Q?WThxIpvqp7NfHdpPWnbAQX82KSsFZiKnoL/KsDmNdYiF8TOWkMELY1Wdf3/n?=
 =?us-ascii?Q?C1+80SCCaqX0jYqUAIniTZc1bRr1Oc8q+JKwTppZrssoVGKHClusOjbn7lEw?=
 =?us-ascii?Q?lU0FEs+p4kIEZAiez/q9Rd757mQ2i+WsHR/DevkIzUOAS6edxGaBWNOa0izz?=
 =?us-ascii?Q?AYwh2kocdnd8SsvF6vMBao3sD9JpK+uM93IYeq0xiDXfqt1o1ZYsLRGipegs?=
 =?us-ascii?Q?IIPrAZshyg36cZoJUFX88g7hLZoAA8r6JE8DCHNLtu5aP9KYLbI3u1CETaEh?=
 =?us-ascii?Q?/0XYWkbSboNYFhT44B+W7u1hms7FKBQuTIJRc3hii5g17iSnjvSevXAfSqyf?=
 =?us-ascii?Q?qiOIznKF424Wyq9thrL/LBWlScoNfFEslbkEFeKSUqRrTEIQSXfpo88fOQhy?=
 =?us-ascii?Q?vyWBW9qMTEvF3grsOd7ehTwd6uqCk8z76KJ6I0AT2RboW/NbXm5apjYBaDqt?=
 =?us-ascii?Q?5AfXTTuNpyv3vM57Gu/c5w21NBZQPMhx/EKuGDkB9sCFVOkhCLiQRoBmX8dh?=
 =?us-ascii?Q?IVJpP1dQZBYur2LOarxCWRsDLYejabK1jvdRu111z69pGdUY+/XaHlsl7JjC?=
 =?us-ascii?Q?rdma7NqfadfQqPHUf/PwrLP+koTa7KQMbdXEzwPpxDJUju1KmbD8Ewbo1J//?=
 =?us-ascii?Q?B0LPmCQnOS4MPT8Lapw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89bbbb68-8ca2-4462-905a-08dabcee0216
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9071.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 16:19:25.1336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YwoeijSQ5LYercJXgRdTFw/8Mn/EkD3M6yF5z8z71jEYxpHyvbdWEKJuIX+IQvkR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8257
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/11/02 03:29PM, Colin Ian King wrote:
> Don't populate the const array ls1028a_soc_attr on the stack, instead
> make it static. Also makes the object code smaller.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/spi/spi-nxp-fspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index d6a65a989ef8..1c1991a26c15 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -924,7 +924,7 @@ static int nxp_fspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
>  
>  static void erratum_err050568(struct nxp_fspi *f)
>  {
> -	const struct soc_device_attribute ls1028a_soc_attr[] = {
> +	static const struct soc_device_attribute ls1028a_soc_attr[] = {
>  		{ .family = "QorIQ LS1028A" },
>  		{ /* sentinel */ }
>  	};

Acked-by: Han Xu <han.xu@nxp.com>

> -- 
> 2.37.3
>