Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp139955rwi; Wed, 2 Nov 2022 10:10:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ZunesTyM44gKOm0VlLP04dtdoaGmXGaGTzd6qymuwvbz1W9CuVAFRuCBhg9oUJarVs64L X-Received: by 2002:a17:902:7294:b0:187:146c:316f with SMTP id d20-20020a170902729400b00187146c316fmr20116935pll.149.1667409045726; Wed, 02 Nov 2022 10:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667409045; cv=none; d=google.com; s=arc-20160816; b=VRzM1CSX+mQbV8Q/5o09he9OZ/rzDjU67wwPA2K+1iGs6nSxQnXnYLDeLj7NbghghR QO8U3qK0aW2bdxP2e4BD644Q1UtBfLDG9tbCgxGgOLy4BrYZHo6H4wl8ZCRqyshXk39x LJ42pjVeyxCC9t/NzeFN6X0lxhTPm5cndut0Ysa8tSF33val6fi806J3cflilApRVmVY gw/JVFpF2kSC8leb1IbaJo5BBmlE2e9SaAPCJ6FqR5OpLg/pUdWB2e3/JjTruu/TIwc8 BWRmgW3Viouti/QFbgXdy/+98Io6J7EcXYNBkyOxQJwnUujv622gbfevMpdiRYUbZ92N VruA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=lmabQ6QIrPhC6gHbbbnIOeOPPxHLqb9/uiOG+55mjHA=; b=eBzLRfKBqb04mBB8BJwGNkVbu/PhMCx+faYuKbwNv2E6O59oCKIqlwOa/j7k2+eL23 aV7V9nD7oJUaXdcV/YHTCkXb01HlZi8ITLKRnNrkALFuEURpr69il8ExZa0zEKECiQkm bU6htRql3r32YCQHME/v1FuVUunUxmoIq2D7JW/EHOqX7a/MKYm32uet2UvoxkU7cAHI dMJ9/iTAPP+o7lISXFeUyiC9kzAFF6IhQExmE9MalG0yH6QT+auTG2nH9zSrQOiR3SrP CXFAbtheJtNVqLvhNUepIg9s01Uovh6G5bV0l69lUqZWJ6ANYJ9d1uRK6jF6WzAHBq3k Jw1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EHXyQjGj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a1709026a8200b0018694b85992si14829687plk.389.2022.11.02.10.10.26; Wed, 02 Nov 2022 10:10:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EHXyQjGj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbiKBQpa (ORCPT + 98 others); Wed, 2 Nov 2022 12:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbiKBQoq (ORCPT ); Wed, 2 Nov 2022 12:44:46 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDCA5FBC; Wed, 2 Nov 2022 09:41:08 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id b9so10793050ljr.5; Wed, 02 Nov 2022 09:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lmabQ6QIrPhC6gHbbbnIOeOPPxHLqb9/uiOG+55mjHA=; b=EHXyQjGjv+nNN+CsohFOura4RO576Rjv0DVdD2nvgit2YYAI9ZuXI30zP8hsJMsetM P+KFkGBH7LdzTUn16idjtEATjLbO3ah88mFwF2yeRSmI7Vx877Ixlp/UxXB7vFNmNitw I90PzzpQF+JADtng9we9CUcvh8PI4eJtVMAhUGliOPARXfEkpGysY/UXKJtH4YPkVBlR Xu9KTK4FVR+J8Ok9hqSyUBCI+8stYzJ/OrjiZddwXFYHcW1Qk+1wlFUQiXpmM2e73TUu 4MRFv/91gaXZxTds9QUXWoUVFPrhvWfR4O77n99gO0tPKUjDuWCYAZkW6/8T6vf1FtGO /RLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lmabQ6QIrPhC6gHbbbnIOeOPPxHLqb9/uiOG+55mjHA=; b=uychgPNBSxIaSY6UNZmM2ygvBfyN0v5TiZcnSq89ChZ8Ez1zt2ttsrupAJVHWGHNQT jN3jKH8AnyTyDCE2GcOHQk0aEh4OUvXTTv0D7ig9fm8tg1nicToroEX3vgtBFkrqFoDV lMh9zeMkK+piHLlGCKYkv3j2NLo/SpjktcTYMZmbbENrzA97s3FPl/whH4BotsA5bBzR eZ5FqPNhPJHZHXK77ChrY7YaMXUZpUGNENidiVX5xuw7Q1BsDUxFAxxRd4VA/zGs8phd KGDjNvtfJXjknVPrxV/JGCQfRtAC6U7DACYFTmiZIyzhy+svuKOoYEOFrtmN7lD/iK6j S6IQ== X-Gm-Message-State: ACrzQf2uBaVjJPfh35GXrRQ39fY3+9ABwEHqdNe1i/NJUWFgNSUsSkYe ze8bdqoTEh3ig+YOJ3GysoO//XDepw9z6NfGc9c= X-Received: by 2002:a05:651c:12c2:b0:26c:13b9:a694 with SMTP id 2-20020a05651c12c200b0026c13b9a694mr10190419lje.79.1667407266631; Wed, 02 Nov 2022 09:41:06 -0700 (PDT) MIME-Version: 1.0 References: <20221102141513.49289-1-fnkl.kernel@gmail.com> <20221102141513.49289-3-fnkl.kernel@gmail.com> In-Reply-To: From: Sasha Finkelstein Date: Wed, 2 Nov 2022 19:40:55 +0300 Message-ID: Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller To: Biju Das Cc: "thierry.reding@gmail.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "marcan@marcan.st" , "sven@svenpeter.dev" , "alyssa@rosenzweig.io" , "asahi@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Nov 2022 at 19:29, Biju Das wrote: > > Then enable the clk whenever pwm is enabled > And disable the clk whenever pwm is disabled. I can do that, but I do not see the point in doing that. This clock is active whenever the system is turned on, all this will result in is some unnecessary clock refcount increments/decrements.