Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7f0ced5-d8b8-08cb-e354-780dc69a68cd@linaro.org>
Date:   Wed, 2 Nov 2022 17:26:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra
 power-off
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Sebastian Reichel <sre@kernel.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
        devicetree@vger.kernel.org
References: <20221031-b4-odroid-go-ultra-initial-v1-0-42e3dbea86d5@linaro.org>
 <20221031-b4-odroid-go-ultra-initial-v1-1-42e3dbea86d5@linaro.org>
 <20221102162344.GA3993882-robh@kernel.org>
Organization: Linaro Developer Services
In-Reply-To: <20221102162344.GA3993882-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 02/11/2022 17:23, Rob Herring wrote:
> On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote:
>> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
>> to its two PMICs in order, this represents the poweroff scheme needed to complet
>> a clean poeroff of the system.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
>>   1 file changed, 42 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
>> new file mode 100644
>> index 000000000000..65e42258717c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Hardkernel Odroid Go Ultra poweroff
>> +
>> +maintainers:
>> +  - Neil Armstrong <neil.armstrong@linaro.org>
>> +
>> +description:
>> +  The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
>> +  to its two PMICs in order, this represents the poweroff scheme needed to complete
>> +  a clean poeroff of the system.
> 
> You don't really need a node for this. Test against the top level
> compatible and then find the PMIC nodes by their compatible strings.

Hmm ok, indeed would be simpler.

Neil

> 
>> +
>> +properties:
>> +  compatible:
>> +    const: hardkernel,odroid-go-ultra-poweroff
>> +
>> +  hardkernel,rk817-pmic:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Phandle to the RK817 PMIC node
>> +
>> +  hardkernel,rk818-pmic:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Phandle to the RK818 PMIC node
>> +
>> +required:
>> +  - compatible
>> +  - hardkernel,rk817-pmic
>> +  - hardkernel,rk818-pmic
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    poweroff {
>> +        compatible = "hardkernel,odroid-go-ultra-poweroff";
>> +        hardkernel,rk817-pmic = <&rk817>;
>> +        hardkernel,rk818-pmic = <&rk818>;
>> +    };
>>
>> -- 
>> b4 0.10.1
>>