Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com>
Date:   Wed, 2 Nov 2022 09:07:34 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.1
Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable
Content-Language: en-US
To:     zhang.songyi@zte.com.cn, snelson@pensando.io
Cc:     drivers@pensando.io, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, brett@pensando.io,
        mohamed@pensando.io, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, jiang.xuexin@zte.com.cn,
        xue.zhihong@zte.com.cn
References: <202211022148203360503@zte.com.cn>
From:   Shannon Nelson <shnelson@amd.com>
In-Reply-To: <202211022148203360503@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkVkZHE4VllhdlVBRlYzeDFvZkFJaVhoQVc3OVJaczFEaHRObmNONTBKK1p0?=
 =?utf-8?B?alZzeWRHUUtJRmkrS2x3eTNscGlDQkxxZzNkQXBlUHNsTGd5L2ErRlpwY25N?=
 =?utf-8?B?RklYWHhaNHNzQnJZNVpNKzVCUkc2U2RtRHpML2pqdkpyZytiVnpTMGc2cFdv?=
 =?utf-8?B?TEFFQi8zWnd4Z0lQUUt2SXkzaFNZcGhWVnA5ZVFsL2hqendMaWRKOVI5SFdS?=
 =?utf-8?B?SjVvQjNQMnFBWUxyeWpIN0J4em5TcmdyT3YrbVBoQjMxT3dWUVZaRWM2T21z?=
 =?utf-8?B?QmVOWVN5enZSUjdjaXErTzRyak9ZV1F3L2ZGS2JSSURqVGFMM1o3OGNzNzNZ?=
 =?utf-8?B?MkxiRmRRMDVEMnVEc1hwMXhUQkZiclRja1NsQStERHU2TFBaN1piYUtPNERy?=
 =?utf-8?B?aSsvSnNXYWUrdmdzK2N5UldDeEt4MWJtWEZSclNvRGE0dld5KzJtaVlRUUYz?=
 =?utf-8?B?LzlYei8yQzF4VXlJMTgvcnBTeHlGQVR6a01TcWlMU1VNcWJNYmEyUU5hTFc4?=
 =?utf-8?B?b2gvZzlLcmY1RWdtUGdLaXREdHlVaU5TOFdwMXNMb0Z0d2U1bE9xVnZuYzlw?=
 =?utf-8?B?Q29MaE1LdXBjQ3pQR0hHTHZXYm1xdnJGSUtjWVdyN09tYnNBVmJ2cUgyRlp0?=
 =?utf-8?B?NFNYVFhDeUJvbkNWdzlMT0JkeWFYUk5OOXQwTUN0OWViY01laHlreU9zb1Vy?=
 =?utf-8?B?eWFJYTNZQUxzOGFKVzhvTGlKL0ZoZ3ZzTjcxaE4xaFhWVkVyWXliV28wbHo0?=
 =?utf-8?B?MElBSDZvbkI2anZSc2t1dGRHTy8vd0ZzQWJTa3QzdUF5M1o0L1NEbDZpS3Jx?=
 =?utf-8?B?UXN2RUw0cTROZjdvUGRvUjFDYWJEOHNrbS9Pb1RyZ0k1K1FCUnNwMEk1blVJ?=
 =?utf-8?B?TTJsT0hHVklpVUZUWkFoRXNlSGoyb3JDKytMYjQ0NUVkMzhJVUJtenZXbEU1?=
 =?utf-8?B?K0ZnNCtvNFNzWEhUUU5QQjE0Nld3N1VPNFlJZmszUFFVWVAyZlFYd21PT0hs?=
 =?utf-8?B?S091bmRSMS9sdGtCbFFsdnZGcEVFUWpnRktRMkRLVHpFOVkrWWJOdDluM3JW?=
 =?utf-8?B?N1FrakFVejR3SmdGb01xeVdrREE3aXQ1a2ZIc2J1S1VSSk9tTWhOOWZ3SW84?=
 =?utf-8?B?N0E3d0NGdmhrSkZYcXM5SmlVc1EwWEMrOGt2R3Nzaktub3FZYlMwb01PWW04?=
 =?utf-8?B?clllU1RnOWFOWkNiWm9XQm9ISGNxTURKNG9NYTdaSjd4SU0vRDBIZXFJSnQx?=
 =?utf-8?B?MVZEYVlqTWFzNjVkdDJiUlpYVHVGdUs1cVB4M3VYQVZlazNTMVZHVkJpdTFF?=
 =?utf-8?B?Q0JVTGJPblJVMk1Ka25nUXNuMUUzeGtEaG54WDlhMjZWTFpuMUVLUG4wak8z?=
 =?utf-8?B?SEV2NzIvK0FpTGtHdzlYVklXOHZDUWoyWG44L1E0Z1Vma0Rrcy9SaHd1OG1s?=
 =?utf-8?B?ZmxYaXUzeWdXczlick9CcG1TcmNZUm5FWEY3YTlzZWdhUkw2QkFDcUlDYVo4?=
 =?utf-8?B?bnRSMWFRQlMvc2dCd3huMnczZCtjeXBGTThWaUhOSHVCQTBKQ3N5YUVUcFly?=
 =?utf-8?B?VVIwK1pHWHA5c3Jpc2JOODUwRTB2bEQ5VndBeDVpQVFLVkRvMCtoWlhGM3Y5?=
 =?utf-8?B?L0piNlgrSG1SV3NmTVduNjgraHZTL0E2VUtlUjdYTWIreHFMYzE2RmlmUHAw?=
 =?utf-8?B?SXVqQWFzS2FSdi82d0xNRnNqYVdBRGNuYWI3c1hPOS90dy93TUEwdDlLb1FQ?=
 =?utf-8?B?UHN4dGkzbzgvaGlsTDhSRTNNcURSc0pvUFpzczQxU2hyYjdIOGx5ZzFybzk4?=
 =?utf-8?B?RUsxSkorR2hYUW52UVZ4b0pGVWpBMGRuODlyOU1JUEdjME9nUE5WTVNTSWYy?=
 =?utf-8?B?UG5RNUE4REhtQ0Q1S1pabndwWGlXK0h0N3JsdFo1aFY1RURrazJueDZnSEVu?=
 =?utf-8?B?MitjMERKbTU1cWJybEVCYmRKaDZXUWtSWEF2RUV3UVJ3OWdrMkVRU0IwWWlq?=
 =?utf-8?B?Rmp4R2RrM2ZRMVhaRWJKN1hGSVhJbHl5Z1RNRU9menN3RitxYmZybmhKQ1p6?=
 =?utf-8?B?VDhJbG56anpLSmxOakxuSTNmbVNrdXVTK2dnR0NFK2cwRExlSm9abUNjcGFB?=
 =?utf-8?Q?vG3vEbMSq6+ExlRB2Bv2Zyjnk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4f516cf-b3c0-4fcc-5ba7-08dabcec5c58
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 16:07:37.6131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3LsKM/NIq4P8IehHJ0cF7RISZVJba3A/6CD089XC3iuh41Bp0Lf7qRkJlrpye4xNRDY4rNN3akqTJnMOn58lpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5467
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/2/22 6:48 AM, zhang.songyi@zte.com.cn wrote:
>  From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001
> From: zhang songyi <zhang.songyi@zte.com.cn>
> Date: Wed, 2 Nov 2022 20:57:40 +0800
> Subject: [PATCH linux-next] ionic: remove redundant ret variable
> 
> Return value from ionic_set_features() directly instead of taking this in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>

Acked-by: Shannon Nelson <snelson@pensando.io>

... although these changes usually go through the net or net-next trees.
sln


> ---
>   drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 4dd16c487f2b..a68d748502fd 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1557,14 +1557,11 @@ static int ionic_set_features(struct net_device *netdev,
>                    netdev_features_t features)
>   {
>      struct ionic_lif *lif = netdev_priv(netdev);
> -   int err;
> 
>      netdev_dbg(netdev, "%s: lif->features=0x%08llx new_features=0x%08llx\n",
>             __func__, (u64)lif->netdev->features, (u64)features);
> 
> -   err = ionic_set_nic_features(lif, features);
> -
> -   return err;
> +   return ionic_set_nic_features(lif, features);
>   }
> 
>   static int ionic_set_attr_mac(struct ionic_lif *lif, u8 *mac)
> --
> 2.15.2