Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp312248rwi; Wed, 2 Nov 2022 12:12:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5uFJ1Qr44GFqjmWYzI0GeJs48XjR/zIQfJfwMcM29/ybReFJVcuvGl+/PbwhmQ1u011Sdd X-Received: by 2002:a17:906:1c52:b0:7ad:c6c5:eae8 with SMTP id l18-20020a1709061c5200b007adc6c5eae8mr19554286ejg.439.1667416345834; Wed, 02 Nov 2022 12:12:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667416345; cv=none; d=google.com; s=arc-20160816; b=nFBUOOX3XnK0cREB7DkXl82dWSlcZMLaJkTy2H2cAq1I7FIoLqMMVA3u+mEkyyuyzO VfTkhO+Pd5N9H+Ld1uYO7MFEs5Ma/5+aW3DJBf9NfipGgIITFO3DePiHutGmWzsAXzmy fZ5Kk+Z1/0jubUj8ygicDrXbHqyHK6Cyq0eJb11N/xQw4PMfUiEkojt1yokWGQV5vg6/ 6Azz5Yy7aknYpRqyoSx9OHuSz71Pnb4eq7actdev2lbfTTnAAdbJy1Zt1AIeFwRi/eY4 HX3G/TKOKYJI26+aXVmvMFmbuqvILUW5AXf37BB7L+MOmqaGC8jVdZh+xleIovBpRkjc Z20w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Tv4s3DGZYSBfbWComYqGg/DMiWIB0G4uY2vq2vBD4rg=; b=KwopfIHGRCc6+v7JBckR2+6f6fkVVopYrIhR2YifkJ12ViKByXob/J3Ud80nslbFHX JGvuMCL29YizJnjUeHWFYzkQgt7pFfpqiv8FvKQW0y/M5BxUKOZU05dsu2yFNhzumTvV Lge1HneJJrchT+qjxCHcWQCl1DeHgPEboJ0M0f61o2QoruANKa9lHFNCEUPAXab8f5wG YTB7rr4m+dsuncmatqTZ8GFRqNQoNItqo5NsSAE/BwFkpB2Q44YGbbbcZxNb0PAkhjr2 OgDFaAl4jjp2EfjCKGtDpSmIYU7cyKq2E801+ojbG7Fxe2+d1HDGJ16FkbF3jc9wYzSv Z31Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FCM2EhkA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du5-20020a17090772c500b007a8c58b51a1si17385709ejc.179.2022.11.02.12.11.55; Wed, 02 Nov 2022 12:12:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FCM2EhkA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbiKBScs (ORCPT + 98 others); Wed, 2 Nov 2022 14:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230498AbiKBScl (ORCPT ); Wed, 2 Nov 2022 14:32:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEC85116C; Wed, 2 Nov 2022 11:32:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E287B82426; Wed, 2 Nov 2022 18:32:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E08EC433C1; Wed, 2 Nov 2022 18:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667413958; bh=1upx5yZlmjzlwDN2hfo/FCbOeFQhUpRj4FQggZnfjj0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=FCM2EhkAixKpjHjemddj6Q8OboFXHBlCFm1MEP4eNDLcwjjEMCbfHQqWUKkn0RQjx YhnpV4SdF5x8QISj+vbKMsJRrWL7OQVWt5TBHndXib7EUyPfkEeZ33qajwlEYlUhGq NQ6kuXwyZGCCjx25UTRSZip2slV3W2gEODs9nI3KYbKco+DDCKUH+aO+ayUVvuuxBd C6Ojp6ppM0WZTs0xDgUNminsp/xEsffIMmwYeon9zSG4AwhLUtPJpEL6pDaAeCq6GY xttJ8g7EhrMFlVagTcFzT3L7EAmqhiaFIL42FyI9bRJdXNJ02lQoN0oI+CP0Mh23Dl 64/fRWJqa+Qxw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E26F75C1813; Wed, 2 Nov 2022 11:32:37 -0700 (PDT) Date: Wed, 2 Nov 2022 11:32:37 -0700 From: "Paul E. McKenney" To: Uladzislau Rezki Cc: Joel Fernandes , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] rcu/kfree: Do not request RCU when not needed Message-ID: <20221102183237.GO5600@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20221029132856.3752018-1-joel@joelfernandes.org> <20221102163544.GM5600@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022 at 06:30:24PM +0100, Uladzislau Rezki wrote: > > > > to wait for a GP. Or if the poll_state_synchronize_rcu(oldstate)) != 0 > > queue_rcu_work(). > > > A small fix. If poll_state_synchronize_rcu(oldstate)) == 0 then > queue_rcu_work() since a GP is still in progress. Both get_state_synchronize_rcu() and poll_state_synchronize_rcu() may be invoked from interrupt handlers. And from NMI handlers, for that matter. Thanx, Paul