Date: Sun, 5 Aug 2007 17:18:01 -0300
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Adrian Bunk <bunk@stusta.de>
Cc: Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org,
       ibm-acpi-devel@lists.sourceforge.net,
       =?iso-8859-1?Q?Ren=E9?= Treffer <treffer@in.tum.de>,
       Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Subject: Re: [2.6.23 regression fix] fix thinkpad_acpi without hardware
Message-ID: <20070805201801.GB16723@khazad-dum.debian.net>
References: <20070805195354.GF3972@stusta.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20070805195354.GF3972@stusta.de>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1314
Lines: 34

On Sun, 05 Aug 2007, Adrian Bunk wrote:
> Ren? Treffer reported that booting a CONFIG_THINKPAD_ACPI=y kernel on a 
> machine without the hardware results in an Oops.
> 
> The trace is thinkpad_acpi_module_init -> thinkpad_acpi_module_exit -> 
> driver_remove_file -> sysfs_hash_and_remove.
> 
> The error handling if thinkpad_acpi_module_init() fails generally looks 
> suspicious, but this patch at least fixes the common case if no hardware 
> was found, and it seems in this case there isn't any cleanup 
> actually required.
> 
> Broken by commit d5a2f2f1d68e2da538ac28540cddd9ccc733b001.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

NAK

Proper fix already sent to Len Brown, and already queued to be pulled by
Linus.

Len, that'd be "ACPI: thinkpad-acpi: fix the module init failure path",
http://thread.gmane.org/gmane.linux.acpi.devel/24413

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/