Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp472460rwi; Wed, 2 Nov 2022 14:13:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM60I2zJ2tmlgzrBOotgIuY4ewjYzVE0Oq8J8otTArj7/uqGKZnSTcEMQDiyGzi2aWvGNVn+ X-Received: by 2002:a17:90a:be14:b0:213:c304:1d68 with SMTP id a20-20020a17090abe1400b00213c3041d68mr23461022pjs.80.1667423608695; Wed, 02 Nov 2022 14:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667423608; cv=none; d=google.com; s=arc-20160816; b=BurVPnaLydJVtSgIr3yyVwoBiRGPd+k02cxNK1KhjwBun+rUIVAEdRA0Vg15wrFS3K cNKuP4FALrMVOgmc0laAcJIodgNC+c3ueTGUufH7UGwgAAAy6+mQRo+dxJhTyhHjUB3t 4KcPDk7YzVyyS5KWcae4iGfGnY0IXw/MLFXeS3l91f3WzSrZFbJWZ8nE42y+gQZJUa9V Mdu/Z66yWtvD0+DZH5NwDeyAnPvxtKA//Gh3ib3RZcHjjk73W55uz/twu6OVMA2t2Yf/ 6JAixVg4RmlmdnK6cPuCXHxH1hPDWlNV2e4F+HwvSQdr9ceEfhU8Si3OPpPiCZpMHfl5 iOIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=aJqBamUKNOwr6y5/YefZHgngdeEFwhd1jjW7I0tRTpM=; b=MnG9f0oor+abCRzMWwcaAnDk7YdIlONIKWxlJbFr2Vd9FzxUO98ErW8kJcrR5UlSWA Z14FLktzorCL7qfhRInOMPognJPuu2F7pIuHTomxojq7C6JuGqliydy8SoN9n0PKH2Eb iW4XFxbzyoPPoMhnkA0rbHsRlNYb8oeka3MIavDJAJTlFUdp5zKcemB0vrlPYCd+5Q93 n6GAyDcq+eAfdSb8qVtjPrApbwYdVtbtdlIoaKHg9doiLqRE4jaHxk9th98lBVLStRN0 h7qfLBxx1kwBchz8r4KS7tHiYYkGqkGUWGx68EP1MTL1FduOhKbznSfbxmgXYp96H2Qb 6QnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=W63auvdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a63ff52000000b0046ea4ef43d2si18505946pgk.378.2022.11.02.14.13.16; Wed, 02 Nov 2022 14:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=W63auvdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbiKBUFr (ORCPT + 98 others); Wed, 2 Nov 2022 16:05:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbiKBUFl (ORCPT ); Wed, 2 Nov 2022 16:05:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A45A325E5 for ; Wed, 2 Nov 2022 13:05:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 352F9B82469 for ; Wed, 2 Nov 2022 20:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AF43C433B5; Wed, 2 Nov 2022 20:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1667419537; bh=xEV5xpbDuWSJh2LBaLO8ieVEq+GdSGwnx2U960MGeKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W63auvdtfqK0AB3MzIdoV6cdyUNN8RU+3vabwhIQA7SWaV8tHObr5D6IptqREl7nk VNPaG7iAVDPtoxZSLG3No2/2ArwFcBGsI3fvSIz8o3iDi+yfmpO7Vbcn2+lCwc8F37 yrwP5T5TPGVDmXC5XHx/Ug7kjP97AF8Ll4Lq7Ssg= Date: Wed, 2 Nov 2022 13:05:36 -0700 From: Andrew Morton To: Pankaj Gupta Cc: , , , Subject: Re: [PATCH] mm/memremap.c: map FS_DAX device memory as decrypted Message-Id: <20221102130536.96c487d341544b7482eed038@linux-foundation.org> In-Reply-To: <20221102160728.3184016-1-pankaj.gupta@amd.com> References: <20221102160728.3184016-1-pankaj.gupta@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Nov 2022 11:07:28 -0500 Pankaj Gupta wrote: > virtio_pmem use devm_memremap_pages() to map the device memory. > By default this memory is mapped as encrypted with SEV. Guest > reboot changes the current encryption key and guest no longer > properly decrypts the FSDAX device meta data. > > Mark the corresponding device memory region for FSDAX devices > (mapped with memremap_pages) as decrypted to retain the persistent > memory property. > > ... > > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -335,6 +335,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > + params.pgprot = pgprot_decrypted(params.pgprot); > break; > case MEMORY_DEVICE_GENERIC: > break; Should this be backported into earlier kernels? Is b7b3c01b19159 a suitable Fixes: target?