Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp478277rwi; Wed, 2 Nov 2022 14:18:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7zpStmdyz6rzD8ygT9v2Iss9SRjz0Mg5hX22MeYKPF9foUlX4VxfMJhA6uT0tz3n+uQD4c X-Received: by 2002:a17:902:e5cb:b0:187:2d8c:a4fa with SMTP id u11-20020a170902e5cb00b001872d8ca4famr14125588plf.151.1667423882584; Wed, 02 Nov 2022 14:18:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667423882; cv=none; d=google.com; s=arc-20160816; b=Hp5BYtvlWwXGByGyIreVIpMDYkwP4OTyQxSQifAVLmpqRMBV2JZW71xDceepdHSWxp 4/PCPyp1sqlJ9XaWKDGzICCVn4AsbVvAt9n28Gdawiv4jdminlwk/YLh1OuKNBecMB4m F8LW4WskBWp7bZcuXtO/C7nzktce01i4yD6Ox6K5d0ofDXl07kJ988TLfxtWMvcBFtT5 7uhnSX7+UIY8PQpCZnE/IGfcktKxQLxGz33vdSRZrx68+CPf4qLSh6zSIYYDlvrxoYX9 2XYy678yfIHSt9z9aziiWrCjDUdZV2uXD57g/Ff+8yMrlcRQbsXQB/eWcwTg9YG7NSAW dnNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=rC0roGr/5SlhhcwPh6Z3ZFgwAoKnXl1OYijcbifeGBs=; b=QxtcxjuLUIxzr2FEI0tqxVjgc0s3NTVoOZNYn2xmI8elvqeVvLmpzYPNpuc++/CPF8 oPKeJzu1PlzOS98A2DtwX6JwD+iW22rSghZWEK2jV06N1C/dFStaItXV7i1K5+Sc6RQL fLOxtrYYKpMROvyW8Z2d3+8SUVKXQnFiCRrbS598YlF8+/WGY+U2JFqvRz4VQ+6i3f8Y /ZQTPA//e5Ux/SOdNmfWNHTWZSady+Bj89NSazOVJw9qatwYBLsa+tEEg/9DFEhUx0h6 EmMBP+jOkkBHbzQR18cpwkYY2QHPxQA/EfqtjEWk+qS30uQfMCdWa/XY2OtAcSYwuaPh 7kKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CuZFazWd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a63db14000000b00438894246e8si18253640pgg.169.2022.11.02.14.17.48; Wed, 02 Nov 2022 14:18:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CuZFazWd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbiKBVFq (ORCPT + 98 others); Wed, 2 Nov 2022 17:05:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbiKBVFp (ORCPT ); Wed, 2 Nov 2022 17:05:45 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7C8DFBA for ; Wed, 2 Nov 2022 14:05:44 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A2JTVqw023555; Wed, 2 Nov 2022 21:04:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=rC0roGr/5SlhhcwPh6Z3ZFgwAoKnXl1OYijcbifeGBs=; b=CuZFazWdj2W1/O7m3emL3SXIvl5IsrkmH7tKQZEhKEek4lRo3eOKOWbXSArgHzNXWSoj H2bMQtpN/mPCltHa/H7dyqmkwM7HSEGAmW0gzWNEATGdxwn1aCg0sWfk/j6PfVwRtO3M SMkse33y50lh2mz1BzzDj4QerLptjkFNgqGduZYHBgS5YyzWR8VELUHPhHZe9SdAVN1P 4sZODbQAJ07k53+bfoMLb1zKyfzhQya9aJb+qi5eXCec+ig2pAFARmdavfXxgfSNWjP3 JgarAsrxZAaHW2+/2A9wZgaX+29O6DEANMv+pZxdrWFHXJ3hop8SWNqrHLO5auaWyRzE ZA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kkv6cgn8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Nov 2022 21:04:06 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2A2L45Fw008653 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Nov 2022 21:04:05 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 2 Nov 2022 14:04:03 -0700 Message-ID: <5979d266-e864-cc1c-fe2b-2c81f5223076@quicinc.com> Date: Wed, 2 Nov 2022 15:04:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major Content-Language: en-US To: Oded Gabbay , David Airlie , Daniel Vetter , Arnd Bergmann , Greg Kroah-Hartman , , , Jason Gunthorpe , John Hubbard , Alex Deucher CC: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Yuji Ishikawa , Jiho Chu , Daniel Stone , Tvrtko Ursulin , Christoph Hellwig , Kevin Hilman , Jagan Teki , Jacek Lawrynowicz , Maciej Kwapulinski References: <20221102203405.1797491-1-ogabbay@kernel.org> <20221102203405.1797491-2-ogabbay@kernel.org> From: Jeffrey Hugo In-Reply-To: <20221102203405.1797491-2-ogabbay@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: odC8jKcvU_ivvp5zxTUagHRw-HlMtXBP X-Proofpoint-GUID: odC8jKcvU_ivvp5zxTUagHRw-HlMtXBP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-02_15,2022-11-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211020139 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/2022 2:34 PM, Oded Gabbay wrote: > diff --git a/drivers/accel/accel_drv.c b/drivers/accel/accel_drv.c > new file mode 100644 > index 000000000000..6132765ea054 > --- /dev/null > +++ b/drivers/accel/accel_drv.c > @@ -0,0 +1,112 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Copyright 2022 HabanaLabs, Ltd. > + * All Rights Reserved. > + * > + */ > + > +#include Alphebetical order? > +#include > +#include > + > +#include > +#include > +#include > + > +static struct dentry *accel_debugfs_root; > +struct class *accel_class; Static?