Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <667a6ae1-7c2a-5be6-afad-d8f3e2f059fe@intel.com>
Date:   Wed, 2 Nov 2022 14:32:10 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 05/14] x86/microcode/intel: Expose
 find_matching_signature() for IFS
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-6-jithu.joseph@intel.com> <Y2K+9jfb5xiYE3eU@zn.tnic>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <Y2K+9jfb5xiYE3eU@zn.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U041aEtJUW9vV0k3SXlMQUN0TCtiM0lPNVo4ZkVSUnNFTFZ6WmdXNGdTRmJo?=
 =?utf-8?B?OG5ZUFArSjhkeFd0RUZpeXg3ZUtaUUNHRkMvMFV6TWV5R251NUk3V3BqZ09r?=
 =?utf-8?B?OFR0d3J3NW5aeXFlRmltNGQ4ZG1FUWYzRzNGZ3RKWnpkZTlzUzJneXEwOVBK?=
 =?utf-8?B?OUxBZ21Ib1JGRTJLaEQ4bzRreFkvckwwbk9HaGo4eUtPZnByejdlU0poSFB2?=
 =?utf-8?B?SlI4aTUzTEs3UFpVVVFJMktoMVN2M0w5dnJDUW1QeGw3QjRnSUM3ZDNrVm4v?=
 =?utf-8?B?cVd2a0NMSktLamkyZUxsbUJxY3NhRTIzNlpUWDhSY2I0QnVQYWpQdTY0QzVU?=
 =?utf-8?B?b2pqVTVzUFZ5d2oxZVQvdjZ3K2dJa2xkeHdTUU5BbTd1d2lSaHV2aURYa3dt?=
 =?utf-8?B?VE02MXhSTklYVVdmVEVyWHRsS255T1NZdWxSQ0ZFWkt4TUFzWjZsZnBzOXFH?=
 =?utf-8?B?RzZUa1hLT3QwdFlEWE1DdDF4TWdTdlpCeXdvTFNINDNqczVWN3psR3lwMExy?=
 =?utf-8?B?bXZ3M1c2MWppeUg3SVNSVi9ZclRISVFHUGlaR2dFNGEydGR6RE9uNStLSVpO?=
 =?utf-8?B?cUtiYW1MYnFrS2NBM3dQU1F0T0xNWEdEV1V3NWNleFhkOEc2cjV5eXRIK1hj?=
 =?utf-8?B?aENpeWtoZ3JVTUViZFRFcXBCb2cyZXd6ZS92b0FjSWtoNU1iU1A2SGZPYmJh?=
 =?utf-8?B?cyt1cWtpUEFYaWxCWmxlUElSNUNzODRSZWo4Rmx5L2xOVVM0SWFsOW5BeWQ0?=
 =?utf-8?B?SVhISXB2YUJwd0JINEQ4K3hhcEIvWlYzR3ZKS0NVNksya2tqY09ucUhHMGpZ?=
 =?utf-8?B?K2dvYlEydFVSS1oyb2FNSkE2WUpzcytUZ1MvVlh2MU5GbnFqRG9qRVhTVy9l?=
 =?utf-8?B?SkpmaVVINnpDUnRtaEV0bTMrK3BHeDQzNlIyMXNCZDN1VWpDeGN6ZTh3dk5P?=
 =?utf-8?B?dUpIb2dNRnlNS0Urek5RTGpwVFlrRld3K2cxQmREbEhjVTVYUkFJT1VOZkxH?=
 =?utf-8?B?dXFrTFRZRGhVWm5GREc4cXpOU0IrcWU4S0JZNlBUckd4dWR4VmdEY1RCL0Jn?=
 =?utf-8?B?SmsxNWdseWlKbkdiOUNFMWcvMm1FTzJheFlhWVZZSlhoelpvY2dzWmdNSEs0?=
 =?utf-8?B?US9hMFlGS0t6bU9yTWR6NUdUZURxNG9UQ0V0Wi91QXpsYldiQk4wWnhKUEcz?=
 =?utf-8?B?TUY4ZXhHWFJKcjlqdzRVWlBmLzVDZjVNa2ZFNUJVTjl3NmJIN0h4WW1kdGhX?=
 =?utf-8?B?RDV6cUN3ZVhrcG5DcE9nR1VnMGFaQVNxNkhoVGVGL0V0VHFlbmEwakdqdWpF?=
 =?utf-8?B?d054WXZESFN3cTJsbUo0aTVubGdFdHdJMzd4eHp2SDlYTjh0N1AwSnNrUEVu?=
 =?utf-8?B?eUdGY3crMTRIazNGZlRNREZTeHpGbHFBSGhUVXdjSHZEOERFNVlETGNackFi?=
 =?utf-8?B?VE1hOW40WkdMVE5wT2h6TkVKQ25kSUEwZGExUHZmNlErbko2dS8wUGFINlY0?=
 =?utf-8?B?ZjU5dWpFeUNibloxK2ErK2VpU2ZHVDNyM1RCV0VSbVM4dzFNSHFUcm1OTjVk?=
 =?utf-8?B?V296dXFoN1RPc2g4ZzhVRXpXRDRjYUZXdjg4Mk5XR25heWtmby9uaURaUTg1?=
 =?utf-8?B?T1o2TUUrakhpdkZ4Y25LOXcxUmNvNExLVXVtWDh6SVpITjdUZkcwTjBMQ0J5?=
 =?utf-8?B?SFVFUXh3ekV1OURrdGdhWDR2QUZMZmVLcXZFZFBkVEJjTWExRXJFdkdBT0dM?=
 =?utf-8?B?QThmWTIzQnduRGpxc3hnNE5MK09wWVE4MkFLZVFKcksvRzVMS1dtdzVrOWJv?=
 =?utf-8?B?M1BKejdSZmRrN2NLNVA2RXg0TmlVdEhPRUVvVVREYWRleUNrZnFIODZRdmZB?=
 =?utf-8?B?ZjNyVDhQci9hTDJuNGV4ditORklEY2hLSHVBdTM0RUVsTkFEY1pqNkxXdmdU?=
 =?utf-8?B?cVlleHROV2RyeWx1dHVhMHZqTXJ6NUZ6SXcrMTJMdnpjQXM3bnVpTkpmZzd2?=
 =?utf-8?B?NFdpeEVmNkJ2aFBicjBVYXhZL29OdzR0eVk2QnFBV0swV3hoWkpIOG5Td0hN?=
 =?utf-8?B?ajZ6YzcrcHBMcExGVDJxRFF3TlhGNUlXMWRXVG9mUlgzRUF6UkpUVGRqR1Zs?=
 =?utf-8?B?aFplMHV3bVpFc1VscEFNRit1VFF6THJmQW94UkxmWXU3K0ZMNktROS8vUXkr?=
 =?utf-8?B?c1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5309931-45fe-4573-eb34-08dabd19b644
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 21:32:15.7554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gbOVrkmjyluCMsbDmJ2ZrTtjgplD/hgNCnLV+6SlPicYswVAqppKkQ26YxDedqSj7eUM4SJ9iU0ta+PYsNYo9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5074
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/2/2022 12:03 PM, Borislav Petkov wrote:
> On Fri, Oct 21, 2022 at 01:34:04PM -0700, Jithu Joseph wrote:
>> IFS uses 'scan test images' provided by Intel that can be regarded as
>> firmware. IFS test image carries microcode header with extended signature
>> table.
>>
>> Expose find_matching_signature() for verifying if the test image
>> header or the extended signature table indicate whether an IFS test image
>> is fit to run on a system. Add microcode_intel_ prefix to the
>> function name.
> 
> This doesn't look like the right design to me:
> 
> If this is going to be generic CPU-vendor related code which other
> facilities like the microcode loader can use, then the prefix should be
> intel_<bla>. Just like intel_cpu_signatures_match().
> 
> Then that code should either be in a lib-like compilation unit or simply
> in arch/x86/kernel/cpu/intel.c. Just like intel_cpu_signatures_match().

Will rename the function to intel_find_matching_signature() and move it to
to arch/x86/kernel/cpu/intel.c as you suggest above and add its declaration
to arch/x86/include/asm/cpu.h (where intel_cpu_signatures_match() is defined)

Jithu