Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e11f09fb-4037-1869-65f5-a83786f513e8@intel.com>
Date:   Wed, 2 Nov 2022 15:10:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 13/14] Documentation/ABI: Update IFS ABI doc
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-14-jithu.joseph@intel.com>
 <0722deb9-797b-c8b6-ac15-a6d9a7d50a67@intel.com>
 <511d9020-04d2-0deb-5f92-a7b2d6b9830e@intel.com>
 <d8f3fda0-5c2d-f19c-23b7-7df6ac38ee41@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <d8f3fda0-5c2d-f19c-23b7-7df6ac38ee41@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTlRU05FSHVwNUVLWWl3U1BPRFNxeXVwWEUvTXh2MUlMZnh5UVc1enZZSHdH?=
 =?utf-8?B?cVdiN0Vob1VhY2ZMczhHa0VMVWNMc1pranp2NkpjU0g0N0dNajhUaTBPeFNa?=
 =?utf-8?B?Z3FGWm5rU3pnUTE3U3JqQW8yTFMydmxTZitmUmFadXJrTFQ2ZlZHM0VrR0lI?=
 =?utf-8?B?cVhrd2E5VFgxN1l5RWFPa3JRaC9FbnFOK0xaMjZsWTEzOGZSUGtlRXk1Ti95?=
 =?utf-8?B?L2NLOS9GbXkySEJzZ1Q5emoxZWxFeTZhRS9sOGtBL0FnZ2hvL05RYTErSTBL?=
 =?utf-8?B?YmdCVkpTZng5TUxjSEYxL21oTy9wZ0NMUXJsL1U1bmF2TEFFdm43U05scFZh?=
 =?utf-8?B?TmxVRzFtVDdxWW8zNUtSL2hORThmcFMrNUFBQXJsczB0VkhOMmJlaUZwOFNG?=
 =?utf-8?B?dit6WUhDSDZ2RnNsK0FvanEzb3NXQUdjOEdNZ0tZc0hLS0wvRjFQYWxOVldH?=
 =?utf-8?B?cC9jL0hCVWdrWk9DbEt5ZC8vTFZ3SEkxS3NGU1Fkb0RQQzQ1QU1BR2NOOUVS?=
 =?utf-8?B?WU9OQ3cyek5ZUERJWTdBazJPeG9vbmp4U2F3YUpmYnM5SEVoMXVEbjBabms5?=
 =?utf-8?B?QWsrZmJycDU1enA5dTNmZHpXN29haGp5MHM2RW1LUElHN2o1eVkvTE1OY2tY?=
 =?utf-8?B?WFM3cTI1VmZyQlVmR0hseExBS21LOWlzMnZBUGJDSktSdXNaWFRBYndIWndV?=
 =?utf-8?B?MTlCTFJuNkx6QVRvdWtoU09IMEk2OEthalpud1JOZUhyM0wzVXROejhNYnVR?=
 =?utf-8?B?SnJTOGxnbGVXRXArZm8rbUQ3bldXbE0zN0Nmc2NFaG5rWHQ4SFArWWhScXR4?=
 =?utf-8?B?TnVQUWNNWnpkeEhub0YxVkZ1bVRQY3Y0Rlo3UGRNSDhKWjd4S3Y4Qy9LZGtR?=
 =?utf-8?B?ZVZ3cE9kWmhQci9pUGZTMDRZdmx4U2JFSngvVUh3eGcyS3dXdjdMWlgxeHp3?=
 =?utf-8?B?VFdEdHl0clNrUmNrdFI5RU4rNUlmemRvWHRJRFNvcTdEVHZXakNTVExMNERm?=
 =?utf-8?B?d09ZT0kyd0cvcTFhQUVuNnluL3RTa2tJcmloVkdMV1Vja25sQ0NjZVNjQVRS?=
 =?utf-8?B?bjIzQldnMFMxNUl5SG9qa1AvOFJTU1FGRWxGeTdyeitjdDRHcGtoNURrL0lo?=
 =?utf-8?B?aWE1cnF5MDl2QUxFWXZkU2xHai83akRKZGpDYnhnUWxuN2VFWFljcEFKVkZW?=
 =?utf-8?B?eDM2WDk5WDBYMDBVVWlQbDFhcEtRb1lYMS9YcTJsN2pRV2ZoVVJRd3BueVA3?=
 =?utf-8?B?a0l5Q1pReWtaVXZncDdZSUx0dHAzcy8xM3VrY29OL05YT1BoaTBlNTRsbUZO?=
 =?utf-8?B?MEhGRVJ0VVNrMXJ1MUk4Qitwd3UwTUVueS9zZ00yRDdBMjd5bDVEby80b241?=
 =?utf-8?B?WFpUQXErdmZjZGt1elViTGFDYm4wWVdNZDV4aTFtRVlPTXhEaFdhZkx2VEZp?=
 =?utf-8?B?RXprTW82WHU3Umg4MWhXaUswWU40cE9WRmQ2YVY0MUV0ZW5sMGtkamhtNEkx?=
 =?utf-8?B?SkJDb1BINTRWZitpeGFUVEthQ3p0ekJuY3NrSFNJeW5kc2Z4UExRRkJXUWNK?=
 =?utf-8?B?NVNVaEJrcXJncWI0UyszUVc2bGVndWdzYjQrNlJka3BaUHFpbjhUdFp4UDk3?=
 =?utf-8?B?ZXlIREo2aHIvRUo4Y1FMa3JSZW80Q2J0d0VWN3lLemNSWHluMERZK2RaL1hl?=
 =?utf-8?B?bmt0dys0SnhaTkthVlR2OUxUc0ZkVEw0cVh6YXdoTDdpZGVaeDFqSHNqWmx5?=
 =?utf-8?B?ZkthS0hqVVRjQlBFc04va2xtUDJwcVo0MWF0SFFFMXNqL2RyZG9HYmUxUURi?=
 =?utf-8?B?Z2ZVS0J6QjRwNmxlRWYrUUhHR3JSUkRZc1dqMGRFYjhVa0x5RHg2aCtrdDlG?=
 =?utf-8?B?cW1nQ250aVRub0Y5MEFYbkVpbmhXZ2Npbmg3OWhwUDIxUW1hL2J2dGVUSGlq?=
 =?utf-8?B?RWl1eG5YMFpRVXNLc3lRanRJT3pwMktOZVFlNnl5SlNrTmhVdXRXdUhERjBh?=
 =?utf-8?B?MnBEMVFMeUkyZ0JmVU5Zd0VoaGpmMHErL2lSVEw3ZGo5ekprZVlJQnlCczI1?=
 =?utf-8?B?L2FhakttNjdtTEFJcHN1eWNyVXlNZngzdktaUlR0QUVsYlJvcmJoWUgyMWtR?=
 =?utf-8?B?RGVaVVgvM3hHT2VRWHJEUFlaM3p4RGVWWEI5ekJ1KzdkTytac28va0Z1SUFL?=
 =?utf-8?B?aFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1e86363-3c4a-4683-91ac-08dabd1f1084
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 22:10:34.6511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +DsVGTNic0Y7uQig7nvyR9ggXukbdWukDCxU9ehy1/Vbmf2eonwG08u+cgOVAIgYqgcq3FAUszJQxs0jjGqRzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6202
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/1/2022 3:59 PM, Sohil Mehta wrote:
> On 11/1/2022 3:48 PM, Joseph, Jithu wrote:
>> The testname would be inferred based the sysfs file context (the<N> in /sys/devices/virtual/misc/intel_ifs_<N>/current_batch) from which the operation is triggered.
>>
>> Meaning if the user writes to /sys/devices/virtual/misc/intel_ifs_0/current_batch it would look for ff-mm-ss.scan and if they write to
>> /sys/devices/virtual/misc/intel_ifs_2/current_batch  it would look for ff-mm-ss.<test_type_2>
>>
> 
> So intel_ifs_<N> corresponds to <test_type> i.e. intel_ifs_0 maps to .scan
> 
> Is the N to test_type mapping visible to the user somewhere? If not, how would the user infer that?
> 
> Would it be useful to name the misc device as intel_ifs_<test_type>?
> 

There is a mapping based on the device number, for e.g if the user tries to use the below sysfs file for loading
/sys/devices/virtual/misc/intel_ifs_<N>/current_batch

The driver will look for the below test image for loading
/lib/firmware/intel/ifs_<N>/ff-mm-ss-02x.<test_type>

The number<N> is same in both the above path.
Prior to issuing the load command, user has to simply copy the supplied test image to the corresponding /lib/firmware path

Jithu