Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <683e5c40-3e61-e1f0-3a7a-890993ec1dd5@infradead.org>
Date:   Wed, 2 Nov 2022 14:48:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v1 16/17] block, blksnap: Kconfig and Makefile
Content-Language: en-US
To:     Sergei Shtepa <sergei.shtepa@veeam.com>, axboe@kernel.dk,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org
References: <20221102155101.4550-1-sergei.shtepa@veeam.com>
 <20221102155101.4550-17-sergei.shtepa@veeam.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20221102155101.4550-17-sergei.shtepa@veeam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 11/2/22 08:51, Sergei Shtepa wrote:
> Allows to build a module.
> 
> Signed-off-by: Sergei Shtepa <sergei.shtepa@veeam.com>
> ---
>  drivers/block/blksnap/Kconfig  | 12 ++++++++++++
>  drivers/block/blksnap/Makefile | 18 ++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 drivers/block/blksnap/Kconfig
>  create mode 100644 drivers/block/blksnap/Makefile
> 
> diff --git a/drivers/block/blksnap/Kconfig b/drivers/block/blksnap/Kconfig
> new file mode 100644
> index 000000000000..3a6ecb5fc13d
> --- /dev/null
> +++ b/drivers/block/blksnap/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Block device snapshot module configuration
> +#
> +
> +config BLK_SNAP
> +	tristate "Module for snapshots of block devices."
> +	help
> +	  Allow to create snapshots and track block changes for block devices.
> +	  Designed for creating backups for a simple block devices. Snapshots

	  Drop     the                     "a".

> +	  are temporary and are released then backup is completed. Change block
> +	  tracking allows to create incremental or differential backups.


-- 
~Randy