Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221101102916.440526-1-j.neuschaefer@gmx.net>
In-Reply-To: <20221101102916.440526-1-j.neuschaefer@gmx.net>
From:   Joel Stanley <joel@jms.id.au>
Date:   Wed, 2 Nov 2022 22:52:50 +0000
Message-ID: <CACPK8XcmDuFta++nfr-Ub+fierfD_GVmXdZKxWTX6AewELUGSQ@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: nuvoton,wpcm450-supermicro-x9sci-ln4f: Add GPIO
 line names
To:     =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Cc:     openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 1 Nov 2022 at 10:29, Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.ne=
t> wrote:
>
> To make gpioinfo output more useful and enable gpiofind usage, add line
> names for GPIOs where the function is known.
>
> This patch follows the naming convention defined for OpenBMC, as much as
> possible:
>
>   https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-na=
ming.md
>
> Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  .../nuvoton-wpcm450-supermicro-x9sci-ln4f.dts  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts =
b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> index 26fed97f8ff4a..d4472ffdac928 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> @@ -58,6 +58,24 @@ heartbeat {
>         };
>  };
>
> +&gpio0 {
> +       gpio-line-names =3D
> +               /* 0 */ "", "host-reset-control-n", "", "", "", "", "", "=
",
> +               /* 8 */ "", "", "", "", "power-chassis-control-n", "", "u=
id-button", "";
> +};
> +
> +&gpio1 {
> +       gpio-line-names =3D
> +               /* 0 */ "", "", "", "", "led-heartbeat", "", "", "led-uid=
",
> +               /* 8 */ "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio4 {
> +       gpio-line-names =3D
> +               /* 0 */ "", "", "", "", "", "", "", "",
> +               /* 8 */ "", "", "", "", "", "", "", "power-chassis-good";
> +};
> +
>  &pinctrl {
>         key_pins: mux-keys {
>                 groups =3D "gspi", "sspi";
> --
> 2.35.1
>