Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp694593rwi; Wed, 2 Nov 2022 17:21:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7c2rmdad5C/FhkTiHbG5kgFCtnqR6+Y2P9r8KcRwycGkI7P6gBrcIWJ9+BVJEFANqpC3It X-Received: by 2002:a17:902:9004:b0:187:4889:7dbb with SMTP id a4-20020a170902900400b0018748897dbbmr5706464plp.137.1667434893603; Wed, 02 Nov 2022 17:21:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667434893; cv=none; d=google.com; s=arc-20160816; b=gRhSADelwU4TYuthrxg9xz50sbD3BD4TGbJeTBbz/JFWDrKdHvezZjRRUL+w4AdwlI qB/3I2/x7GERwjHILzpvBQDjovpyT/+WiCiNZe9S/XaqEirb2PY1BC0aDeeEeRv8iJYz /9pRMjb9eVtP+Yotgu/NNh9aYT6SFptJ8DdUWdstPv0y1VI0Ard2JzsosPPKo+Z5DJav Sob3kx9lcIatFvEYru0ZtZSi9C1srCr2929u9fPBmGe0koRxsJFSlQXVFFQ/cIjv1rRC 6WSihDQudmWVTetrmMDi48SovzHG1V1SXAFRzC1xUV0SNvYLkmX2ER3LWSsFhRlBjcGi sH+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=t5AqGgPaokx6x0rdC5uz+rjU5dq/lOC3mQZwI1qWWWM=; b=ho4dKuJwlnT4+jz1Houxx3TeouMTB2hctaiGCcQaHbl5PENx2zj8skCyvl9a//XqzV K/ApEEgnkr1NegP2CxhIG8Ij6ui+nU/Z9LnAgT8RDYsXPVt5PQ1+ZH+7HfO8Wco8CmU7 vBnc3xkNR8EJ/qzxV0d9ajOpPUY6xcnf8v7FIoiu+BudnyIIPZe7fOz02q6f0GTEvMws dRR9su5CE309vLYq4CZIIPU7O4xZ1DO3buz5GdHasV14FLKjBTJiji+QnfDZbJ/ZdHUj zILU7ZGJxqfV/UtnsKYNtiuSkLqkaT54GRTdift/ZCsRPaSmwHCAkylQWu5ILn4BzIdW rnYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2lQc0nXI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j186-20020a638bc3000000b0046f57b189e9si18611784pge.398.2022.11.02.17.21.21; Wed, 02 Nov 2022 17:21:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2lQc0nXI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbiKBX75 (ORCPT + 97 others); Wed, 2 Nov 2022 19:59:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbiKBX7w (ORCPT ); Wed, 2 Nov 2022 19:59:52 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F306F55BC; Wed, 2 Nov 2022 16:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t5AqGgPaokx6x0rdC5uz+rjU5dq/lOC3mQZwI1qWWWM=; b=2lQc0nXIKirMBa4o/dvF+NXVyc nyq0G4c3Y6tODFlxfJPvEFrzp7u999cDdCbQImfmCGm8LEr+avFItV98IZ7vT5r4g2F8qlDLoXKrI sGcK1fLVzSFrDpi9ihWorXe7ZAD/yBzC9Xk9li1KNmQLQu+O/Y0+BQZGHtAIHhCR6GlXj6h/38caX g98vFMkepKFvL68ADOye4fDgtHlk2uT1OJfBAAdFp3gbMm01dltKKhP22PndC8Wffr+qJOcE8y6Rp Tb8TsWBuG9oyXMBdQcgXP3kPnqcdpc2qpNa9GD4ckfBgsCBVeoXRWEKKL+Ns0+SQotRwqBV5g4kc3 LPHdLXuQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqNeA-00FFcb-PY; Wed, 02 Nov 2022 23:59:50 +0000 Date: Wed, 2 Nov 2022 16:59:50 -0700 From: Luis Chamberlain To: Nicholas Piggin Cc: linux-modules@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Michael Ellerman , Jessica Yu Subject: Re: [PATCH v5 1/2] module: add module_elf_check_arch for module-specific checks Message-ID: References: <20221031120733.3956781-1-npiggin@gmail.com> <20221031120733.3956781-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031120733.3956781-2-npiggin@gmail.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 31, 2022 at 10:07:32PM +1000, Nicholas Piggin wrote: > The elf_check_arch() function is also used to test compatibility of > usermode binaries. Kernel modules may have more specific requirements, > for example powerpc would like to test for ABI version compatibility. > > Add a weak module_elf_check_arch() that defaults to true, and call it > from elf_validity_check(). > > Cc: Michael Ellerman > Signed-off-by: Jessica Yu > [np: added changelog, adjust name, rebase] > Signed-off-by: Nicholas Piggin Acked-by: Luis Chamberlain Luis