Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Microsoft-MacOutlook/16.66.22102801
Date:   Thu, 03 Nov 2022 10:50:32 +0800
Subject: Re: [PATCH v2] io_uring: fix two assignments in if conditions
From:   Xinghui Li <korantwork@gmail.com>
To:     Jens Axboe <axboe@kernel.dk>, <asml.silence@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <io-uring@vger.kernel.org>,
        Xinghui Li <korantli@tencent.com>,
        kernel test robot <lkp@intel.com>
Message-ID: <EF99381C-E842-49AE-A683-B8EABD1612A0@gmail.com>
Thread-Topic: [PATCH v2] io_uring: fix two assignments in if conditions
References: <20221102082503.32236-1-korantwork@gmail.com>
 <630269a9-29a3-6b75-0a67-449ec36e7e5e@kernel.dk>
In-Reply-To: <630269a9-29a3-6b75-0a67-449ec36e7e5e@kernel.dk>
Mime-version: 1.0
Content-type: text/plain;
        charset="UTF-8"
Content-transfer-encoding: quoted-printable
Precedence: bulk


=EF=BB=BF=E5=9C=A8 2022/11/2 22:19=EF=BC=8C=E2=80=9CJens Axboe=E2=80=9D<axboe@kernel.dk> =E5=86=99=E5=85=A5:

>    On 11/2/22 2:25 AM, korantwork@gmail.com wrote:
>    > From: Xinghui Li <korantli@tencent.com>
>    >=20
>    > Fixs two error:
>    >=20
>    > "ERROR: do not use assignment in if condition
>    > 130: FILE: io_uring/net.c:130:
>    > +       if (!(issue_flags & IO_URING_F_UNLOCKED) &&
>    >=20
>    > ERROR: do not use assignment in if condition
>    > 599: FILE: io_uring/poll.c:599:
>    > +       } else if (!(issue_flags & IO_URING_F_UNLOCKED) &&"
>    > reported by checkpatch.pl in net.c and poll.c .=20
>
>    I'm not super excited about this patch as the previous one
>    wasn't even compiled? Did you test this one, compile and runtime?
>

First of all, I'm really really really SORRY for the last stupid warning an=
d my careless.=20
But I did make kernel and install it in my device. Also, I did the fio test=
 with polling. However, there is no warning be reported by 'make' command.=20
But when I check the patch code with 'smatch', I did find that warning. I r=
ealized how stupid that mistake was....=20
So, in addition to compiling and installing this kernel, I also checked the=
 code using the static analysis tool this time. There is no new error or war=
ning.
"
make -j64 CHECK=3D"~/workspace/smatch/smatch" C=3D1
  DESCEND objtool
  CALL    scripts/checksyscalls.sh
  CC      io_uring/net.o
  CC      io_uring/poll.o
  CHECK   io_uring/poll.c
io_uring/poll.c: note: in included file (through io_uring/io_uring.h):
io_uring/slist.h:138:29: warning: no newline at end of file
  CHECK   io_uring/net.c
io_uring/poll.c: note: in included file (through include/trace/events/io_ur=
ing.h):
./include/linux/io_uring_types.h:151:37: warning: array of flexible structu=
res
io_uring/net.c: note: in included file (through io_uring/io_uring.h):
io_uring/slist.h:138:29: warning: no newline at end of file
io_uring/net.c: note: in included file (through io_uring/io_uring.h):
./include/linux/io_uring_types.h:151:37: warning: array of flexible structu=
res
...
  BUILD   arch/x86/boot/bzImage
Kernel: arch/x86/boot/bzImage is ready  (#10)
"=20

Again, I am ashamed of the previous mistake. And I totally understand if yo=
u reject this one.