Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Nov 2022 23:23:34 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Li Huafei <lihuafei1@huawei.com>
Cc:     <mhiramat@kernel.org>, <mark.rutland@arm.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace_ops
Message-ID: <20221102232334.0c1ae93b@rorschach.local.home>
In-Reply-To: <20221103031010.166498-1-lihuafei1@huawei.com>
References: <20221103031010.166498-1-lihuafei1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 3 Nov 2022 11:10:10 +0800
Li Huafei <lihuafei1@huawei.com> wrote:

> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -3028,18 +3028,8 @@ int ftrace_shutdown(struct ftrace_ops *ops, int command)
>  		command |= FTRACE_UPDATE_TRACE_FUNC;
>  	}
>  
> -	if (!command || !ftrace_enabled) {
> -		/*
> -		 * If these are dynamic or per_cpu ops, they still
> -		 * need their data freed. Since, function tracing is
> -		 * not currently active, we can just free them
> -		 * without synchronizing all CPUs.
> -		 */
> -		if (ops->flags & FTRACE_OPS_FL_DYNAMIC)
> -			goto free_ops;
> -
> -		return 0;
> -	}
> +	if (!command || !ftrace_enabled)
> +		goto out;
>  

Hi Li,

I think you misunderstood me. What I was suggesting was to get rid of
the ftrace_enabled check. The DYNAMIC part is most definitely needed.

	if (!command) {
		if (ops->flags & FTRACE_OPS_FL_DYNAMIC)
			goto out;
		return 0;
	}

-- Steve