Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace_ops
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     <mhiramat@kernel.org>, <mark.rutland@arm.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>
References: <20221103031010.166498-1-lihuafei1@huawei.com>
 <20221102232334.0c1ae93b@rorschach.local.home>
 <20221102232437.6e2b1ebd@rorschach.local.home>
From:   Li Huafei <lihuafei1@huawei.com>
Message-ID: <e925893e-1099-777e-7485-6dc8f1f37333@huawei.com>
Date:   Thu, 3 Nov 2022 11:38:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20221102232437.6e2b1ebd@rorschach.local.home>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/11/3 11:24, Steven Rostedt wrote:
> On Wed, 2 Nov 2022 23:23:34 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> I think you misunderstood me. What I was suggesting was to get rid of
>> the ftrace_enabled check. The DYNAMIC part is most definitely needed.
>>
>> 	if (!command) {
>> 		if (ops->flags & FTRACE_OPS_FL_DYNAMIC)
>> 			goto out;
>> 		return 0;
>> 	}
> 
> 
> Nevermind, I forgot that the out is before the DYNAMIC check.
> 
>    ;-)
> 

Yes. There we have the DYNAMIC check.

> -- Steve
> 
> .
>