Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
Subject: Re: [PATCH] mm: hugetlb_vmemmap: include missing linux/moduleparam.h
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <patch.git-296b83ca939b.your-ad-here.call-01667411912-ext-5073@work.hours>
Date:   Thu, 3 Nov 2022 10:51:59 +0800
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <71BFC75C-483D-42C0-8248-59FC8DBE148C@linux.dev>
References: <patch.git-296b83ca939b.your-ad-here.call-01667411912-ext-5073@work.hours>
To:     Vasily Gorbik <gor@linux.ibm.com>
Precedence: bulk


> On Nov 3, 2022, at 02:09, Vasily Gorbik <gor@linux.ibm.com> wrote:
>=20
> The kernel test robot reported build failures with a 'randconfig' on =
s390:
>>> mm/hugetlb_vmemmap.c:421:11: error: a function declaration without a
> prototype is deprecated in all versions of C =
[-Werror,-Wstrict-prototypes]
>   core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0);
>             ^
>=20
> Link: =
https://lore.kernel.org/linux-mm/202210300751.rG3UDsuc-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 30152245c63b ("mm: hugetlb_vmemmap: replace early_param() with =
core_param()")

Thanks for your fixing. However, the correct commit that should be fixed =
is
42deddf3ef5c ("s390: select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP").

Reviewed-by: Muchun Song <songmuchun@bytedance.com>