Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp918893rwi; Wed, 2 Nov 2022 21:17:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5rydOrgWpZlQkcFNUF5ixVZ0l8hqG3P2qW7GaWmZ9jgU0BYixe+uAqxseoXwimlAwBdTlb X-Received: by 2002:a17:90a:4e85:b0:213:13f2:162b with SMTP id o5-20020a17090a4e8500b0021313f2162bmr29350901pjh.228.1667449059703; Wed, 02 Nov 2022 21:17:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667449059; cv=none; d=google.com; s=arc-20160816; b=iuggiSVLxrrXnTCRQ/jHidIIezWQ5GCuL3uYb/hd9zsoVnB4vx/CA59E05sbFs5FAZ i3teUZej0BeE8FDGL4XWPUJiDDVXDnUvPViLjn4Egs12Hs+k0pgBL3fKeKN+kUnTeRxv oz61U6JFUJJkeLAterQgCvueSAmh/g5hJd/DXznICwETjmX7RrTtu+3oI0nHtFjhWRpF yAWYcK8LMfm5U5cgIfwMOzCX8DaUyy0H0W4WT6eyveNj/8xOUSzJkP0MiJ6Z1JqVFYO0 W898Idr0ZGgugMloARE0XvTHBKMxGwrdrn482GMbkM+EwaHYo3+96WybUksYKV9a5taJ mTHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=I4xsXpmsiN30I9KF0gODlHbZeIvd1MsKQhrL1+gmXeA=; b=YFpUqhsy2cdQ4nBESzYM5kQnPjOJjLcHXcWswucvg6ujBzVUgFVRsocW+9/E0sOI7r qFpA1CMHINTnFSCvMUHaWaiCSP6UmKUt6NJ9XbCUjo9sEJ0YYEvVQtN+O0TriKuV3tY+ 9fzNknTip+QOKLmRKBVhD9BZU1fqBHZ1XMoSQsG5c+7RUoO46UT7Fn/P/kBXwJzn58fI h1Dn1dTG9D8UzZVp/8bFXxy7CxowWPl65ZtntHux9kehlCUfc9VCtxrbbwqOIlAp2uDo DSdrQWLbJaxiM0xmHI8wcbpGtMOXIbx4eVswoTDvWKqqf/uY3z7uknkdV0Q0JqmfrHK7 er0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mujp9UsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g17-20020a632011000000b0046fb2a57382si15926603pgg.676.2022.11.02.21.17.27; Wed, 02 Nov 2022 21:17:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mujp9UsT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbiKCDu0 (ORCPT + 97 others); Wed, 2 Nov 2022 23:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiKCDuU (ORCPT ); Wed, 2 Nov 2022 23:50:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB3215708; Wed, 2 Nov 2022 20:50:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 35E90B8265D; Thu, 3 Nov 2022 03:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id B60C0C433B5; Thu, 3 Nov 2022 03:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667447416; bh=mUg/edvevTa+cRLGFzbQAxK/x7aY4ixITYU/GGFZ8yI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mujp9UsT1bZbHRDT0enBQ+lULMth/vAXrGI9cwXF8YFd/42jwg6sGoYFsPtjfexqS JNJ97JdcsJwJmzgLxDGeRpk0bMPPs7z/+XzIxHYMwk7yu6DPb5df578L/2uJ5EvbIK oSB/RSG7myaJYfotGob29bnnHVAP+emH4SLMRVjt59Y8FUUMGTKk2peHA7cEffyMRJ keCD9INkvJtKvor0VtH32Ag4X5NIyRCgc7NRBdKWRyWz4O7mmkuCp1bjTSVQrD3Uwj MvAupJWLOMrxcJJD3MWlRbGMxuT0DEvMRL0JjqBOBtS25JttPNY/hw6mOYxPOtXBuA B3m8nQ740IfOQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 94950C41620; Thu, 3 Nov 2022 03:50:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net/smc: Fix possible leaked pernet namespace in smc_init() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166744741660.12191.13112390295729778693.git-patchwork-notify@kernel.org> Date: Thu, 03 Nov 2022 03:50:16 +0000 References: <20221101093722.127223-1-chenzhongjin@huawei.com> In-Reply-To: <20221101093722.127223-1-chenzhongjin@huawei.com> To: Chen Zhongjin Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, guvenc@linux.ibm.com X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Tue, 1 Nov 2022 17:37:22 +0800 you wrote: > In smc_init(), register_pernet_subsys(&smc_net_stat_ops) is called > without any error handling. > If it fails, registering of &smc_net_ops won't be reverted. > And if smc_nl_init() fails, &smc_net_stat_ops itself won't be reverted. > > This leaves wild ops in subsystem linkedlist and when another module > tries to call register_pernet_operations() it triggers page fault: > > [...] Here is the summary with links: - net/smc: Fix possible leaked pernet namespace in smc_init() https://git.kernel.org/netdev/net/c/62ff373da253 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html