Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 00:57:35 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Randy Dunlap <rdunlap@infradead.org>
CC:     <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH] reset: ti-sci: honor TI_SCI_PROTOCOL setting when not
 COMPILE_TEST
Message-ID: <20221103055735.eo7t5aqniwlp2ykv@roulette>
References: <20221030055636.3139-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221030055636.3139-1-rdunlap@infradead.org>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 22:56-20221029, Randy Dunlap wrote:
> There is a build error when COMPILE_TEST=y, TI_SCI_PROTOCOL=m,
> and RESET_TI_SCI=y:
> 
> drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
> reset-ti-sci.c:(.text+0x22c): undefined reference to `devm_ti_sci_get_handle'
> 
> Fix this by making RESET_TI_SCI honor the Kconfig setting of
> TI_SCI_PROTOCOL when COMPILE_TEST is not set. When COMPILE_TEST is set,
> TI_SCI_PROTOCOL must be disabled (=n).
> 
> Fixes: a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  drivers/reset/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -257,7 +257,7 @@ config RESET_SUNXI
>  
>  config RESET_TI_SCI
>  	tristate "TI System Control Interface (TI-SCI) reset driver"
> -	depends on TI_SCI_PROTOCOL || COMPILE_TEST
> +	depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
>  	help
>  	  This enables the reset driver support over TI System Control Interface
>  	  available on some new TI's SoCs. If you wish to use reset resources

Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D