Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Korsgaard <peter@korsgaard.com>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc:     <vkoul@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <michal.simek@xilinx.com>,
        <m.tretter@pengutronix.de>, <harini.katakam@amd.com>,
        <dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <git@amd.com>
Subject: Re: [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width
 required property
References: <1667448757-7001-1-git-send-email-radhey.shyam.pandey@amd.com>
Date:   Thu, 03 Nov 2022 08:02:00 +0100
In-Reply-To: <1667448757-7001-1-git-send-email-radhey.shyam.pandey@amd.com>
        (Radhey Shyam Pandey's message of "Thu, 3 Nov 2022 09:42:37 +0530")
Message-ID: <87fsf0r05z.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>>>>> "Radhey" == Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> writes:

 > xlnx,bus-width is a required property. In yaml conversion somehow
 > it got missed out. Bring it back and mention it in required list.
 > Also add Harini and myself to the maintainer list.

 > Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
 > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
 > ---
 >  .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml    | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > index c0a1408b12ec..a10019d3a650 100644
 > --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
 > @@ -13,6 +13,8 @@ description: |
 
 >  maintainers:
 >    - Michael Tretter <m.tretter@pengutronix.de>
 > +  - Harini Katakam <harini.katakam@amd.com>
 > +  - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

That should ideally be in a separate patch.


 >  allOf:
 >    - $ref: "../dma-controller.yaml#"
 > @@ -65,6 +67,7 @@ required:
 >    - interrupts
 >    - clocks
 >    - clock-names
 > +  - xlnx,bus-width

Reviewed-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard