Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1102685rwi; Thu, 3 Nov 2022 00:40:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7FDAwZjbe9sKUjKZTn5M3AbVejuvGmOMiZGKpFLTO20cYDOomABrrx/A2ew+yWkAdBkKOm X-Received: by 2002:a17:902:e5cb:b0:187:2d8c:a518 with SMTP id u11-20020a170902e5cb00b001872d8ca518mr16201743plf.132.1667461228835; Thu, 03 Nov 2022 00:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667461228; cv=none; d=google.com; s=arc-20160816; b=XNFUqCaqvOVsHSRYlbH0pu7uHI/czwGjkbdv7pFLDGCb0FLocJyGCsqun/QwNfyUav sLlyCRuAN7a5Isyxv3FE9j9n6DGUjkvhM8dkb/FbKAgu8gzOCzm3mnwF1dgVtJt/4diK Dy/iJQ1Ti14Gs7h6/fxRl9nSFDAfE7H6bomnAQOAcjVNY5UZZoyXaj0SvBPiZEFA0PmR kAA5p0167CupBNsQ8tvsDZWMJ9XzZbJ2qlRiYLXAl5NKqLdWFJLfSz6IFMuNdNkfvqpY KBfqWe40fbziaajNOFf5gPFNKgBfR0UxOkkPJ5JLedrx5EX1xhgIjfCahe+D/YVWgW4L iK8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=ZaXYFmLXWsMi7kNj6g7178734pMvEJ6Lz2L2Bc9KYcM=; b=VM76ZCjA2LqQpCiacrbGZigfhAJJaAYuxO8sQAaIrX+9sqxmuTupODpCLqzWw/AFuj DmKobJ01RjZ/Vb5cd+w4db44q31JSa1fPeLVoGYMwPfM5ycQY76Fm3T+GkpxE9iN0X9n YllUmw5FEDpEwBi1mjzj3IV0KfKRZYk0T1K3WT62bPhmRaM/3sV1eky3wQlldOdU45A+ eJx/pxhTe1pLnuqqBVIwjx23eZWsYtqYlDCTcjIZnUGbVK94Y0AM5BoEdGBOoBlN3IlO LMUL45YBj5Ec/UM1lfimOmvgHDZMk/7bDoTYbF7hNW/hb6Ek6ALOKdlwoxaUM9vaOpHM A+Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=oqfbGD+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a170902ebc500b001869b988da6si18266956plg.402.2022.11.03.00.40.16; Thu, 03 Nov 2022 00:40:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=oqfbGD+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiKCH12 (ORCPT + 97 others); Thu, 3 Nov 2022 03:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbiKCH1X (ORCPT ); Thu, 3 Nov 2022 03:27:23 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B444FCC for ; Thu, 3 Nov 2022 00:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667460435; bh=ZaXYFmLXWsMi7kNj6g7178734pMvEJ6Lz2L2Bc9KYcM=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; b=oqfbGD+rxr+PEFg/GEJZnPD/0zKapH+9fiLLfzPpGNYpBcn0PY3fKHVyEKw66laHv Qwo539L5SGqS3vn8eevb8RyUixVAGQy/QUH2u2b52+/Le+BsAn+eYJLHd9ZrYWdjzW TFKpvF+fDXElxWlJ1Xc7W+l5rHGFBuFP49SwOkKU= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Thu, 3 Nov 2022 08:27:15 +0100 (CET) X-EA-Auth: 1C2lZXt0cX05DonxAPqvbQLj2ZH3ORBoy6pOP51zkhWHzVKWGt62eo4hwELyz8uFeNvyCwvQ5Qj2/hYRbbPz4VyQZ7/LoXqC Date: Thu, 3 Nov 2022 12:57:09 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: staging: emxx_udc question on i_write_length datatype Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, While reviewing this [1] coccicheck warning, I observed something that concerned me. The variable i_write_length is declared to be of u32 type. Later it is assigned a value DMA_MAX_COUNT * mpkt; which is 256 * u32; I am unable to estimate if mpkt (or max packet size) can attain value greater than 16777215 in which case the result will overflow the 32 bits of i_write_length. Is it safe to make i_write_length to be a u64? [1] drivers/staging/emxx_udc/emxx_udc.c:1007:28-29: WARNING opportunity for min()