Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea7fba87-6132-5f05-6c1c-7afc8d576b89@intel.com>
Date:   Thu, 3 Nov 2022 09:08:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.1
Subject: Re: [PATCH] perf tools: exclude the include/perf/ directory
To:     Donglin Peng <dolinux.peng@gmail.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        peterz@infradead.org
References: <20221103040321.56233-1-dolinux.peng@gmail.com>
Content-Language: en-US
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20221103040321.56233-1-dolinux.peng@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/11/22 06:03, Donglin Peng wrote:
> Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
> source tree") moved perf_dlfilters.h to the include/perf/ directory
> without updating the .gitignore file, causing new files in the
> include/perf/ directory will be ignored.

Note:

include/perf is ignored because it has 'perf' in the name

Can check:

 Before:
 $ touch tools/perf/include/perf/junk
 $ git status | grep junk
 $ git check-ignore -v tools/perf/include/perf/junk
 tools/perf/.gitignore:6:perf    tools/perf/include/perf/junk

 After:
 $ git status | grep junk
         tools/perf/include/perf/junk
 $ git check-ignore -v tools/perf/include/perf/junk

> 
> Add !include/perf/ to perf's .gitignore file.
> 
> Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  tools/perf/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index a653311d9693..fd7a6ff9e7aa 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -4,6 +4,7 @@ PERF-GUI-VARS
>  PERF-VERSION-FILE
>  FEATURE-DUMP
>  perf
> +!include/perf/
>  perf-read-vdso32
>  perf-read-vdsox32
>  perf-help