Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32e8a0a7-7364-bb8a-2e5b-919b25f54905@intel.com>
Date:   Thu, 3 Nov 2022 01:21:09 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 00/14] IFS multi test image support and misc changes
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-1-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTFtWlRrNmNxTmhaQ0ZxeGZhREpZMDQzck5mSlMvWUJkMmVtY1VMMXRQTy9Z?=
 =?utf-8?B?amdIcGo1TFB3MVZIaTZScGtOa1BvYjVoRndHc3Npek5mb0Y2RVVTUDhtZ2xt?=
 =?utf-8?B?QTBObmhlYi91SlJYL1RPdUhObGcvQ29pdFFkWFk2Z3hRUjJRaGMrZ3JYT3gy?=
 =?utf-8?B?VXBhSUk1VUxCS0xWNEJ3NU10dnlMTkkvelgzUnEyeS9SbWtwcElsbURseCtJ?=
 =?utf-8?B?bUlpWFV0WFphVjhDeFhnMGs4RlVibWFHZnE1L3JrcUZXVXBHTXNqdXNOQXNE?=
 =?utf-8?B?Z3ZadTYrODZZWHdtelhpZTNkTlJCa2ZEL29xcHhHY05tYk5SM2dFRlluSVdk?=
 =?utf-8?B?ajZUdFlDbUtvK3plV01LZHpURWhMamptUitseXExK3hwTnhMNDdVRXY5R2ZH?=
 =?utf-8?B?Qm02M0VLOFUxbXY3Rk1JK25wcDEwcW9GOCtmenp5UlV5UktmT05xU0VPdHl5?=
 =?utf-8?B?dTNIM00vaUcxRXlaWjFhNUsySlRQRkl3ZWkxZEs2K1BXa1h1ek1tOEh0bXZs?=
 =?utf-8?B?Zys0eHVydWMwTmxNNlllQkhFQmN2UDFkU0xmZmxDaTZleEc1NXhHYXZRaVk3?=
 =?utf-8?B?a3RoMGRPR1lvbXU0cjUrMEl1VnFjWTVZL09lb2I5SDU2WTIxeXJZUmo1Q2Zz?=
 =?utf-8?B?UUlkNkxqWHFjeG9aaU50WW8rV2Z5NXA4Snk4UkFCV2hQQU9RVjZYREo3VFAz?=
 =?utf-8?B?cExML1JsbFJxaEVwOG5MVkhoVEljWW5pRW45dGQzQUliN09IZ05TK2owa05i?=
 =?utf-8?B?K2dPcXUwOEk2WWxDUHJSbndWbW1XNzhCb3B3VTVaVkJrVkd1LzYxdWJlMHNV?=
 =?utf-8?B?dW02T1N1Y09QV2hjOTVJd2RvZTNrbjlsSHZMdkR4Ny9WaUdHWkc0WCtKZjhm?=
 =?utf-8?B?MmY0OXN2RG9GSVlxRjJBcWZpeE4zMVMySWpXSXQ4K0VFTmJIdTlQVVM2cjFE?=
 =?utf-8?B?L0VtL05NdmVZSWVjK1BCUzBOamgrZ2tVa1d4ZUxWY01adndRQUZrTXJBRHdY?=
 =?utf-8?B?aStNSkVDL0ZqK3RIS2FlZlFTdm13QVZzaUFrTTJLQ1RSZktFZnczcEhjM1ls?=
 =?utf-8?B?alY5bGIxSGNJRGV0RTcwai9kZ25sa3U1M0RnWEhwTm1nbE9seFo3cHlOaW4x?=
 =?utf-8?B?RVVQbkFYdTlMaUt5QUpEcmhxRXQyTXh5UlV6MkVZYWxhOWNRWWdVdThhc3ZR?=
 =?utf-8?B?OEl5ZFEzbm1Jc3E5a2JiRnNQckRsNDFZL0pxS3NyZ0w1TlpsVXBHY1BoSWJx?=
 =?utf-8?B?dU9pSFdWUXFCZmVwaGFVQmpCaFJYZ0ZNR0IwQ3BZenFwRk5JdTBoMXg4Yk5Y?=
 =?utf-8?B?U1IwRkQvWU1FMnBZR2t3V044dVRmOU5MeFd4NjZ3VUJWbk5TN1VXRCtPNTd1?=
 =?utf-8?B?ZFBCbjVyT0NTNjIrNGJFRThqWW45endpbmtUZjF3ZVduT01YSUJGUnN4aUIz?=
 =?utf-8?B?YUxTcWFDVkRrdXJLNnVxbHJFSlZZd0E0MjhxQ21mUmJIWHNMeU05VFhiZDFa?=
 =?utf-8?B?V0x4QW5pUVhhVHdkSCtEYVloS3lPcmVEYnIyWjB3dy9GQ0RDbHkySENsTTFh?=
 =?utf-8?B?eDNMQjd5UUJ3TUl2RjdWL3JmeVVRaU9ocEJFc2JUN0dPcVJaeWphenlWSk5n?=
 =?utf-8?B?SWYrWUUzN21uVEx5dU16QjVkRlVFUnpyb0VpUE5qdWlBRXoxVzhyVzhxL1N4?=
 =?utf-8?B?azg5Y2kxVFViT3Q2OW01VVJPL2x2R2NtSTN2NkVvaEpKS1lQZ1RmVkhhVS9o?=
 =?utf-8?B?d2JzS0JRblM3UVo3VWFzNUt2ekQrSmlOcW9iNzNHRlJzdkhHNzN4SGtjaG9P?=
 =?utf-8?B?dUQrUWgrYlJobkJ4WUhMbCtvWDVzYkdYaktCK2JReHdlY3lFbmVKMG5xdGdJ?=
 =?utf-8?B?TEdmYmQzeFdNaGlzZC9QeWMrYVZWZDlzNmZ5bkJrcXFJaGJmb0JOSTF4ZXha?=
 =?utf-8?B?VDE5NkRpQWZ0eFJJaGZUNTF2TXk0aHZwVFViRXpnSWJ2L1FBcXBvWHVRaWlZ?=
 =?utf-8?B?QXBON2xOc2czKzNKQkdGakI0RWJMNTdyam41UDVjM0RUOVowNDZTOU1jbEFB?=
 =?utf-8?B?VnBmNjFmRU5CQ1VyTU9FdkwzVW9Xb1F0WjRtMDAxdXV1Y3lBSk1YMGFVSkhu?=
 =?utf-8?Q?8hgUinfoM9a4R7m34lwge4MlM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d52f0625-3429-4ba6-7773-08dabd745dc6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 08:21:11.4740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: men1+B0qJK4Y8s9eFVtD5O9V6wUb9tEGqAEKo3r4ZtYsjflKUtcXtSeL7GyoojHmayTD7WzggshZ4b7aMMGbAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6185
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jithu,

On 10/21/2022 1:33 PM, Jithu Joseph wrote:

> This series makes the driver aware of multiple scan test image files,
> modifies IFS test image file headers to make it fully compatible
> with microcode headers and adds a few other bug fixes and changes.
> 

I am done with my review comments. In general, the patches look OK to me 
apart from the minor changes that we discussed.

(If some of my suggestions seem out of scope for this series then maybe 
you can follow-up with a separate patch later to avoid complicating this 
series.)

Thanks,
Sohil