Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0cbbe205-4573-2dce-14bf-f07c117ac7af@amd.com>
Date:   Thu, 3 Nov 2022 08:55:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] mm/memremap.c: map FS_DAX device memory as decrypted
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        dan.j.williams@intel.com, thomas.lendacky@amd.com
References: <20221102160728.3184016-1-pankaj.gupta@amd.com>
 <20221102130536.96c487d341544b7482eed038@linux-foundation.org>
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
In-Reply-To: <20221102130536.96c487d341544b7482eed038@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWs4VGlWN25IN0hiTDJIaFJmTFNYRWwrY1Q1blVmVks2UGhTanZKTVJaRzVW?=
 =?utf-8?B?akFxMEtzSnMwSklmOGdLaVdkWlh3aUFIcmhlcVFYTEYxSkhkZjNFTTFOMi9z?=
 =?utf-8?B?bTZwWGtWUXF0dU1oWml5dnJCNUE3YVZBeEcwRU5DbGs4OHBNRmd3K1FGekxW?=
 =?utf-8?B?a2F1aEZOc0k0VVRNUzc2aUhWWHZCcmRNYy95VklHVlFTVlZSUmRaUGxxV0tM?=
 =?utf-8?B?aDJnWjFJOWUxUXE3VnlqbHVyMTV6dzRodnVBWUpBNFNCeW5kektjTTZpZC84?=
 =?utf-8?B?SEhRN1FiRkQ4NXZwQ0dhdTFidFIzVGhNdjJCVFdmeHVXZ2NDK1ljbURvdkZh?=
 =?utf-8?B?YWl2ZjJUQXloQndnVVZqVXRXRGVQTEdoNDdiQ00vcHp6R1d3WlJpUHd5b0Zy?=
 =?utf-8?B?WXlvc29pQkpNUzR1ZHhrR1pkOTRGRExreXZrV2RZb1BIMlQ4L1Q2Rzlyb2I4?=
 =?utf-8?B?ODhmRDRpY1BtSUo2TTE3bnUrVG5VRTRtM0pLSk5VU0Q0VklGbDBjZy82Q0Nn?=
 =?utf-8?B?MXRaOXZ0bFlrWDFwTmJheE54TlN6dURONUR2SEpDM2M5NGo1TjlYNHo2Snh3?=
 =?utf-8?B?RFZhaXM3N0xNVnpvVmY1ZFlJTVVGYmNRcGYzWFkwSmtDVXBCQ3hER05NbVph?=
 =?utf-8?B?SUFoZWZMcFh3N3Y1L1ZQRldISkZ1NXpTcm40dFFsUnVqVThuV0wyclRFNzJ1?=
 =?utf-8?B?NWROa0Q5VUlWSlVLMFc0QnVzaW9VdjJMVXRLWWxQSUpiOWQ2czY2VXZZbzZF?=
 =?utf-8?B?cThpbnVMZk4zbVlHSzJ6bGVXbWJOSVozRkRWWVZpa1FEdEVKajNrOVdqZElu?=
 =?utf-8?B?dmJReGlHZ2FOeTZ2dkw0QlFwV2V4SXVRclpwQW90cyt0OGJPSzFtUUNIVTgy?=
 =?utf-8?B?ODk5akpRRzBlTU0yNVQxNkQvcVFWcE5jandicXNSU0llT1JqK3hJUllJTnpX?=
 =?utf-8?B?ZWhYend0emRVeE5qQTNpNUxCSFNiTi93Zm5mNGh2bDEwaVJCcTdnVlRwVmJR?=
 =?utf-8?B?RXB0S210NEdicmVQay8wMytRZ2FwRVR5RjIyV3dWYU90NnQzSHduRDZEek9D?=
 =?utf-8?B?LzFTSUlndFRTTHZzUkllZFduNmhGdGNvSk1lR1crTk5WaVJHNnBXSFFDYVJC?=
 =?utf-8?B?eVdEbHdqZ0JpR2llZ085WUdXQ2RJU3A4bG5ndVZIWVBEWU5PcXJGaXlOQ0Vv?=
 =?utf-8?B?d0d6TDJtSFpNUXlqakpsL0YyZi9lNFZXaTBneElJN0RQUlI3RmdRb2I2Tnln?=
 =?utf-8?B?cURvQkVBYWlzMytwRU8veU01VjRpTWpCWjRvdlU5T0JJLzZmN2dPQ1VKaW5z?=
 =?utf-8?B?MXpoNW1JSEptaFZPbTNPME9yb0t1bjd2czU1Q0FMa3R3SlRhaVRSSWZrQ0Na?=
 =?utf-8?B?L1hYMVRybzd1RTNCeWxDSDhaVWJFaG15VXYybVhMQmowOHNMRTBnOS9QcS9Y?=
 =?utf-8?B?cTNuendibnpNQU5xYVRuY0I5M2lvUTdXbVVxWnA4TUxRQ3BQQzhReEozZ1FU?=
 =?utf-8?B?ZGpCVzZEY0VobWY2TWdEbkdlSVZuMXlHd1hTRzNlanloSnZCR25IcENIandv?=
 =?utf-8?B?QXFqeTc0TUFMN3dlOFJVSFNNTDhFWjkxRTNRU1RxSVZyWGdoVmtjNVlydnAv?=
 =?utf-8?B?djJvdXl2UmJCRjl2cTZ3TDNTUjFPMnRJWjc2R25kMnlKa0dPRTVXN3hKM1VQ?=
 =?utf-8?B?L3c4cWxzZnh5RnpjVFVyazVzcXVaVjVuUUFtN2t0YzlUMUJsTXVLaEY5a0U4?=
 =?utf-8?B?QUYzNXZWRWFxcjdUMm4wY1BpelJuYzhVTDl0TzhUVFVPRFFkTVRmRzdpWFpF?=
 =?utf-8?B?Z2dVUWlSOXJ6YlpYYWlBT0hvbGduSmxXWDZHeVpaT29iemZsNmVmNktqYklS?=
 =?utf-8?B?dnNjUlo0Yi9CQWNjdWJqZm9kbE5qYkk0bENVWjNMVnptSFMrZzhKelVkbUZa?=
 =?utf-8?B?eDBra3c4Y2JZZXFmR3pyYU9RVEgzNExBbG5ZRGRCaFNqTFhxSzVnQndtMlI5?=
 =?utf-8?B?UlJhZW9JWXRVbG9yRWFnZDl0WXoxRUJ3U1BEdWx4S3lZUU5WNzNJTllOSi90?=
 =?utf-8?B?SGxuN2cxQXpKd3pQUlh2Wk0zYWhnYVhWdklsS1o4VERCb0tsRkdPTzQ4aDds?=
 =?utf-8?Q?qLwifmsqxYfM1eIOHb/LclvQI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b74be5dd-2164-47a1-c72d-08dabd70d0d9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 07:55:46.6766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oxrPKjiIYbDs669AT9jwkMeeanYiwfffRWc48lAsDpD6Bo4JJBfzNCpo627hwoCGJHuu91tYsR40cb0FpMg78A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5235
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

>> virtio_pmem use devm_memremap_pages() to map the device memory.
>> By default this memory is mapped as encrypted with SEV. Guest
>> reboot changes the current encryption key and guest no longer
>> properly decrypts the FSDAX device meta data.
>>
>> Mark the corresponding device memory region for FSDAX devices
>> (mapped with memremap_pages) as decrypted to retain the persistent
>> memory property.
>>
>> ...
>>
>> --- a/mm/memremap.c
>> +++ b/mm/memremap.c
>> @@ -335,6 +335,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
>>   			WARN(1, "File system DAX not supported\n");
>>   			return ERR_PTR(-EINVAL);
>>   		}
>> +		params.pgprot = pgprot_decrypted(params.pgprot);
>>   		break;
>>   	case MEMORY_DEVICE_GENERIC:
>>   		break;
> 
> Should this be backported into earlier kernels?

Yes, kernel >= 5.10 for clean back-port as it contains the below commit.

> 
> Is b7b3c01b19159 a suitable Fixes: target?

Not very sure. But seems like the right commit for fixes tag as the 
target code is moved in this commit with multiple range support addition.

Should I send a v2 with fixes & stable kernel fixes tag?

Thanks,
Pankaj