Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] uapi: Add missing linux/stddef.h header file to in.h
To:     Paolo Abeni <pabeni@redhat.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <keescook@chromium.org>,
        <gustavoars@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        <acme@kernel.org>
References: <20221031095517.100297-1-yangjihong1@huawei.com>
 <477a37b80b01d5eaa895effa20df29bcf02f65b6.camel@redhat.com>
From:   Yang Jihong <yangjihong1@huawei.com>
Message-ID: <300b547d-8ea5-d7d1-f39e-d55df73847cd@huawei.com>
Date:   Thu, 3 Nov 2022 16:59:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <477a37b80b01d5eaa895effa20df29bcf02f65b6.camel@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Paolo,

On 2022/11/3 16:25, Paolo Abeni wrote:
> On Mon, 2022-10-31 at 17:55 +0800, Yang Jihong wrote:
>> commit 5854a09b4957 ("net/ipv4: Use __DECLARE_FLEX_ARRAY() helper") does not
>> include "linux/stddef.h" header file, and tools headers update linux/in.h copy,
>> BPF prog fails to be compiled:
>>
>>      CLNG-BPF [test_maps] bpf_flow.bpf.o
>>      CLNG-BPF [test_maps] cgroup_skb_sk_lookup_kern.bpf.o
>>    In file included from progs/cgroup_skb_sk_lookup_kern.c:9:
>>    /root/linux/tools/include/uapi/linux/in.h:199:3: error: type name requires a specifier or qualifier
>>                    __DECLARE_FLEX_ARRAY(__be32, imsf_slist_flex);
>>                    ^
>>    /root/linux/tools/include/uapi/linux/in.h:199:32: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
>>                    __DECLARE_FLEX_ARRAY(__be32, imsf_slist_flex);
>>                                                 ^
>>    2 errors generated.
>>
>> To maintain consistency, add missing header file to kernel.
>> Fixes: 5854a09b4957 ("net/ipv4: Use __DECLARE_FLEX_ARRAY() helper")
>>
>> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> 
> The 'Fixes' tag must be separated by the commit message by a blank
> line, and you need to remove the empty line between 'Fixes' and SoB.
> 
> Additionally, on repost, please specify the target tree in the patch
> subj, and wrap the commit message text to 75 chars per line (that does
> not apply to the build output).
> 
OK, will fix these issues in the next version, thanks for your advice.


Thanks,
Yang
> Thanks,
> 
> Paolo
> 
> 
> .
>