Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CABDcava8ADBNrVNh+7A2jG-LgEipcapU8dVh8p+jX-D4kgfzRg@mail.gmail.com>
 <CABDcava_0n2-WdyW6xO-18hTPNLpdnGVGoMY4QtPhnEVYT90-w@mail.gmail.com> <Y2MFe1pRdH35fxU8@bombadil.infradead.org>
In-Reply-To: <Y2MFe1pRdH35fxU8@bombadil.infradead.org>
From:   Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
Date:   Thu, 3 Nov 2022 09:22:35 +0100
Message-ID: <CABDcavbv5=54Hv4_TRgAiQK9fvXHbpy3O288Lc5pfO2Q+8Y=SA@mail.gmail.com>
Subject: Re: fs: layered device driver to write to evdev
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

El jue, 3 nov 2022 a las 1:04, Luis Chamberlain (<mcgrof@kernel.org>) escri=
bi=C3=B3:
>
> On Wed, Nov 02, 2022 at 02:14:24PM +0100, Guillermo Rodriguez Garcia wrot=
e:
> > I understand that device drivers should implement ->write_iter if they
> > need to be written from kernel space, but evdev does not support this.
> > What is the recommended way to have a layered device driver that can
> > talk to evdev ?
>
> Shouldn't just writing write_iter support make this work?

If I understand correctly, supporting both write and write_iter is not
allowed [1]:

"If a file has both the regular ->read/->write methods and the iter
variants those could have different semantics for messed up enough
drivers.  Also fails the kernel access to them in that case."

 [1]: https://lore.kernel.org/all/20200817073212.830069-3-hch@lst.de/

Thanks,

Guillermo Rodriguez Garcia
guille.rodriguez@gmail.com