Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1224682rwi; Thu, 3 Nov 2022 02:42:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5fnddKvQ7dJ1gOTBjBYavQL92KTOOCFYLYnQYnfYiFbp0sPPz47NiSw14OcyUryGDEXXup X-Received: by 2002:a05:6a00:1348:b0:56b:f5c0:1d9d with SMTP id k8-20020a056a00134800b0056bf5c01d9dmr29438676pfu.45.1667468565936; Thu, 03 Nov 2022 02:42:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667468565; cv=none; d=google.com; s=arc-20160816; b=UWm21ryrm0/V1Ijx3Q0TRsmSio5PKMnbaaDScFsffgqHVitQUTRkaXQNapsmUi/Oqi 3skKt9ZqPGD7xwSB4Oyr+4+oJSt/erakTvGSWaK4aqjAQ8PhgVij/nnmBun4g6HWoRkR NIHyui6Wggwx7CsHfBD2X1FMEFOFaYpHH3okkztTgm1Qd7lfLF9fftcOv03no6zuMnF6 86QgjgHvyD/X9cmPHiRLOLotJWysoiUgdW3/L+CAHooNC1RJb4yHKD2AYzI+Th7W9Ro+ J4kS0Koid6miEPWZgHTHzrGs7bq6vDB2r/2RqWuZQDS97Ek/SMx1dkPaT1TWSHT71IN3 6yDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rEQaoZvjRMsJ4e/mV6mD21ZtiZswBVNuNIWwQ2LBDZg=; b=E8V2hFFnok1rRd8eSy85ESfYKFo90T6L/gsyGRt65kbgIA2MkHeLZUOnp0RHukM0pU 0rz/TDy4fULVwwv2LyjIdUbI7olt5p0cSBEwmTr6zTJFSWgbfhWov5Wpu0y9PZ4FKEvB qtCxNE+84N9tU1T+2E6d3Rh4Iwx1VEZ97TAf7yQWYCRaowCqcssgvVzKewrqcp9FLmxA uB8WJUNMCLfCPrWe4wyROBeO3JjKt4Fxum27yyiq+k33yr6gaPsPUeEHnBT4xHBcLJuI kEVRYM5IoD0yfz3yI57n4lwW8CeyijzigO2BLa6TUlGPishc4Vn+Vz7hBxfzzsyckwe/ /xrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bVVcWIYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l25-20020a635b59000000b0046f73d846f3si442644pgm.441.2022.11.03.02.42.32; Thu, 03 Nov 2022 02:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bVVcWIYm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230005AbiKCJhs (ORCPT + 98 others); Thu, 3 Nov 2022 05:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiKCJhp (ORCPT ); Thu, 3 Nov 2022 05:37:45 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C1762AD3; Thu, 3 Nov 2022 02:37:45 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id 129so1500621ybb.12; Thu, 03 Nov 2022 02:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rEQaoZvjRMsJ4e/mV6mD21ZtiZswBVNuNIWwQ2LBDZg=; b=bVVcWIYmbU9WsKE1HYi8uk3fZqESbYCzHy7/i8i1qKDWZ5fmB+bzyRx140gNkqvwwv c66WPry7a35/iAh/HdoNfHErwFUIjdefyMI8f78kLzrojEktkcIRxx8XJ5q17BD9kj2t vLaUYepgxP+0/pCcn8ZzXDnnNNVdPmeK60rfgHbK+ru2F9yeCG2QTyVRjTLrcNOCCDbc vRVBD2qz7glLT0S1Hl5sUdRZVK2v3JpqtmM/4G125vPmdyFFQawUo5ODhjdElEzQ7fo7 y1GyM+fOMIGBjjX77ufMKckS4LjpK28l6F2yMh5JuDMvGC52pembXCyv6F0EIu2Xn0Q9 SNmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rEQaoZvjRMsJ4e/mV6mD21ZtiZswBVNuNIWwQ2LBDZg=; b=a59XpDn0n17UQBLnNlVCiYBWcLqjrLWeEV0quEp1dRTqnY8JaRx/MZqGIQlEPuNZKQ 24BfUpvo+rFkzWnIC34UCZSJAWPPeNKaLfLbtS1gXN8NaLZ+RtMA4KxCeQQuv01qwYrb gpDnea57vD+u2d6qLbS/4dKkLXhsVnktWjMoHdshvdVzZZvpavwGKgBGKBW56Y925Uac vVuBauyqGnfWTA/x+xIKVabk377PrV1pP++jEJWoFrFaRYCHfXjUBpspsusfD73+2Ioa +LOShpt8MbY69cIccCIta4c7n3wyiPZ63i+9iIeHUmWhhla5xDk+NlBj6zGSM1d8MLx4 mmVQ== X-Gm-Message-State: ACrzQf1hs1+cR85KtZ7p+9ZqjQ1ScHmw4UaQNk/J5rYHaJNhuvt0s1cc xIMb7MXc7i5Hu7zshNx3a9k/E52Po6lvGlL6Kyw= X-Received: by 2002:a25:76c2:0:b0:6ca:6604:4928 with SMTP id r185-20020a2576c2000000b006ca66044928mr27520549ybc.323.1667468264527; Thu, 03 Nov 2022 02:37:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Miguel Ojeda Date: Thu, 3 Nov 2022 10:37:33 +0100 Message-ID: Subject: Re: rust nvme driver: potential sleep-in-atomic-context To: Dennis Dai Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Wedson Almeida Filho , Andreas Hindborg Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 3, 2022 at 7:12 AM Dennis Dai wrote: > > The rust nvme driver [1] (which is still pending to be merged into > mainline [2]) has a potential sleep-in-atomic-context bug. > > dev.queues.lock().io.try_reserve(nr_io_queues as _)?; Cc'ing Andreas and fixing Wedson's email. Note that this was written when it wasn't decided how the `try_*` methods would know about the flags. Cheers, Miguel