Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1256485rwi; Thu, 3 Nov 2022 03:09:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CBBSqc+KB8YP373b7oNig9JL/XDKQ4McG9x6qEkS0KwGpIsSfvAxPB9AC4NqfWOm32Lbz X-Received: by 2002:a17:907:6d8a:b0:7ad:d3a1:cbf6 with SMTP id sb10-20020a1709076d8a00b007add3a1cbf6mr18480222ejc.533.1667470175338; Thu, 03 Nov 2022 03:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667470175; cv=none; d=google.com; s=arc-20160816; b=UYaIyA1VeppChEre174JviPajHf1AWQp7qCS/7Ev+xrzOUEiuI9UGodHUPvVar7OeO bzNU3zFsFx6OX7r6zt/AYSEu9mI4rylb28UVY1Go05zs5895lbhqXOb2F442nzt0xwe0 H2IErtTT0cGeDZPVwXjkRsgpj8EOy4HHBe5PLU0A/1UhzspXPak12AlxRrG0EmQ1KY01 ulIHbUqRLFc/pcYUesbUflcEW/B2RcfoeNIbPdFQgR7xZ+X79okhyuD28qIJ2Q4+x3YP gT8rF43kX9Dq2JJyjkEOaSksPzbCRsCSqS+yst4Nf+lHogYGrPiOTQu9J5uGEecTUTrA L8GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=RCDDLb8W5nXjmPTYKqRfiGanGjF8/En+Mro9Pg4dZ7g=; b=wMiM2ORSWS/7KAFlaqkF+lWi9mKmuDt/MfNJt36KANKqUSbTedd094QS/HO2dlLOIB gbFUIWH8/UnftT7yV5a9iUNVR9Pkz2K0vCNy8bjkZuGxxCsbeUj98nRzgOoC7tq6rk6/ UEgXvbu/poBeqiqI/zau/qlt1LVaHj/IgKwP9Tsbmk8LIRwKy75Tnq/czZKeyC7+mJ/n V1ne880pfqLGb4qjBzUwxfGl+y96VSy/e6czqhl0v8Au1OxbFWwJmkIfssweKN5cywEJ 3/tx1mPHbY9N/qM7/h8I/t6tbX0/dyCkpbkbA4O2gcbqGxNoO31Ks08bfDg1NnjBe+iH HHOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho42-20020a1709070eaa00b0078ae5192906si977004ejc.193.2022.11.03.03.09.11; Thu, 03 Nov 2022 03:09:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbiKCJ5K (ORCPT + 97 others); Thu, 3 Nov 2022 05:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbiKCJ5I (ORCPT ); Thu, 3 Nov 2022 05:57:08 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4A89596; Thu, 3 Nov 2022 02:57:07 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4CC2268AA6; Thu, 3 Nov 2022 10:57:03 +0100 (CET) Date: Thu, 3 Nov 2022 10:57:02 +0100 From: Christoph Hellwig To: Yu Kuai Cc: Christoph Hellwig , axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, "yukuai (C)" Subject: Re: [PATCH 2/2] block: fix use after free for bd_holder_dir Message-ID: <20221103095702.GA11154@lst.de> References: <20221103025541.1875809-1-yukuai1@huaweicloud.com> <20221103025541.1875809-3-yukuai1@huaweicloud.com> <20221103081211.GB3346@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 05:45:25PM +0800, Yu Kuai wrote: > This lock is different from current 'out_unlock', add a new lable will > make the code more complex, I think. Of course, same mistake as last time..