Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1269028rwi; Thu, 3 Nov 2022 03:20:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4KqkCo48PW0zoq1KAFQEyHzevarJXkXZjNeG5l/+83qiuZkT7IIEVodHMYPrU1BHHWLVwA X-Received: by 2002:a17:906:8442:b0:7ad:960b:ef61 with SMTP id e2-20020a170906844200b007ad960bef61mr28916591ejy.702.1667470811362; Thu, 03 Nov 2022 03:20:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667470811; cv=none; d=google.com; s=arc-20160816; b=r8qAsndGh3VwrIgMyS6bM/EhU+T28UJiHlJ41XfNYUm1T830tZYqPpJo55rn7+btXp PZUwAo4aSct05S/rdpdEngPde0qMs42ty2T5fBxHUg25LcpYN4lk6oqZW8GIioCCGlD6 wqD6roo220/9ViwtavRacd7FMDEIVbXLkiwoXRMknWoby6ZFZVqtfiRfYpDAqVdqp7oq ozyl+1YmpyWDAcNztHvkZksyjBjTa6vDQ6O2er8caAhWoL0p+CRwVEiZvj6XrOSaSIen B5C5GkZGkJbBTn2eRWdj2SIW9y3I2ypokrp2UKLTDZG5vEoa8xeCGcbEkWfviAYt/YDP FeSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mAFMlhBrnqdkVI9PXuWkqqbxF2DjPNvJ9IhFJvqdOVo=; b=P1FLdRJzDV6psXFBmTcl+9TvGq1TVyaAsY7MaSVDCubVPoAWBncNkAl+JDcc2U3R69 wg6Jux+SIIq1Q+xs2s5YL7u/zgSn+V6XKB3FjAWa9MoNbSO3lYfiWzmnFS4PKrOX5Etr 9M2jrtJ+A61izO6LxLO/1uI7deSq2G2EQeb5ZeF+tt93y3U5jijyldYY6SgYIaalW8nC YGJGhQXA1FqIDXTVTDnSGLwRV067JrWs/3J9VfLV+lbU2PUWkXW1HC+ReCw5yitvHMfN v9u4bRipfMmHbhpxzKOOH00pvkt9V45YbluFuMdnZNZ4M8+pPBxKZf5210sQcZ3jl2Dw nZ3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=h4Wz34UU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a056402254c00b00461f44d7bfcsi917448edb.573.2022.11.03.03.19.46; Thu, 03 Nov 2022 03:20:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=h4Wz34UU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbiKCJsB (ORCPT + 97 others); Thu, 3 Nov 2022 05:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiKCJrz (ORCPT ); Thu, 3 Nov 2022 05:47:55 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C81E000 for ; Thu, 3 Nov 2022 02:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667468857; bh=mAFMlhBrnqdkVI9PXuWkqqbxF2DjPNvJ9IhFJvqdOVo=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=h4Wz34UUxeJ8s6rpH8sXT0f8pKWEYqcefmbzOxGTIO9ZCZgidDnRjnJVXuialwvU5 2ayvNwhCJXYC4P6SYsMMoqMxJPKTk8zA1jEgyf7OWhZlIkc9/fOl9uBv14c8vleJWl 0NUL7GZ4bJqolqJUId8r2OCTH0cagdv57wXgIRLU= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Thu, 3 Nov 2022 10:47:36 +0100 (CET) X-EA-Auth: yTdpYMwEK5LwbRoruVtM0kM+WYm0pxaNZg8ri2b78h6/fZ/bX61SRRGztsAWjrODKklY4rIOgKodwmq59mpdNramcbircz2G Date: Thu, 3 Nov 2022 15:17:31 +0530 From: Deepak R Varma To: Philipp Hortmann Cc: outreachy@lists.linux.dev, Larry Finger , Phillip Potter , Pavel Skripkin , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: remove unused struct declarations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022 at 11:09:46PM +0100, Philipp Hortmann wrote: > On 11/2/22 21:53, Deepak R Varma wrote: > > Some structures are only declared but have not been used anywhere > > in the code. Remove such unused structs. Issue identified as part > > of coccicheck report driven code investigation. > > > > Tested-by: Philipp Hortmann # Edimax N150 Hello Philipp, Thank you for testing the changes. Request (not urgent): Can you please help me understand how do you test such changes? Do we need specific hardware for functional tests? Is there a documentation available to know more about the testing? I am interested in attaching a physical device to my machine and be able to debug and test the changes. Can you please provide details when you have time? Thank you in advance! ./drv >