Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1370857rwi; Thu, 3 Nov 2022 04:39:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6G4CptUmb+1l/BNnqY/DPNDpOxCsnhbW87dIkNfzSnlPKOqGz9Nhgn1/f41p+WByZf6X+z X-Received: by 2002:a63:ef18:0:b0:439:befc:d89c with SMTP id u24-20020a63ef18000000b00439befcd89cmr24719512pgh.504.1667475557089; Thu, 03 Nov 2022 04:39:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667475557; cv=none; d=google.com; s=arc-20160816; b=CBhU0DbUNBcW+9CMebL5thRpGq6wyNhg+iD49Jpnnl6HLW1COEnx4eUjFicvg4yrO2 11/hhohVtcNuv+w0HmdSS2NtrPTTCsofYdf9nqjy+SS4gzJZuWrosjMo0qQZ20ZGWV2Y yv0Nqxt16NEfqa5+jtraBv4hoLhRmr2ojgSBmtY3OzJh54fT2zkpeyqtpolfdLY9UEBL quI5faj1rNlQtITTKKnejERMkXU8qTyyd/xmlqDuNizQvMkdzXrPx4xA5oYAE87ObE9j BiCYsv2x3nnV/scMmn7EiTmYGej+esE6Lnidy2Ql7UoS0xa3POUn6RyJA3weNQJ1xTva n1kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=zZ+yk1r8RECgQMw6XvTREau6Abza/3EZqGa4CovKxIk=; b=p67xFbWs4gyPWJgOzndFgoWWMYixMP4mAfIRCBg5NP+kK3auA35IDzOM7qp8TjUBuz VpMLgrP3DrkNEll8M+1ng6/Pndbs5rTpjJ1H2A33Ssz4t/KFtia67yyaTwP9wFgfC+/D Vfp9NxQUWjz+HR08tH5DanzTsunytiZeEH3Pg8mvBlqguWspWOehzKaAr8pALSCT+31L /snWo4JDyuMMNDsVDT3HVioTdsGEdbchJ9S94oyRP/km8jbROUnoqDWIxI+X/2TGqpWO kyqLIoKx0hyAnV+4yOoca5uGS3InjChGfIiR7GRxD/c9Z7sm1vgwawLMcTDvmZf2bk8t 89/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a636b07000000b0045d1aa2a586si786767pgc.197.2022.11.03.04.39.03; Thu, 03 Nov 2022 04:39:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbiKCLEK (ORCPT + 98 others); Thu, 3 Nov 2022 07:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiKCLEE (ORCPT ); Thu, 3 Nov 2022 07:04:04 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389A76168; Thu, 3 Nov 2022 04:04:03 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1oqY0b-0001id-DU; Thu, 03 Nov 2022 12:03:41 +0100 Date: Thu, 3 Nov 2022 12:03:41 +0100 From: Florian Westphal To: Ziyang Xuan Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: nfnetlink: fix potential dead lock in nfnetlink_rcv_msg() Message-ID: <20221103110341.GA29268@breakpoint.cc> References: <20221103011202.2160107-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103011202.2160107-1-william.xuanziyang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ziyang Xuan wrote: > When type is NFNL_CB_MUTEX and -EAGAIN error occur in nfnetlink_rcv_msg(), > it does not execute nfnl_unlock(). That would trigger potential dead lock. > > Fixes: 50f2db9e368f ("netfilter: nfnetlink: consolidate callback types") Applied to nf:testing, thanks.