Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1387406rwi; Thu, 3 Nov 2022 04:53:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5pgpx0il7/UK+L5YqPVC4gZGrfjWjezNhzepy4cQv1XDWBZa65wgZhd8mVe65Ku22ms3Rz X-Received: by 2002:a65:5a4d:0:b0:470:250d:362b with SMTP id z13-20020a655a4d000000b00470250d362bmr1520264pgs.219.1667476384060; Thu, 03 Nov 2022 04:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667476384; cv=none; d=google.com; s=arc-20160816; b=wvXD5+Y/gQoaqtAZdYdS/wSCD7pLkfzUBVK1ldPKSVDq52DecF6CAZ+7o/oJlW0pph fZb8K5/IE3ankBnM4pB6+OGzFIYzh2skcLDMgVaZgEz9Y9deeV5/qoM1i7GlyqopIaS6 nBfed2KzXaPJyqbkQDkmPYh21eaqL5jdW1fodDFpfzIjD+KtTambW+JIdSAKSNFyxTYq VPWamIhysnGuQVqhlX1YW9L4q691fealZiXDZLYeIDG52JpH8X3i5i/SUgSBCRVdDTXh 2giWePHnwiB9wFjtiNZB3AVPyLQyQuxJBnNh0kChi7CNIH4u48UVR+FTNp6G8fYHCqz0 xqtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=OIjG3gW5sozQT8zn++K7D/l1oNeUmegF3woGpjfHlMk=; b=O2BnhUnh3JwDXt8a6YI3odDP4wRnfbV2ZnLNlxmqCXGqFuasrOprAi7OsDYYEiZ5KO bsf7g5zWNN7CTx74d6Rb8pSXtmBrgNqHaRGKezFhx+H6OtDHWJoHSmUwdL4SLYlHucDg RudRvNGE4wgbDbU+3hHJzXFPOBKWECurqwI7yo1/tSfMI+BbSwezwuPnc8L/rO14CoTh qZsZZYuNCH61BrUEgiv4EHkfkd/s01oNnbX0QDY6KXBxyQHX8tpf1oYLyHByILexicRw HOB5m7Y2qBMo3W5KCcMrX5auap+lua7EI4q3SF+Hb+3BuBS2/YLwB1UfUHqF9o7/SfXP Njzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a170903228400b0016f1eb1317esi570400plh.471.2022.11.03.04.52.51; Thu, 03 Nov 2022 04:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbiKCLl7 (ORCPT + 97 others); Thu, 3 Nov 2022 07:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbiKCLl5 (ORCPT ); Thu, 3 Nov 2022 07:41:57 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ECB51263F; Thu, 3 Nov 2022 04:41:56 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N320Y1jcMzmVcl; Thu, 3 Nov 2022 19:41:49 +0800 (CST) Received: from huawei.com (10.175.101.6) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 19:41:53 +0800 From: Lu Wei To: , , , , , , , , Subject: [patch net v4] tcp: prohibit TCP_REPAIR_OPTIONS if data was already sent Date: Thu, 3 Nov 2022 20:46:52 +0800 Message-ID: <20221103124652.260085-1-luwei32@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500015.china.huawei.com (7.221.188.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If setsockopt with option name of TCP_REPAIR_OPTIONS and opt_code of TCPOPT_SACK_PERM is called to enable sack after data is sent and dupacks are received , it will trigger a warning in function tcp_verify_left_out() as follows: ============================================ WARNING: CPU: 8 PID: 0 at net/ipv4/tcp_input.c:2132 tcp_timeout_mark_lost+0x154/0x160 tcp_enter_loss+0x2b/0x290 tcp_retransmit_timer+0x50b/0x640 tcp_write_timer_handler+0x1c8/0x340 tcp_write_timer+0xe5/0x140 call_timer_fn+0x3a/0x1b0 __run_timers.part.0+0x1bf/0x2d0 run_timer_softirq+0x43/0xb0 __do_softirq+0xfd/0x373 __irq_exit_rcu+0xf6/0x140 The warning is caused in the following steps: 1. a socket named socketA is created 2. socketA enters repair mode without build a connection 3. socketA calls connect() and its state is changed to TCP_ESTABLISHED directly 4. socketA leaves repair mode 5. socketA calls sendmsg() to send data, packets_out and sack_outs(dup ack receives) increase 6. socketA enters repair mode again 7. socketA calls setsockopt with TCPOPT_SACK_PERM to enable sack 8. retransmit timer expires, it calls tcp_timeout_mark_lost(), lost_out increases 9. sack_outs + lost_out > packets_out triggers since lost_out and sack_outs increase repeatly In function tcp_timeout_mark_lost(), tp->sacked_out will be cleared if Step7 not happen and the warning will not be triggered. As suggested by Denis and Eric, TCP_REPAIR_OPTIONS should be prohibited if data was already sent. So this patch checks tp->segs_out, only TCP_REPAIR_OPTIONS can be set only if tp->segs_out is 0. socket-tcp tests in CRIU has been tested as follows: $ sudo ./test/zdtm.py run -t zdtm/static/socket-tcp* --keep-going \ --ignore-taint socket-tcp* represent all socket-tcp tests in test/zdtm/static/. Fixes: b139ba4e90dc ("tcp: Repair connection-time negotiated parameters") Signed-off-by: Lu Wei --- v4: use tp->bytes_sent instead of tp->segs_out net/ipv4/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index ef14efa1fb70..54836a6b81d6 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -3647,7 +3647,7 @@ int do_tcp_setsockopt(struct sock *sk, int level, int optname, case TCP_REPAIR_OPTIONS: if (!tp->repair) err = -EINVAL; - else if (sk->sk_state == TCP_ESTABLISHED) + else if (sk->sk_state == TCP_ESTABLISHED && !tp->bytes_sent) err = tcp_repair_options_est(sk, optval, optlen); else err = -EPERM; -- 2.31.1