Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp1463829rwi; Thu, 3 Nov 2022 05:43:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM61BJAAONBU4HHERHsRjfeGhrwp+8q0t3nGmwgmHKG2ZhTLhviXZ0zmVjXpEmF+yZHel1Ml X-Received: by 2002:a63:595:0:b0:470:8b7:255a with SMTP id 143-20020a630595000000b0047008b7255amr7267821pgf.329.1667479424817; Thu, 03 Nov 2022 05:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667479424; cv=none; d=google.com; s=arc-20160816; b=QsdEnQHlIGlPa4jz4tJzwcLIN19VxqIqTqPwF80U9XyVRAeCLpydIBBDDLFQSrmYN3 L7m+K9Hr207KOfi7B1H4viIpwK8LbQzvaM1PPp/Khel6x37r1OEcY5E9F2OLp1yh8HtF oze8UuKCsJ6kXn1VXWs8l+RAW0nXlCp1s2qpftzRK3HJ0X3m7nrsZg69c1twG9ufcc2Q wgzxhZvXSESFr5iKLqz6YDQKqIEMeHvypxoofKpBx6i4ouG6v6aL6P4jMxN8iF0mzeNb ve/V6IbVGhhGSCXLmDjRApvrN2hwXXCUogWoAWIyDAjXtNmx3IWTGLjJOZEbdISOEuhG sSkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:to:subject :cc; bh=PT9m7nb80uf3cDFzZBIxKdm2MQUGwqxGeSmkRs7ZnWE=; b=aJHTFM1krJ4MNzkzamYr0IrQJpxc7noYqZ48cSInItH08d7QoPJnIqNgm2uiDH7EYZ PDWjDXbrm6RxnPWnVEZ+fR1n5AljSIrorhg8rc8mXXerFPDB4TqoK/n6Yds8f0WkFM1C 2xuIuKnnELZb5pp0hZqaf35bpvUcWpaTTEYQETld+VbLMGIqKrqH8L/MKfwrX7KMal/r klWr1nnzxkHLWOTS0ByeOJBp+VeNI0NydSIk30/C9nbkoHtQ27fTRcVtf6oIeTh5r989 z90T5uZGYPmTlcd+HMi+lZUq2cH2tyiELmjOuQK33GH0IaoKYoNJfVNcl7FJdQc5CDyo VxmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 195-20020a6217cc000000b005638dc03ab3si723335pfx.323.2022.11.03.05.43.30; Thu, 03 Nov 2022 05:43:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231757AbiKCMhf (ORCPT + 97 others); Thu, 3 Nov 2022 08:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbiKCMhH (ORCPT ); Thu, 3 Nov 2022 08:37:07 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C379014036; Thu, 3 Nov 2022 05:36:58 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N33822hZFzpW8Y; Thu, 3 Nov 2022 20:33:22 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 20:36:56 +0800 CC: , , , , , , , , Subject: Re: [PATCH next v3 2/2] dt-bindings: gpio: add entry for hisilicon,ascend910-gpio To: Weilong Chen , References: <20221101082442.263448-1-chenweilong@huawei.com> <20221101082442.263448-2-chenweilong@huawei.com> From: Yicong Yang Message-ID: <322c65cf-2b89-a73c-ba7e-983ac8fb8b3e@huawei.com> Date: Thu, 3 Nov 2022 20:36:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20221101082442.263448-2-chenweilong@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/1 16:24, Weilong Chen wrote: > Add the new compatible for HiSilicon gpio controller driver. > > Signed-off-by: Weilong Chen Looks good to me, Reviewed-by: Yicong Yang > --- > Change since v2: > - No change. > Link: https://lore.kernel.org/lkml/20221028022453.163186-2-chenweilong@huawei.com/ > > Change since v1: > - Drop "Device Tree Bindings" and reg's description > - Move description in top-level description. > - Add gpio-cells to required > - Use additionalProperties and decimal numbers > - Use IRQ flags > - Use vendor,soc-ipblock format > Link: https://lore.kernel.org/lkml/20221026034219.172880-2-chenweilong@huawei.com/ > > .../gpio/hisilicon,ascend910-gpio.yaml | 56 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml b/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > new file mode 100644 > index 000000000000..735d97d645a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/hisilicon,ascend910-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HiSilicon common GPIO controller > + > +maintainers: > + - Jay Fang > + > +description: > + The HiSilicon common GPIO controller can be used for many different > + types of SoC such as Huawei Ascend AI series chips. > + > +properties: > + compatible: > + const: hisilicon,ascend910-gpio > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + ngpios: > + minimum: 1 > + maximum: 32 > + > +required: > + - compatible > + - reg > + - interrupts > + - gpio-controller > + - "#gpio-cells" > + - ngpios > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + gpio@840d0000 { > + compatible = "hisilicon,ascend910-gpio"; > + reg = <0x840d0000 0x1000>; > + ngpios = <32>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = ; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d42e34d1e8e2..74ac2e7a8e4b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9212,6 +9212,7 @@ HISILICON GPIO DRIVER > M: Jay Fang > L: linux-gpio@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/gpio/hisilicon,ascend910-gpio.yaml > F: drivers/gpio/gpio-hisi.c > > HISILICON HIGH PERFORMANCE RSA ENGINE DRIVER (HPRE) >