Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kumar, M Chetan" <m.chetan.kumar@intel.com>
To:     "zhaoping.shu@mediatek.com" <zhaoping.shu@mediatek.com>,
        linuxwwan <linuxwwan@intel.com>,
        "loic.poulain@linaro.org" <loic.poulain@linaro.org>,
        "ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "Liu, Haijun" <haijun.liu@mediatek.com>,
        "xiayu.zhang@mediatek.com" <xiayu.zhang@mediatek.com>,
        "lambert.wang@mediatek.com" <lambert.wang@mediatek.com>
Subject: RE: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock
Thread-Topic: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock
Thread-Index: AQHY7bX5vZQ9B2OaeUWy5bsZkYn9Ja4tLyVg
Date:   Thu, 3 Nov 2022 13:34:59 +0000
Message-ID: <SJ0PR11MB5008E87F9635347AC0EB2B20D7389@SJ0PR11MB5008.namprd11.prod.outlook.com>
References: <20221101055033.47837-1-zhaoping.shu@mediatek.com>
In-Reply-To: <20221101055033.47837-1-zhaoping.shu@mediatek.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WcQbR7XUke6Pch+jRJjcn7JUnAU8hjls+kVpRxJNol3CaTvs26ezmwrG++4m?=
 =?us-ascii?Q?xBVjTDdXHLh3gLR7DIv2xVsjz9jSsqobv/Bu/BsTEUNgJR5XA9OqyozG9qvG?=
 =?us-ascii?Q?EJiAJ2Oxp8rY4EUYUXwOSIU/eg0EP40N/qRyYJvDsDAK+mN3Qrm0eZUw/OQc?=
 =?us-ascii?Q?OA68dfOEIF6Hf7GohhzUOrJKM/rqhGDkFOX8jHE0brNqJk6IBRjLKUz5+1zK?=
 =?us-ascii?Q?W7AworV5/S0YdDZVVxaxctQdEPny7Sg8H6H3XjUs+97WM/IRTCwMWneN2Rjs?=
 =?us-ascii?Q?pTiivWvfMLGNH3R0LTEo/jG1a8qgnMSR2TcKnv5VpDotAIEJQPxPKBru+mT3?=
 =?us-ascii?Q?VsGh1xnlHL6XGpEMkKnWjfxy0bUtWRjTxCCIAUlBb52pEL6Mh5ss1sJzRrPu?=
 =?us-ascii?Q?UdW4axK0Aw/b7Ia7OtsZMlEk7IpAXIMNBDwIQHV4WMQfmHffORdeiHkF2eda?=
 =?us-ascii?Q?6fUHqwqzuUEddT7FISCN8U2RU7OZb9OaheMR02KmfX1Ey9pWpM/LHkEruop4?=
 =?us-ascii?Q?lyxQG0hPGqFRbQUtfw806JG206cjOOYm10nsxeig9/2oK+kwEqwm3q2iIEV1?=
 =?us-ascii?Q?AFDjlkcTWwSA9dCA3CE2YrEEiv1gxm+lVSbKzTxthDulWW7bTwWfZMgMiC3r?=
 =?us-ascii?Q?HQsrGkNzXDHSl72+2VGhW42+TtoSDQOqvSEqsvKWiPKkHyKzDBel3dvfZ9Qv?=
 =?us-ascii?Q?pRgo3Xb2LHIxlTD4u6ug4Q09QO0dEW1Apt1c5nF0wgQkmpzUaxJYNx+ikMjm?=
 =?us-ascii?Q?ZJGuhd2YjaU+UbhQpTgyog8j8s/uDB9qaHeUqOG8cJhbxMkeWqBs8edJQrRg?=
 =?us-ascii?Q?HYgLUn0daFsgoa91+c6I3ne7MJpM3btNuEOvd3XKFx4JWIiXQj0I1j0ta29w?=
 =?us-ascii?Q?oqmaDTKpBJKZRKO+TzQEpQH6SjiEczVk//H4+tUG5dI3ycz5biNp2Rqmf/Ea?=
 =?us-ascii?Q?R+7UYpMQHi7ZwA83iTuv0rjXrJfgw8ZcqwKsNfvA3XIEyzyptOApiHyvUuE9?=
 =?us-ascii?Q?n3nhGSnhr1aQx5hc0La77/YJsQRTXAEScmEJMtgywsjZ6MB5ASZnLmJl+lZA?=
 =?us-ascii?Q?y9m909m7B3uhUaGFaMxayl5sWf5QMHg2Qpeug0jRwcSLXjp2dqL0H6e8qdLz?=
 =?us-ascii?Q?JnXuDyvGir7Wbnv6OzhCtFqdFxQhkXC92h/HAzsrTKbzB4Qi02SxGmkvtpFX?=
 =?us-ascii?Q?HYV6DRNvdUxRpCqIjvs+XNiFbpfZrPYcjLpo1umhhhMrtTc6hKajKPOfQtX1?=
 =?us-ascii?Q?PZptMGZfN3Lr5tRp/YwecPsXYFOrkS8V0Kbb58tXiufK8/cBSeoC0Do8kVeq?=
 =?us-ascii?Q?FBUMLyKRBhwLRkULuVM7nnoWcp7lJEOZMLo72scDyMu2KJVnogQUItsQdrQq?=
 =?us-ascii?Q?GEprkkDsk9AjD2pfUF78O0P3Roplo7JRZUUAjjl/dEqwcyWAvWTS5pFul7hl?=
 =?us-ascii?Q?6mRRXd31MpUzORM2eY1mduFqX5xqYfeb1nqwdkk7n8yCGiMAdA0oSaMRst1R?=
 =?us-ascii?Q?zE0E264orI5YtKMbOcYP784hWkzosEZ9I4Io5iPskrYMGI9dO7CFQ0IVBCWs?=
 =?us-ascii?Q?wuZKhxEfYEXN5z384gn/UimrlMMmo33lR1x/AzVq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5008.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4418311f-5a5e-44c3-2024-08dabda03408
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 13:34:59.1242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H+kQK2pecR6KsfOIuNJcfWWLdLG0QDrApWs0C5s5SS5q3GqCqdKJSTRpnhBCNLMQZvO97RkZ7Y9SXT9CF5xYrufmi6+nrYDgJ8iEdRsbiMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5894
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: zhaoping.shu@mediatek.com <zhaoping.shu@mediatek.com>
> Sent: Tuesday, November 1, 2022 11:21 AM
> To: Kumar, M Chetan <m.chetan.kumar@intel.com>; linuxwwan
> <linuxwwan@intel.com>; loic.poulain@linaro.org; ryazanov.s.a@gmail.com;
> johannes@sipsolutions.net; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; matthias.bgg@gmail.com
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; Liu, Haij=
un
> <haijun.liu@mediatek.com>; xiayu.zhang@mediatek.com;
> lambert.wang@mediatek.com; zhaoping.shu
> <zhaoping.shu@mediatek.com>
> Subject: [PATCH net v1] net: wwan: iosm: Remove unneeded if_mutex lock
>=20
> From: "zhaoping.shu" <zhaoping.shu@mediatek.com>
>=20
> These WWAN network interface operations (create/delete/open/close) are
> already protected by RTNL lock, i.e., wwan_ops.newlink(),
> wwan_ops.dellink(), net_device_ops.ndo_open() and net_device.ndo_stop()
> are called with RTNL lock held.
> Therefore, this patch removes the unnecessary if_mutex.
>=20
> Signed-off-by: zhaoping.shu <zhaoping.shu@mediatek.com>

Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>