Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40e3d678-b840-e780-c1da-367000724f69@opensynergy.com>
Date:   Thu, 3 Nov 2022 14:55:49 +0100
Subject: Re: [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.
Content-Language: en-US
To:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Harald Mommer <harald.mommer@opensynergy.com>
Cc:     virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>
References: <20220825134449.18803-1-harald.mommer@opensynergy.com>
 <20220827093909.ag3zi7k525k4zuqq@pengutronix.de>
From:   Harald Mommer <hmo@opensynergy.com>
In-Reply-To: <20220827093909.ag3zi7k525k4zuqq@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXo2ZGpjOGZHVlZ1YjlxaVB6ZzBtQmEyOVBacGNkZVE5ZGJkN0JSczY5WDMv?=
 =?utf-8?B?aXJqRGk3RGozWDVteExNanVSTGgvUTd0NEdzdFpjUWFkS0x4R21leGt0Skwx?=
 =?utf-8?B?RjRrVUZFLzlMNlYyOTIwNkpacEJhRkJQVE1sMFVXZkl5dkdaN1hQLzVYUTZX?=
 =?utf-8?B?YjBOeitteTBobTNQYWVUOERFMVR3TzVHZnBHVVU5ZUViajJsU2U2SWlmWi9K?=
 =?utf-8?B?U2p6Uy9mSTk4RCsrNFlRK3pNeGt6UFplWGdVSmZJaDhlbFhzWHhJemxML29q?=
 =?utf-8?B?aDV2WmZsc2JXbjdxb2hpcUFEOGYxUVBlcHFYSnk4WDIxQytIUDR1VGp1ejlI?=
 =?utf-8?B?V0VHa0pvdnVLWHV5aEtER3ZkU3JMeVJzTnZ3YitlcVdSd1FRSUFtbDFPRURl?=
 =?utf-8?B?VWtQV3V4VFhBNjB0Z1JFcndyZGcvUS9ZODNQaXpXeVd4YWtWM1NzRTN4RU5h?=
 =?utf-8?B?M1NHZmNaa3A4MkUvQWNMYmZ4SmFpZXZnb2FyOU4vR0VSdHpibjc0QzB4VS80?=
 =?utf-8?B?UWxBRkhHN1dlWUd6M0FSOEkwdys1eW4yK0RkWEpqcFB4UWg4OFBoVjZONTZo?=
 =?utf-8?B?eWYxN0wwZW9vNDhHWVBkcHQvUzlxNHVMWDF3SkhXNEVCNXIxa0RVOTVWdW5J?=
 =?utf-8?B?dFY4dUs5Zll4ckQ4bDZTVy9wdkdNTFRxNUZVYk5ENGQxN29rVmtyaWQybXNP?=
 =?utf-8?B?NXNLZnF1TWM2ZzF5L0RZTkVNS2xoWkYyOXk1UENydEhQVGNqb0I0Y2pSQWw4?=
 =?utf-8?B?Ym53ZWdjbUphMUsxL09OazJzOGlhazQrWHl6anhJZGMyclpxTjBRY1F1aG9r?=
 =?utf-8?B?TG9XdFZWbksrbldzRndGVmZnN2d2UHc4VmhrYUgwL3RSZFVSK3Q3OHFLc0lE?=
 =?utf-8?B?WDB0Tk1WaUFMOE9reHNuZEtueS9HQ01EWVdleEFXWjNCZzlRQlE3RjRYVWRl?=
 =?utf-8?B?VE1YT3hqNXlvamlCVE83WGt1QVZlK1FVZ0xxQzBHNG12djVETWgrcm1CR0Zj?=
 =?utf-8?B?UE9VZ1hCMkxkbXlkeFlNbmo1aWdJRGFkdk1CbENqM2hDNzRxdk9aN0Flb3dB?=
 =?utf-8?B?b3VCYld4aU9DVUJIR0djT1VJejhuZCtuMFdhaDhhR2tGdWhOM1RPTDlmVGtU?=
 =?utf-8?B?RmpTVkhUSnBPR2UycENOMXM4bE1QVEl2V3ZPd0ZxbWJ2T3dhL3gyUUk2OWhl?=
 =?utf-8?B?azhyYjU4YlJFaFVGNEdBczJmN2JiSDIxVm8rRVZnbitiQU5GckhiR0Z6QjBm?=
 =?utf-8?B?N2lnbjFVR1h5UUkvaHhzbkJtNnkyQVVnMkVvaFQ0VXVtODdoMDFiQTVZSXpQ?=
 =?utf-8?B?djJqZ29Uc1hTKzRQaG9UR1VFNWYxSHVjRHAxR0NzbDRQcmVVT0dkdlRsZzQ0?=
 =?utf-8?B?N1ZnMitQbDBVQ1BVckNST1FFM3c3Sy9NVUsyRTErdi92T3dMaFQ2TjdsRCt6?=
 =?utf-8?B?cnFoL05ReDlneGdGd2oxR1p2dTlmaHVkVDdheVNhaXRCTEdGWW5Kdi9IVUZ0?=
 =?utf-8?B?RFpiNW1Pa0x2SUZWaVNJTDdpMFJ0bWtldExNQ1JBQ1hWR3VXdkxKN2lMWUgw?=
 =?utf-8?B?SmVmZDdvSkdYb0liOURCaWdzRDhwZzNyOVoySGpubVFNSDJCNTBSOG9RaE1I?=
 =?utf-8?B?UEdaeDJWcVpnVFQxZk5ueHl0dUNVM0Zhd291dHVFUmFrbUtDdThvQmRFU25n?=
 =?utf-8?B?Rzc1RlJWK1BOWmY2TU50QmR4MFFnd1Y1NzNRb2tiM3k4YzRiN011aC84UHRW?=
 =?utf-8?B?cSt1ZEdZY2ZKeE8weVlaUGFmZVJxRWoxa0tCeVlnV2xyRmJxTHd3ZUhFOTEx?=
 =?utf-8?B?aFFrRlQzazIrVGRlM05VRXM5VEsxYUxzTC9UbG5rSlFscStVVkMvNFcyeEpi?=
 =?utf-8?B?cHB1c1d5UjBhWlN0ZXFnVFRmN1VSaHVlKysrcmcybXlHVDF1TjN3MUtqZVhT?=
 =?utf-8?B?UWlyckt0WG1xZ3hOSEw4dHNoOE1XWTMyK0hza3Q3aHA2MUt6ZkxMZnRlZmpJ?=
 =?utf-8?B?dUhtdHBNdmJNQzdzMFRPMmV1em1UWS9rTFJ2MnVkSnphUDJ0U1BRSk5sRzAr?=
 =?utf-8?B?YlhSaHYyYU0zRm9jZE1KR0VVdnZ1c085SXFhakhlS0w3ZU44S2FZWFhBT0RS?=
 =?utf-8?Q?tmxJ9y7RfqxNX/KrdpU9xyIT+?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89b4fd35-0339-40c5-99e0-08dabda31e0f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4352.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 13:55:50.9410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hB0fvT3LrPcyZAartBw8pEuBxV6Snz/a3aQppujD21zsrAFhMqj+vrYFJH6NpHFxIuzZCWmqFpLHKyWnebj02w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7626
X-TM-AS-ERS: 104.47.18.110-0.0.0.0
X-TMASE-Version: StarCloud-1.3-9.0.1006-27240.007
X-TMASE-Result: 10--9.073100-4.000000
X-TMASE-MatchedRID: scwq2vQP8OGwzFuyya2WsK5i3jK3KDOoC/ExpXrHizzDqO6/8R69QDy7
        zxidHhYpceyfeJ3+b5yrlBPOoG5/+mMNX/9K+QfeKsurITpSv+PYjw1QqLfrRlp6v7WJomQQ0g2
        9rlyDgeZzwb9qaRe4kznanZX3BevfYLmTo2ikrFhbKUNQk650Hb8pAYpAfWtAUV7F0kclfoLKse
        rwLhBtWxz8ZXwvG5ffuXFEQJaCEz5Nfs8n85Te8oMbH85DUZXyYxU/PH+vZxv6C0ePs7A07Y6HM
        5rqDwqt8vIo/swojrhqUiXJIvZQRWXtHqIpAbE4XXDPI+QVWIaFT0hWkhTT0g==
X-TMASE-XGENCLOUD: 92539c31-4b35-4a5a-99a5-76317ea19802-0-0-200-0
X-TM-Deliver-Signature: C91A334149CFFBD25F8C42A8AD5B59DB
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opensynergy.com;
        s=TM-DKIM-20210503141657; t=1667483754;
        bh=mFhArZiOB1ICjmPE/1sfWXlwB6eAA4Mn91DeHggw+Ug=; l=843;
        h=Date:To:From;
        b=AxV6idlYMX2X51G4sY80cFJ9upkrtGVJ+AXzcK6TesrZemodcMIzW07b3REQeMh3r
         kqj7AgPnThYIKu+21YfBDKSBXaQ3bVNfNwiD70NOBq492IHAMwmqy3sHAOAXD+uyvU
         z98zq/vaMktkx7xfb0Y2pYS+sudiVUWEqjulqOI9bEKyoRefZW8ArzsTI5XyEBDoJP
         18IeHfBsYhCjc9/NA46m0A4f+YH7iFNouZtMeGiLWXjuotDK06OBv7uIXKhhiH08pW
         8oG/9nPS02WhJya4bzDsoFmTD+4DE7RZ8n4LfIVl9TfSDD5Aa6tjCHNbxhgUmrlQXU
         fh1yb03EEKCiQ==
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 27.08.22 11:39, Marc Kleine-Budde wrote:
> Is there an Open Source implementation of the host side of this
> interface?
there is neither an open source device nor is it currently planned. The 
device I'm developing is closed source.
> Please fix these checkpatch warnings:
>
> | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> | #65:
> | new file mode 100644
> |
Addressed most of the checkpatch warnings. Regarding the BUG_ON() 
minimized usage. Removed where not necessary, reworked where a better 
error handling was possible, kept where I don't think it will catch ever 
but if it catches I would like to know. Of course I could make the tool 
happy but on the other hand I don't want to fly completely blind in case 
a bug has to be hunted.
> regards,
> Marc

Regards
Harald