Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e870459c-70e8-b4f3-ef7e-4dde0e952b3d@samsung.com>
Date:   Thu, 3 Nov 2022 16:19:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0)
        Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH] Revert "usb: dwc3: disable USB core PHY management"
Content-Language: en-US
To:     Johan Hovold <johan+linaro@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Stefan Agner <stefan@agner.ch>, stable@vger.kernel.org
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20221103144648.14197-1-johan+linaro@kernel.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20221103144724eucas1p2a1b7c96e013cb32ae24f4bb8b353771d@eucas1p2.samsung.com>
        <20221103144648.14197-1-johan+linaro@kernel.org>
Precedence: bulk

On 03.11.2022 15:46, Johan Hovold wrote:
> This reverts commit 6000b8d900cd5f52fbcd0776d0cc396e88c8c2ea.
>
> The offending commit disabled the USB core PHY management as the dwc3
> already manages the PHYs in question.
>
> Unfortunately some platforms have started relying on having USB core
> also controlling the PHY and this is specifically currently needed on
> some Exynos platforms for PHY calibration or connected device may fail
> to enumerate.
>
> The PHY calibration was previously handled in the dwc3 driver, but to
> work around some issues related to how the dwc3 driver interacts with
> xhci (e.g. using multiple drivers) this was moved to USB core by commits
> 34c7ed72f4f0 ("usb: core: phy: add support for PHY calibration") and
> a0a465569b45 ("usb: dwc3: remove generic PHY calibrate() calls").
>
> The same PHY obviously should not be controlled from two different
> places, which for example do no agree on the PHY mode or power state
> during suspend, but as the offending patch was backported to stable,
> let's revert it for now.
>
> Reported-by: Stefan Agner <stefan@agner.ch>
> Link: https://lore.kernel.org/lkml/808bdba846bb60456adf10a3016911ee@agner.ch/
> Fixes: 6000b8d900cd ("usb: dwc3: disable USB core PHY management")
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>   drivers/usb/dwc3/host.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index a7154fe8206d..f6f13e7f1ba1 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -11,13 +11,8 @@
>   #include <linux/of.h>
>   #include <linux/platform_device.h>
>   
> -#include "../host/xhci-plat.h"
>   #include "core.h"
>   
> -static const struct xhci_plat_priv dwc3_xhci_plat_priv = {
> -	.quirks = XHCI_SKIP_PHY_INIT,
> -};
> -
>   static void dwc3_host_fill_xhci_irq_res(struct dwc3 *dwc,
>   					int irq, char *name)
>   {
> @@ -97,11 +92,6 @@ int dwc3_host_init(struct dwc3 *dwc)
>   		goto err;
>   	}
>   
> -	ret = platform_device_add_data(xhci, &dwc3_xhci_plat_priv,
> -					sizeof(dwc3_xhci_plat_priv));
> -	if (ret)
> -		goto err;
> -
>   	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
>   
>   	if (dwc->usb3_lpm_capable)

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland