Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef637642-7d0f-66b8-2225-b6f8609f037e@gmail.com>
Date:   Thu, 3 Nov 2022 14:49:31 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] cpufreq: SPEAr: Make read-only array sys_clk_src static
Content-Language: en-US
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221103143654.85275-1-colin.i.king@gmail.com>
 <20221103143807.tamhepos3cureoga@vireshk-i7>
From:   "Colin King (gmail)" <colin.i.king@gmail.com>
In-Reply-To: <20221103143807.tamhepos3cureoga@vireshk-i7>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/11/2022 14:38, Viresh Kumar wrote:
> On 03-11-22, 14:36, Colin Ian King wrote:
>> Don't populate the read-only array sys_clk_src on the stack but instead
>> make it static and add in a missing const. Also makes the object code a
>> little smaller.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   drivers/cpufreq/spear-cpufreq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
>> index 7d0d62a06bf3..c6fdf019dbde 100644
>> --- a/drivers/cpufreq/spear-cpufreq.c
>> +++ b/drivers/cpufreq/spear-cpufreq.c
>> @@ -39,7 +39,7 @@ static struct clk *spear1340_cpu_get_possible_parent(unsigned long newfreq)
>>   	 * In SPEAr1340, cpu clk's parent sys clk can take input from
>>   	 * following sources
>>   	 */
>> -	const char *sys_clk_src[] = {
>> +	static const char * const sys_clk_src[] = {
>>   		"sys_syn_clk",
>>   		"pll1_clk",
>>   		"pll2_clk",
> 
> Same questions from longhaul patch apply here too.
> 
See answer in that patch :-)

But really, this is kind of basic C level stuff. I suggest reading K&R 
2nd Edition, Section 4.6, last paragraph before exercise 4-11.