Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Nov 2022 16:45:04 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tomer Maimon <tmaimon77@gmail.com>
Cc:     Joel Stanley <joel@jms.id.au>,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Hector Martin <marcan@marcan.st>,
        Arnd Bergmann <arnd@arndb.de>, Sven Peter <sven@svenpeter.dev>,
        openbmc@lists.ozlabs.org, Brian Norris <briannorris@chromium.org>,
        linux-kernel@vger.kernel.org,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Conor Dooley <conor.dooley@microchip.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH v5 RESEND] soc: nuvoton: Add SoC info driver for WPCM450
Message-ID: <Y2PiAKBTtnAjlToY@probook>
References: <20221031223926.241641-1-j.neuschaefer@gmx.net>
 <CACPK8Xfa=SPaYogqfUpCG61J7U-Z8pE2Oycicd_D=4vJsZcaSw@mail.gmail.com>
 <CAP6Zq1iHOm1sQTHshmVobzy9yX_REt6OL5qyFz+R77vYw=7yBg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="z9Gk8xtTBSjinse8"
Content-Disposition: inline
In-Reply-To: <CAP6Zq1iHOm1sQTHshmVobzy9yX_REt6OL5qyFz+R77vYw=7yBg@mail.gmail.com>
UI-OutboundReport: notjunk:1;M01:P0:la8mB4y0vLQ=;etpPBLNCdJNEMYZHWh/q4+MyA9c
 fmJeWOsda5DRiI8cxtRDiXs+IvTC8WM0aAYvQNhHXvNyc9UY67w+Sk6cbapdRmFXvLKJjZw4b
 S/pyjDkKMApi1H59/EhQ4YH+Zh0WHWLr/XyXbHb6PeZ+Xy2BhhIy5LEYFm8p8Kp/+ZDx3T0ZO
 gApG2BRUyt6np8Us2gmhfVycJvQhj1eed7ecoWH6f/zhjxO4R0Bu3xbd8YN1JKpSSzpLeZK80
 JtvQOChiUlQ9oP51ufMmSQOKLVmGr/flF0NqPfi6xK+HZHStaQxP6+2FmOtm/DzoM7M0BBgzg
 +rrGtGILnrR/qWSubrYS7eNVrSv7iaVjHEZT5RlCIElKL4LNpjLT6kYozw1vtc1iNw1kbMdDl
 +LJTcKIR2FjJuV+sSh5hoRPTA0J6p32IaLTaJYQuma/ekFLS0O8B5A0KO670dMhvPYBeZGs0Y
 S8dPDjtLeMZJSoRrJRIKvxnLYlHNY6Lkrv//qB3HngI6VfwjgI6zYpPOJzOJsZ9yN0UQVlDXM
 rWAc3dMiDFMMCdHhjnaTBXsdhXhg7oc9g7Y/Z4ayqRjWFbvOmMwsl8C7rKCdbJK1awNTuLk4D
 alth1x40yLP+qvgN0xJ7IG6X3iteY36/M0O3PIHzy4PPk27gHLC8LpDTtIXtHetfELsqTTYn4
 ZndFzlS+n+hquVUTtRIw+SLibyBlYfSJapbjoXBzVeIEzFyYx3HyI5S4T8Snc42oU4wHWX879
 3SwCD11LF8H5SvdMKNCHcEDf94KwuL/FybFaewptNWSyyIZ4OZIn3vIXVpocGWDHgTVnXccaY
 WtzYW/nKBVRY30RYln3vFnvyyXbBiiWuitEqrA1KHaK40MHy1MDc6yDVpYnQOHj2t/Avihlvj
 UZoAA5zkYGpUyP1H1YLiJQu9Kcz+bEpqvSPT4Z8F2OD1UisrI2HtGrWqz9X8lAbFgKXmtYuuO
 80oPjd1NU/eAfZC8txIECdpAL8s=
Precedence: bulk


--z9Gk8xtTBSjinse8
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 03, 2022 at 09:11:08AM +0200, Tomer Maimon wrote:
> Hi Jonathan,
>=20
> Thanks for your patch.
>=20
> On Thu, 3 Nov 2022 at 01:09, Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Mon, 31 Oct 2022 at 22:40, Jonathan Neusch=C3=A4fer <j.neuschaefer@g=
mx.net> wrote:
> > >
> > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > > information such as the SoC revision.
[...]
> > > +++ b/drivers/soc/nuvoton/Kconfig
> > > @@ -0,0 +1,11 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +menuconfig WPCM450_SOC
> > > +       tristate "Nuvoton WPCM450 SoC driver"
> > > +       default y if ARCH_WPCM450
> > > +       select SOC_BUS
> >
> > Sorry for not noticing this earlier. This is a bit confusing. If we
> > have a menu option, the soc driver should appear under it. Or we could
> > do without the menu all together, as there's only one driver so far.

Good point.

> >
> > We also should select REGMAP, as you're using it,

I'll add it.

> > and hide the option behind ARCH_WPCM450 || COMPILE_TEST.
> >
> > How about this:
> >
> > if ARCH_WPCM450 || COMPILE_TEST
> These days we working on LPC BPC driver for NPCM7xx and NPCM8xx that
> will be placed in nuvoton soc folder.
> we will use:
>=20
> if ARCH_NPCM || COMPILE_TEST
>=20
> menu "NPCM SoC drivers"

That sounds reasonable, I'll do something similar.

> Maybe you should remove
> if ARCH_WPCM450 || COMPILE_TEST
>=20
> and add ARCH_WPCM450 dependency in the WPCM450_SOCINFO driver configurati=
on.

The WPCM450_SOCINFO driver would build fine on other NPCM SoC, it just
wouldn't be very useful, so I think the current "default y if ARCH_WPCM450"
solution is sufficient.

>=20
> >
> > config WPCM450_SOCINFO
> >         tristate "Nuvoton WPCM450 SoC driver"
> >         default y if ARCH_WPCM450
> >         select SOC_BUS
> >         select REGMAP
> >         help
> >           Say Y here to compile the SoC information driver for Nuvoton
> >           WPCM450 SoCs.
> >
> >           This driver provides information such as the SoC model and
> >           revision.
> >
> > endif


Thank you both,
Jonathan

--z9Gk8xtTBSjinse8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmNj4ccACgkQCDBEmo7z
X9ssaA//eNzqncSzzvszShSHI+DKqydLRmZ2jZkKhjTh1QyYswkvH+4APbIvIYK0
DWSJiXDouzNR3lpqDq2AzPbXclfWnBS2nU52n64svRf3BDTczNqkHEhUCeCo2o00
RQ+pToPS1aqhjrAg5aZB4XU2fVPUZ4OTce00NeQs+5w/8EyTKxc6knsd/H6uxkb7
2dIU9Qll+FfXF6QYJMUw73QEYgT5kzuvCkZ65G0FzCZR8uTzjS2Wole4DBp+3rvP
4Jmykgqnh9lif1+L24L6Bf6O/mplQG1poMNrIK98oXLhB22lKB4s6ShQQxWFT+Zu
saW3jxwX3Rp8Bb8nWAVG48wcRAFu+OZUREvBye6nDwV6XEFdS+MR+lLQXCpDfONm
XHtIUvUMWvpVIRYN3wgIAqCvIfjIu4QuDYCuR3gz8YEBoeyDw14ha/QWt8J2nUmQ
GfVF7LAqTvhdqP+UEr1nHHNl9i6pf9f90WYbXwuvIPuV09QTHjS9F2D63aTR0z6H
nPi1u5HyPFaNPJZXsWTgUmzNXJYrUQWWeRLCcsmDV7Jot7ZS2semcUKL3xZuRFCM
ahN/K2b01hhsl1SiiBJNGgRMvW2rek644WaWk7z+eJQPzQlHIXo384h0+wAsmqlV
6P6EQFA7nqPji1tnQydxduZIySHQhve39m04g7zQCCmce9jYGSc=
=Y2a2
-----END PGP SIGNATURE-----

--z9Gk8xtTBSjinse8--